Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023824Openbravo ERPA. Platformpublic2013-05-15 10:122013-05-27 13:46
Reporteregoitz 
Assigned Toshankarb 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP24 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0023824: Add the possibility to make the notes on the window read only if the tab is also readonly
DescriptionRight now when a tab for a user is only readable, notes can be created.
It should be good to have the possibility to make also the notes only readable.

Steps To Reproduce-make on tab only readable for a role
-Access with that role and see that you can still ad notes
Proposed Solution-Add a preference
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0023921 closed shankarb Add the possibility to make the attachments on the window read only if the tab is also readonly 
related to feature request 0023948 closed shankarb Add sever side security to avoid creating notes on read only tabs 
related to defect 0033736 closed caristu "Disable Notes For Read-Only tabs" preference is not working 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-05-15 10:12egoitzNew Issue
2013-05-15 10:12egoitzAssigned To => shankarb
2013-05-15 10:12egoitzModules => Core
2013-05-15 10:12egoitzTriggers an Emergency Pack => No
2013-05-15 17:11johnfandlNote Added: 0058663
2013-05-16 16:56shankarbReview Assigned To => AugustoMauch
2013-05-16 16:57shankarbIssue Monitored: AugustoMauch
2013-05-16 16:58hgbotCheckin
2013-05-16 16:58hgbotNote Added: 0058674
2013-05-16 16:58hgbotStatusnew => resolved
2013-05-16 16:58hgbotResolutionopen => fixed
2013-05-16 16:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6f8628f030ee377f195afdc2b589764509226d38 [^]
2013-05-23 01:33hudsonbotCheckin
2013-05-23 01:33hudsonbotNote Added: 0058823
2013-05-24 20:37johnfandlNote Added: 0058945
2013-05-27 13:46AugustoMauchNote Added: 0058956
2013-05-27 13:46AugustoMauchStatusresolved => closed
2013-05-27 13:46AugustoMauchFixed in Version => 3.0MP24
2013-05-27 15:53shankarbRelationship addedrelated to 0023921
2013-05-30 17:06AugustoMauchRelationship addedrelated to 0023948
2016-08-22 08:34caristuRelationship addedrelated to 0033736

Notes
(0058663)
johnfandl   
2013-05-15 17:11   
In some public companies in the U.S. it can be very important for compliance reasons to be able to create a true "read only" role, which cannot affect any part of the database at all.
(0058674)
hgbot   
2013-05-16 16:58   
Repository: erp/devel/pi
Changeset: 6f8628f030ee377f195afdc2b589764509226d38
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu May 16 10:55:38 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/6f8628f030ee377f195afdc2b589764509226d38 [^]

Fixes Issue 0023824: Read only notes for read only windows.

Added a new preference Disable Notes For Read Only Tabs. When the preference is set to 'Y', notes section is not editable in read only windows.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-notes.js
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0058823)
hudsonbot   
2013-05-23 01:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/97c7f6256af7 [^]

Maturity status: Test
(0058945)
johnfandl   
2013-05-24 20:37   
Note that the overall customer requirement is:

true "read only" role, which cannot affect any part of the database at all.

So, I realize that attachments (table C_File) also fall under this. To fully meet the requirement also requires that a preference "Disable Attachments For Read Only Tabs" also be added.

Sorry for the omission, I just realized it.
(0058956)
AugustoMauch   
2013-05-27 13:46   
Code reviewed and verified in pi@20388faf6420