Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0023651 | Openbravo ERP | A. Platform | public | 2013-04-26 12:41 | 2013-07-28 11:36 |
|
| Reporter | marvintm | |
| Assigned To | AugustoMauch | |
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0MP26 | |
| Merge Request Status | |
| Review Assigned To | shankarb |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0023651: Message in StandardWindowComponent is not always correct |
| Description | There is a check in StandardWindowComponent which checks whether the structure of the window definition is correct. This check is done at the end of the getRootTabComponent, and a message is shown in line 181 ("Window has more than on tab on level 0, choosing an arbitrary root tab")
The check itself is correct, but the message is not always right. The check will also fail if two tabs have the same sequence number, and different tab levels. It is fine that the check fails in this case, but the message shown there should not be the one shown (because this can also happen in a level different from 0, and the problem then is not that the tabs have the same level on level 0, but that they have the same sequence number). |
| Steps To Reproduce | - Install retail pack version RMP21 or earlier.
- Verify that the message is shown when going to the organization window. It is true that the definition of the window is incorrect, but the message itself is also not correct either. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2013-04-26 12:41 | marvintm | New Issue | |
| 2013-04-26 12:41 | marvintm | Assigned To | => AugustoMauch |
| 2013-04-26 12:41 | marvintm | Modules | => Core |
| 2013-04-26 12:41 | marvintm | OBNetwork customer | => No |
| 2013-04-26 12:41 | marvintm | Triggers an Emergency Pack | => No |
| 2013-07-26 08:21 | shankarb | Assigned To | AugustoMauch => shankarb |
| 2013-07-26 13:43 | AugustoMauch | Assigned To | shankarb => AugustoMauch |
| 2013-07-26 13:43 | AugustoMauch | Issue Monitored: shankarb | |
| 2013-07-26 13:43 | AugustoMauch | Review Assigned To | => shankarb |
| 2013-07-26 13:48 | hgbot | Checkin | |
| 2013-07-26 13:48 | hgbot | Note Added: 0060308 | |
| 2013-07-26 13:48 | hgbot | Status | new => resolved |
| 2013-07-26 13:48 | hgbot | Resolution | open => fixed |
| 2013-07-26 13:48 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/0b7bf7e1522c81b8ca68677b58e5df2c23815a04 [^] |
| 2013-07-26 13:54 | AugustoMauch | Note Added: 0060310 | |
| 2013-07-28 03:09 | shankarb | Note Added: 0060321 | |
| 2013-07-28 03:09 | shankarb | Status | resolved => closed |
| 2013-07-28 03:09 | shankarb | Fixed in Version | => 3.0MP26 |
| 2013-07-28 11:36 | hudsonbot | Checkin | |
| 2013-07-28 11:36 | hudsonbot | Note Added: 0060325 | |
|
Notes |
|
|
(0060308)
|
|
hgbot
|
|
2013-07-26 13:48
|
|
Repository: erp/devel/pi
Changeset: 0b7bf7e1522c81b8ca68677b58e5df2c23815a04
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Jul 26 13:46:55 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0b7bf7e1522c81b8ca68677b58e5df2c23815a04 [^]
Fixes issue 23651: A proper warning message is shown in StandardWindowComponent
The same warning message was being shown in these cases:
- 2+ tabs with the same sequence number but different tab levels
- 2+ tabs with tab level 0
A new check has been added to tell these two cases apart and to show the proper warning message in each case.
---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/StandardWindowComponent.java
---
|
|
|
|
|
Test plan: Test that in these cases the proper warning is shown in the log
- Two tabs with tabLevel 0
- Two tabs with same sequence number but different tab level, the tab level of one of them is 0
- Two tabs with same sequence number but different tab level, the tab level of both of them is not 0 |
|
|
|
(0060321)
|
|
shankarb
|
|
2013-07-28 03:09
|
|
|
Code reviewed and verified in pi changeset f49b9428b38d |
|
|
|
|
|