Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023643Openbravo ERPI. Performancepublic2013-04-25 16:582013-05-27 17:07
Reporterumartirena 
Assigned Toshankarb 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP24 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0023643: List of Dropdowns with more than 1000 fire a warning in the log.
DescriptionThis is a list of Dropdowns with more than 1000 fire a warning in the log:
 - In the window Organization, in tab Information the combo fields inpadUserId
 - In the window Stock Reservation, in tab Stock the combo fields inpmReservationId
 - In the window Process Request, in tab Process Request the combo fields inpadUserId
 - In the window Sales Order, in tab Reserved Stock the combo fields inpmReservationId,inpmReservationStockId,inpcOrderlineId
 - In the window Role, in tab Field Access the combo fields inpadTabAccessId
 - In the window Sales Invoice, in tab Line Tax the combo fields inpcInvoiceId
 - n the window Sales Order Line, in tab Sales Order Line the combo fields inpmProductUomId
Steps To ReproduceThis messages are shown in the log when this combos had more than 1000 values
Proposed SolutionChange the reference of this columns from table or tabledir, depending on the case, to selectors, existing ones or new ones.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 00262673.0PR14Q3 closed shankarb Re-implement combos (table and tableDir) to use datasources 
Attached Filesdiff Fix23643.diff (25,067) 2013-05-06 05:42
https://issues.openbravo.com/file_download.php?file_id=6125&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-04-25 16:58umartirenaNew Issue
2013-04-25 16:58umartirenaAssigned To => AugustoMauch
2013-04-25 16:58umartirenaModules => Core
2013-04-25 16:58umartirenaTriggers an Emergency Pack => No
2013-05-02 15:52shankarbAssigned ToAugustoMauch => shankarb
2013-05-06 05:41shankarbStatusnew => scheduled
2013-05-06 05:41shankarbfix_in_branch => pi
2013-05-06 05:42shankarbFile Added: Fix23643.diff
2013-05-06 10:53umartirenaNote Added: 0058465
2013-05-06 12:01shankarbReview Assigned To => AugustoMauch
2013-05-06 12:01shankarbfix_in_branchpi =>
2013-05-06 12:02shankarbIssue Monitored: AugustoMauch
2013-05-06 12:03hgbotCheckin
2013-05-06 12:03hgbotNote Added: 0058467
2013-05-06 12:03hgbotStatusscheduled => resolved
2013-05-06 12:03hgbotResolutionopen => fixed
2013-05-06 12:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ee1b12fcabead6e56883dad13d0da83c9a473091 [^]
2013-05-11 17:32hgbotCheckin
2013-05-11 17:32hgbotNote Added: 0058568
2013-05-11 18:39hgbotCheckin
2013-05-11 18:39hgbotNote Added: 0058569
2013-05-21 16:21AugustoMauchNote Added: 0058728
2013-05-21 16:21AugustoMauchStatusresolved => new
2013-05-21 16:21AugustoMauchResolutionfixed => open
2013-05-22 08:52hgbotCheckin
2013-05-22 08:52hgbotNote Added: 0058737
2013-05-22 08:52hgbotStatusnew => resolved
2013-05-22 08:52hgbotResolutionopen => fixed
2013-05-22 08:52hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/ee1b12fcabead6e56883dad13d0da83c9a473091 [^] => http://code.openbravo.com/erp/devel/pi/rev/5ca23b222c6307cc96e5a06e1ca6adca1ab58833 [^]
2013-05-23 01:32hudsonbotCheckin
2013-05-23 01:32hudsonbotNote Added: 0058767
2013-05-23 01:32hudsonbotCheckin
2013-05-23 01:32hudsonbotNote Added: 0058800
2013-05-23 01:32hudsonbotCheckin
2013-05-23 01:32hudsonbotNote Added: 0058801
2013-05-23 01:34hudsonbotCheckin
2013-05-23 01:34hudsonbotNote Added: 0058848
2013-05-27 17:07AugustoMauchNote Added: 0058972
2013-05-27 17:07AugustoMauchStatusresolved => closed
2013-05-27 17:07AugustoMauchFixed in Version => 3.0MP24
2014-05-09 10:25alostaleRelationship addedrelated to 0026267

Notes
(0058465)
umartirena   
2013-05-06 10:53   
One more warning found in another table, AD_COLUMN:

WARN org.openbravo.client.application.window.FormInitializationComponent - Warning: In the window Tables and Columns, in tab Column the combo fields inpadElementId contain more than 1000 entries, and this could cause bad performance in the application. Possible fixes include changing these columns from a combo into a Selector, or adding a validation to reduce the number of entries in the combo.
(0058467)
hgbot   
2013-05-06 12:03   
Repository: erp/devel/pi
Changeset: ee1b12fcabead6e56883dad13d0da83c9a473091
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu May 02 19:30:15 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/ee1b12fcabead6e56883dad13d0da83c9a473091 [^]

Fixes Issue 23643: List of Dropdowns with more than 1000 fire a warning in the log

Changed reference types to selectors to remove warning in the log.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
---
(0058568)
hgbot   
2013-05-11 17:32   
Repository: erp/devel/pi
Changeset: 355c1d0f60640f86007e28d1a01deb8ae4956f17
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Sat May 11 21:01:08 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/355c1d0f60640f86007e28d1a01deb8ae4956f17 [^]

Related to Issue 23721 : Backout changeset d17e521df335

Backedout changeset as it is related to issue 23643

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
---
(0058569)
hgbot   
2013-05-11 18:39   
Repository: erp/devel/pi
Changeset: 9e840b9d34961e84014f2df472853992e333ec73
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Sat May 11 21:30:40 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/9e840b9d34961e84014f2df472853992e333ec73 [^]

Related to Issue 0023643 : Added selector for element

Added selector for element field in ad_column table.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
---
(0058728)
AugustoMauch   
2013-05-21 16:21   
UOM combo in the Lines tab of the Sales Order window is not working. This HQL where clause is wrong: https://code.openbravo.com/erp/devel/pi/rev/ee1b12fcabead6e56883dad13d0da83c9a473091#l3.15 [^]
(0058737)
hgbot   
2013-05-22 08:52   
Repository: erp/devel/pi
Changeset: 5ca23b222c6307cc96e5a06e1ca6adca1ab58833
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed May 22 12:05:58 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/5ca23b222c6307cc96e5a06e1ca6adca1ab58833 [^]

Fixes Issue 23643 : Changed hqlWhereClause of product uom selector

The whereclause was comparing BaseOBObject with the current product id. Modified that to compare id with current product id.

---
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
---
(0058767)
hudsonbot   
2013-05-23 01:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/97c7f6256af7 [^]

Maturity status: Test
(0058800)
hudsonbot   
2013-05-23 01:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/97c7f6256af7 [^]

Maturity status: Test
(0058801)
hudsonbot   
2013-05-23 01:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/97c7f6256af7 [^]

Maturity status: Test
(0058848)
hudsonbot   
2013-05-23 01:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/97c7f6256af7 [^]

Maturity status: Test
(0058972)
AugustoMauch   
2013-05-27 17:07   
Code reviewed and verified in pi@20388faf6420