Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023598Openbravo ERPA. Platformpublic2013-04-19 19:502013-04-23 16:48
Reporterdbaz 
Assigned Todbaz 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP23 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0023598: Add capabilities to set tab ids to avoid in a particular existing button of the toolbar
DescriptionAdd capabilities to set tab ids to avoid in a particular existing button of the toolbar

The fix should not force to update any existing module, so the function 'registerButton' should behave as before with the new property 'tabIdsToAvoid' as null
Steps To ReproduceTo test the new functionality, you can just write this into the Firebug console. After it, open "Sales Order" tab, and notice there is no "Delete" icon button

OB.ToolbarRegistry.buttonDefinitions[5].tabIdsToAvoid = ['186']

Then open any other tab, and the "Delete" icon button is there
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-04-19 19:50dbazNew Issue
2013-04-19 19:50dbazAssigned To => dbaz
2013-04-19 19:50dbazModules => Core
2013-04-19 19:50dbazTriggers an Emergency Pack => No
2013-04-19 19:50dbazReview Assigned To => AugustoMauch
2013-04-19 19:50dbazIssue Monitored: AugustoMauch
2013-04-19 19:56hgbotCheckin
2013-04-19 19:56hgbotNote Added: 0058066
2013-04-19 19:56hgbotStatusnew => resolved
2013-04-19 19:56hgbotResolutionopen => fixed
2013-04-19 19:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/61602390f12366b3aebd98a1914fec993a302207 [^]
2013-04-19 19:56dbazNote Added: 0058067
2013-04-22 16:36hudsonbotCheckin
2013-04-22 16:36hudsonbotNote Added: 0058108
2013-04-23 16:48AugustoMauchNote Added: 0058138
2013-04-23 16:48AugustoMauchStatusresolved => closed
2013-04-23 16:48AugustoMauchFixed in Version => 3.0MP23

Notes
(0058066)
hgbot   
2013-04-19 19:56   
Repository: erp/devel/pi
Changeset: 61602390f12366b3aebd98a1914fec993a302207
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Apr 19 19:56:02 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/61602390f12366b3aebd98a1914fec993a302207 [^]

Fixed issue 23598: Added 'tabIdsToAvoid' capabilities to 'registerButton' function

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views-toolbar.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form-toolbar-button.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0058067)
dbaz   
2013-04-19 19:56   
Added new parameter 'tabIdsToAvoid' to 'OB.ToolbarRegistry.registerButton' function.
False/Null by default, so previous existing code will behave as before.
(0058108)
hudsonbot   
2013-04-22 16:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f78aa78542fa [^]

Maturity status: Test
(0058138)
AugustoMauch   
2013-04-23 16:48   
Code reviewed and verified in pi@d4a9088f6a09