Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023595Openbravo ERPB. User interfacepublic2013-04-19 15:512013-04-23 16:49
Reporterdbaz 
Assigned Todbaz 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP23 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0023595: "Copy record" toolbar button should only be executable when the record is not being edited
Description"Copy record" toolbar button should only be executeble when the record is not being edited.

This is because if the record is being edited, you can clone from an inconsistent record (where maybe, even all required fields are not set), so there is an uncertainty of what is going to be cloned
Steps To ReproduceAs "Openbravo Admin"
* Go to "Sales Order"
* Create new record (fill all required fields)
* Save
* Do some modifications (leave empty some required fields, change some combos value, ...)
* Press "Copy record" button ( http://wiki.openbravo.com/w/images/e/e6/WIK_button_Clone.png [^] )
* Note that the cloned object is not like you have left it.

Even more, if you do this operation in grid editing mode, you left a non-valid state row after the clone process
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-04-19 15:51dbazNew Issue
2013-04-19 15:51dbazAssigned To => dbaz
2013-04-19 15:51dbazModules => Core
2013-04-19 15:51dbazTriggers an Emergency Pack => No
2013-04-19 15:51dbazReview Assigned To => AugustoMauch
2013-04-19 15:51dbazIssue Monitored: AugustoMauch
2013-04-19 15:54dbazSummary"Copy record" toolbar button should only be executeble when the record is not being edited => "Copy record" toolbar button should only be executable when the record is not being edited
2013-04-19 15:55hgbotCheckin
2013-04-19 15:55hgbotNote Added: 0058059
2013-04-19 15:55hgbotStatusnew => resolved
2013-04-19 15:55hgbotResolutionopen => fixed
2013-04-19 15:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1b9a1df0a8916b29b05d258fd701661d375bbf48 [^]
2013-04-22 16:36hudsonbotCheckin
2013-04-22 16:36hudsonbotNote Added: 0058103
2013-04-23 16:49AugustoMauchNote Added: 0058139
2013-04-23 16:49AugustoMauchStatusresolved => closed
2013-04-23 16:49AugustoMauchFixed in Version => 3.0MP23

Notes
(0058059)
hgbot   
2013-04-19 15:55   
Repository: erp/devel/pi
Changeset: 1b9a1df0a8916b29b05d258fd701661d375bbf48
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Apr 19 15:55:25 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1b9a1df0a8916b29b05d258fd701661d375bbf48 [^]

Fixed issue 23595: 'Copy record' toolbar button now only is
available when the record has not been edited

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0058103)
hudsonbot   
2013-04-22 16:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f78aa78542fa [^]

Maturity status: Test
(0058139)
AugustoMauch   
2013-04-23 16:49   
Code reviewed and verified in pi@d4a9088f6a09