Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023591Openbravo ERP09. Financial managementpublic2013-04-19 14:092013-04-22 16:36
Reporterdmiguelez 
Assigned Todmiguelez 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0023591: In AdvPaymentMngtDao.java in executePayments(Invoice) Method,if the Invoice has no PaymentSchedule return a null List of Payment
DescriptionIn AdvPaymentMngtDao.java in executePayments(Invoice) Method,if the Invoice has no PaymentSchedule return a null List of Payments instead of querying through all the PaymentScheduleDetails without filters. It creates performances Issues.
Steps To ReproduceGo to Sales Invoice Window
Create a new Sales Invoice Header.
Complete the Invoice without Lines.
If Issue 23583 is not fixed it will enter the code with an Invoice without a PaymentSchedule.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0023583 closed dmiguelez When the c_invoice_post the processinvoice.java should stop the execution and return inmeidatly the error 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-04-19 14:09dmiguelezNew Issue
2013-04-19 14:09dmiguelezAssigned To => dmiguelez
2013-04-19 14:09dmiguelezModules => Core
2013-04-19 14:09dmiguelezTriggers an Emergency Pack => No
2013-04-19 14:09dmiguelezRelationship addedrelated to 0023583
2013-04-19 14:11hgbotCheckin
2013-04-19 14:11hgbotNote Added: 0058058
2013-04-19 14:11hgbotStatusnew => resolved
2013-04-19 14:11hgbotResolutionopen => fixed
2013-04-19 14:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3f93afd1a9f2b45bf13f0aa1a90a2457a3cafe53 [^]
2013-04-22 15:53SandrahuguetReview Assigned To => Sandrahuguet
2013-04-22 15:53SandrahuguetNote Added: 0058097
2013-04-22 15:53SandrahuguetStatusresolved => closed
2013-04-22 16:36hudsonbotCheckin
2013-04-22 16:36hudsonbotNote Added: 0058102

Notes
(0058058)
hgbot   
2013-04-19 14:11   
Repository: erp/devel/pi
Changeset: 3f93afd1a9f2b45bf13f0aa1a90a2457a3cafe53
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Apr 19 14:11:18 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3f93afd1a9f2b45bf13f0aa1a90a2457a3cafe53 [^]

Fixes Issue 23591: It prevents from querying a large list
without any filters.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
---
(0058097)
Sandrahuguet   
2013-04-22 15:53   
Code review + testing OK
(0058102)
hudsonbot   
2013-04-22 16:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f78aa78542fa [^]

Maturity status: Test