Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023583Openbravo ERP07. Sales managementpublic2013-04-18 18:012013-04-22 16:36
Reporteregoitz 
Assigned Todmiguelez 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0023583: When the c_invoice_post the processinvoice.java should stop the execution and return inmeidatly the error
DescriptionWhen the c_invoice_post the processinvoice.java should stop the execution and return inmeidatly the error.
Right now if the process fails the processinvoice continue working causing a severe performance problem when there are a lot of rows on the FIN_Payment_ScheduleDetail table
Steps To Reproduce-On an environment with 80.000 lines on FIN_Payment_ScheduleDetail table
-Create an invoice without lines.
-Complete it
-The c_invoice_post fails but the process continue
-Then the executePayment method of the ProcessInvoice.java clases is called causing a high cpu consumption during a long time
Proposed Solution-Exit from the java class when the c_invoice_post process fails.
Additional Information
TagsPerformance
Relationships
related to defect 0023591 closed dmiguelez In AdvPaymentMngtDao.java in executePayments(Invoice) Method,if the Invoice has no PaymentSchedule return a null List of Payment 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-04-18 18:01egoitzNew Issue
2013-04-18 18:01egoitzAssigned To => dmiguelez
2013-04-18 18:01egoitzModules => Core
2013-04-18 18:01egoitzOBNetwork customer => Yes
2013-04-18 18:01egoitzTriggers an Emergency Pack => No
2013-04-18 18:01egoitzTag Attached: Performance
2013-04-19 14:09dmiguelezRelationship addedrelated to 0023591
2013-04-19 14:11hgbotCheckin
2013-04-19 14:11hgbotNote Added: 0058057
2013-04-19 14:11hgbotStatusnew => resolved
2013-04-19 14:11hgbotResolutionopen => fixed
2013-04-19 14:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ca3b550183cbc9c2b3744571ed2c746088e68599 [^]
2013-04-22 16:03SandrahuguetReview Assigned To => Sandrahuguet
2013-04-22 16:03SandrahuguetNote Added: 0058098
2013-04-22 16:03SandrahuguetStatusresolved => closed
2013-04-22 16:36hudsonbotCheckin
2013-04-22 16:36hudsonbotNote Added: 0058101

Notes
(0058057)
hgbot   
2013-04-19 14:11   
Repository: erp/devel/pi
Changeset: ca3b550183cbc9c2b3744571ed2c746088e68599
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Apr 19 14:10:40 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ca3b550183cbc9c2b3744571ed2c746088e68599 [^]

Fixes Issue 23583. When the C_Invoice_Post Process fails,
it returns an error message without doing more actions.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
---
(0058098)
Sandrahuguet   
2013-04-22 16:03   
Code review + testing OK
(0058101)
hudsonbot   
2013-04-22 16:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f78aa78542fa [^]

Maturity status: Test