0023486: Discount Buy X pay Y of different product - Apply to lowest price - No distribute - is not working fine in ERP.

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0023486

Retail Modules

Discounts and Promotions

public

2013-04-04 09:02

2014-03-05 15:25

Reporter

guilleaer

Assigned To

guilleaer

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR14Q2

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0023486: Discount Buy X pay Y of different product - Apply to lowest price - No distribute - is not working fine in ERP.

Description

Discount Buy X pay Y of different product - Apply to lowest price - No distribute - is not working fine in ERP.

Steps To Reproduce

Create a discount of type Buy X pay Y of different product.

Prom:
Included prod: Only those defined
X Units: 3
X Units: 2
Discount subtype: Apply to lowest price
Distribute between lines -> Unmarked

Prods:
- A: Bootle 1L (price 9.5)
- B: Camel bak 3 L (price 35.5)

Using web POS (correct):
1. login in pos
2. add two units of product a (cheaper) to the order
3. add one unit of product b to the order

Result (working fine):
A discount is applied to product A (cheaper) because we will pay 2 units instead of 3, and the discount should apply to the cheapest one.

Using ERP
1. create a sales order for the same organization and customer of the previous one
2. Create a sales order line for product A (cheaper) with qty 2.
3. Create a sales order line for product B with qty 1.
4. Book the order

RESULT:
No discounts are applied.

Proposed Solution

Researching in this PL "obdisc_xy_different_product"

I've realized that the affected lines are selected fine, but when the discount is going to be applied this piece of code is executed

            if (v_checkedQty < v_nextY) then
                -- This line participates in the discount, but has not any discount applied,
                -- prevent to apply another discount in cascade
                CLOSE cur_line_candidates;
                RETURN 'N';
            end if;

If the first line analyzed (second line of the order) has less qty than X (1 < 3) we are giving up and the discount is not applied

Additional Information