Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0023474 | Openbravo ERP | A. Platform | public | 2013-04-02 13:50 | 2013-04-30 12:29 |
|
| Reporter | AugustoMauch | |
| Assigned To | AugustoMauch | |
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0MP23 | |
| Merge Request Status | |
| Review Assigned To | shankarb |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0023474: Selectors can not resolve the ID of a record if its identifier contains a carriage return |
| Description | If the identifier of a register in a selector contains a carriage return, the selector will not be able to retrieve its identifier. This means that even though the register will be shown properly, it shall not be saved, because the selector will not be able to provide its id. |
| Steps To Reproduce | As System Admin:
- Open Tables and Columns
- Select the ADModule table
- Check the Use as Record Identifier flag of the Author column.
- Create a new Selector Reference that points the ADModule table
- Create a new column in the database and a new Column and Field in the Application Dictionary.
- Associate the new Column with the new Reference.
- Use the new selector
- Check that is a module has a carriage return in the Author field, it will not be posible to save a record where that register is selected in the selector |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  issue23474.diff (1,084) 2013-04-04 10:46
https://issues.openbravo.com/file_download.php?file_id=6066&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2013-04-02 13:50 | AugustoMauch | New Issue | |
| 2013-04-02 13:50 | AugustoMauch | Assigned To | => AugustoMauch |
| 2013-04-02 13:50 | AugustoMauch | Modules | => Core |
| 2013-04-02 13:50 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2013-04-04 10:46 | AugustoMauch | File Added: issue23474.diff | |
| 2013-04-04 10:46 | AugustoMauch | Status | new => scheduled |
| 2013-04-04 10:46 | AugustoMauch | fix_in_branch | => pi |
| 2013-04-09 16:20 | hgbot | Checkin | |
| 2013-04-09 16:20 | hgbot | Note Added: 0057810 | |
| 2013-04-09 16:20 | hgbot | Status | scheduled => resolved |
| 2013-04-09 16:20 | hgbot | Resolution | open => fixed |
| 2013-04-09 16:20 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/40e52e08c85c502197dbf6f9c1aa0cc31ff3ae1e [^] |
| 2013-04-15 14:43 | alostale | Review Assigned To | => shankarb |
| 2013-04-16 19:18 | hudsonbot | Checkin | |
| 2013-04-16 19:18 | hudsonbot | Note Added: 0057945 | |
| 2013-04-30 12:29 | shankarb | Note Added: 0058347 | |
| 2013-04-30 12:29 | shankarb | Status | resolved => closed |
| 2013-04-30 12:29 | shankarb | Fixed in Version | => 3.0MP23 |
|
Notes |
|
|
(0057810)
|
|
hgbot
|
|
2013-04-09 16:20
|
|
Repository: erp/devel/pi
Changeset: 40e52e08c85c502197dbf6f9c1aa0cc31ff3ae1e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Apr 09 16:17:49 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/40e52e08c85c502197dbf6f9c1aa0cc31ff3ae1e [^]
Fixes bug 23474: Selectors work with identifiers that contains carriage return
Before this fix, if the identifier of a record provided by a selector contained a carriage return, the selector was not able to obtain the record id using its identifier. This happened
because the identifier was stored in the valuemap with its carriage returns, but then the identifier passed to retrieve the record ID did not contain the carriage return, so there was n
o match.
This has been fixed by removing the carriage returns before storing the identifiers in the value map.
---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
|
|
|
|
|
|
|
|
(0058347)
|
|
shankarb
|
|
2013-04-30 12:29
|
|
|
Code reviewed and tested in pi changeset 5521f678e840. |
|