Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0023431 | Openbravo ERP | A. Platform | public | 2013-03-28 17:31 | 2013-04-16 19:18 |
|
| Reporter | jecharri | |
| Assigned To | AugustoMauch | |
| Priority | immediate | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | 3.0MP23 | Fixed in Version | 3.0MP23 | |
| Merge Request Status | |
| Review Assigned To | shankarb |
| OBNetwork customer | |
| Web browser | Google Chrome |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0023431: Problems when you send two invoices by email at the same time |
| Description | Problems when you send two invoices by email at the same time |
| Steps To Reproduce | Configure the client to send emails.
-Open two browser with window "sales invoice" opened
-select one in one browser an another in other browser.
-after that push in sent email icon in both browsers at the same time.
-You will see that 1 popup open in the browser with email information
-send both emails.
-verify that the email is sent to both partners but in both cases is the same content or data and invoice. |
| Proposed Solution | the problem is in the variable
private PocData[] pocData; class PrintController
When you open the popup this variable contains the last information and when you send an email the application only read the information, so it is getting the last popup information |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  patchMultipleEmails.diff (4,778) 2013-04-03 15:35
https://issues.openbravo.com/file_download.php?file_id=6061&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2013-03-28 17:31 | jecharri | New Issue | |
| 2013-03-28 17:31 | jecharri | Assigned To | => jonalegriaesarte |
| 2013-03-28 17:31 | jecharri | Web browser | => Google Chrome |
| 2013-03-28 17:31 | jecharri | Modules | => Core |
| 2013-03-28 17:31 | jecharri | Triggers an Emergency Pack | => No |
| 2013-04-02 12:54 | jecharri | Web browser | Google Chrome => Google Chrome |
| 2013-04-02 12:54 | jecharri | Assigned To | jonalegriaesarte => AugustoMauch |
| 2013-04-02 12:54 | jecharri | Category | 01. General setup => A. Platform |
| 2013-04-03 15:35 | AugustoMauch | File Added: patchMultipleEmails.diff | |
| 2013-04-03 15:35 | AugustoMauch | Note Added: 0057706 | |
| 2013-04-03 15:35 | AugustoMauch | Status | new => scheduled |
| 2013-04-03 15:35 | AugustoMauch | fix_in_branch | => pi |
| 2013-04-09 16:38 | AugustoMauch | Issue Monitored: shankarb | |
| 2013-04-09 16:38 | AugustoMauch | Review Assigned To | => shankarb |
| 2013-04-09 16:38 | AugustoMauch | Web browser | Google Chrome => Google Chrome |
| 2013-04-09 16:38 | AugustoMauch | fix_in_branch | pi => |
| 2013-04-09 16:41 | hgbot | Checkin | |
| 2013-04-09 16:41 | hgbot | Note Added: 0057812 | |
| 2013-04-09 16:41 | hgbot | Status | scheduled => resolved |
| 2013-04-09 16:41 | hgbot | Resolution | open => fixed |
| 2013-04-09 16:41 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/6b34ef9b837f51eb4a027baa31f198f6aa9e95a4 [^] |
| 2013-04-14 15:19 | shankarb | Note Added: 0057878 | |
| 2013-04-14 15:19 | shankarb | Status | resolved => closed |
| 2013-04-14 15:19 | shankarb | Fixed in Version | => 3.0MP23 |
| 2013-04-16 19:18 | hudsonbot | Checkin | |
| 2013-04-16 19:18 | hudsonbot | Note Added: 0057947 | |
|
Notes |
|
|
|
|
A patch for this issue has been attached. |
|
|
|
(0057812)
|
|
hgbot
|
|
2013-04-09 16:41
|
|
Repository: erp/devel/pi
Changeset: 6b34ef9b837f51eb4a027baa31f198f6aa9e95a4
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Apr 09 16:38:21 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6b34ef9b837f51eb4a027baa31f198f6aa9e95a4 [^]
Fixes issue 23431: It is possible to send several emails at the same time
The pocData attribute of the PrintController class stores the email attachments. The problem was that this property was global and shared among all threads, so it was not possible to send several emails at the same time, because in that case the attachment sent in the concurrent emails was the one generated the last time the Send Email button was pushed.
This has been fixed by storing the pocData of each email as a session attribute, using as a key the document number and the table name. This way pocData is no longer shared among threads, each thread has its own instance of pocData stored as a session attribute. Once the email is sent, the pocData is removed from the session.
---
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
|
|
|
|
(0057878)
|
|
shankarb
|
|
2013-04-14 15:19
|
|
|
Code reviewed and tested in pi changest af8bd60362ce |
|
|
|
|
|