Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023316Openbravo ERPA. Platformpublic2013-03-15 12:292013-03-20 10:52
Reporterngarcia 
Assigned ToAugustoMauch 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP22Fixed in Version3.0MP22 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0023316: Labels with spaces at the beginning or at the end of the text are not translated
DescriptionLabels with spaces at the beginning or at the end of the text are not translated. The associated text interface is created without spaces
Steps To ReproduceAs system admin role:
   Install the Spanish Localization Pack for example
As group admin role:
   Change the language to Spanish
   Open the "Balance de sumas y saldos" and check that Primary Filters, Dimensions and View Results are not translated. Those texts have spaces at the end of the text.
   Launch it and print it
   Check that the title is not translated
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-03-15 12:29ngarciaNew Issue
2013-03-15 12:29ngarciaAssigned To => AugustoMauch
2013-03-15 12:29ngarciaModules => Core
2013-03-15 12:29ngarciaResolution time => 1366149600
2013-03-15 12:29ngarciaTriggers an Emergency Pack => No
2013-03-15 12:31ngarciaIssue Monitored: networkb
2013-03-18 10:38AugustoMauchSummaryLabels with spaces are not translated => Labels with spaces at the beginning or at the end of the text are not translated
2013-03-18 10:38AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=4508#r4508
2013-03-18 10:38AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=4510#r4510
2013-03-18 15:37AugustoMauchIssue Monitored: shankarb
2013-03-18 15:37AugustoMauchReview Assigned To => shankarb
2013-03-18 15:38hgbotCheckin
2013-03-18 15:38hgbotNote Added: 0057300
2013-03-18 15:38hgbotStatusnew => resolved
2013-03-18 15:38hgbotResolutionopen => fixed
2013-03-18 15:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/adb22f794a35aa9da0554617c6f3d2217210c2a4 [^]
2013-03-20 10:52shankarbNote Added: 0057323
2013-03-20 10:52shankarbStatusresolved => closed
2013-03-20 10:52shankarbFixed in Version => 3.0MP22

Notes
(0057300)
hgbot   
2013-03-18 15:38   
Repository: erp/devel/pi
Changeset: adb22f794a35aa9da0554617c6f3d2217210c2a4
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Mar 18 15:36:18 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/adb22f794a35aa9da0554617c6f3d2217210c2a4 [^]

Fixes issue 23316: Labels are properly trimmed before being translated

There were some missing trim() calls when trying to fetch translated texts based on the original text. Apart from that, non blocking spaces were not being cleared in the XmlVectorValue.printStringBuffer method, so its correpondent translation was not fetched. This has been fixed by replacing at that point the non blocking spaces with standard spaces before trimming the text.

---
M src-core/src/org/openbravo/uiTranslation/TranslationHandler.java
M src-core/src/org/openbravo/xmlEngine/DataValue.java
M src-core/src/org/openbravo/xmlEngine/XmlDocument.java
M src-core/src/org/openbravo/xmlEngine/XmlVectorValue.java
R legal/smartsprites.license.txt
R lib/build/commons-math-1.2.jar
R lib/build/google-collections.jar
R lib/build/smartsprites-0.2.1-alpha.jar
---
(0057323)
shankarb   
2013-03-20 10:52   
Code reviewed and tested in pi changeset 6cfd12f52b4f