Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0023294 | Openbravo ERP | A. Platform | public | 2013-03-13 13:47 | 2013-04-16 19:18 |
|
| Reporter | dmiguelez | |
| Assigned To | AugustoMauch | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 20 | OS Version | Community Appliance |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0MP23 | |
| Merge Request Status | |
| Review Assigned To | shankarb |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0023294: Set Message Text when returning from Parameter Windows. |
| Description | Set Message Text when returning from Parameter Windows. |
| Steps To Reproduce | In OBParameterWindowView.addProperties.handleResponse, add the message.title |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  issue23294.export (2,036) 2013-04-04 13:51
https://issues.openbravo.com/file_download.php?file_id=6069&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2013-03-13 13:47 | dmiguelez | New Issue | |
| 2013-03-13 13:47 | dmiguelez | Assigned To | => AugustoMauch |
| 2013-03-13 13:47 | dmiguelez | Modules | => Core |
| 2013-03-13 13:47 | dmiguelez | Triggers an Emergency Pack | => No |
| 2013-04-04 13:51 | AugustoMauch | File Added: issue23294.export | |
| 2013-04-04 13:56 | AugustoMauch | Status | new => scheduled |
| 2013-04-04 13:56 | AugustoMauch | fix_in_branch | => pi |
| 2013-04-09 16:00 | AugustoMauch | Issue Monitored: shankarb | |
| 2013-04-09 16:00 | AugustoMauch | Review Assigned To | => shankarb |
| 2013-04-09 16:00 | AugustoMauch | fix_in_branch | pi => |
| 2013-04-09 16:01 | hgbot | Checkin | |
| 2013-04-09 16:01 | hgbot | Note Added: 0057809 | |
| 2013-04-09 16:01 | hgbot | Status | scheduled => resolved |
| 2013-04-09 16:01 | hgbot | Resolution | open => fixed |
| 2013-04-09 16:01 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/1644bef3264bdd41ff351a8a1ad1ecf7e0510c23 [^] |
| 2013-04-10 17:23 | hgbot | Checkin | |
| 2013-04-10 17:23 | hgbot | Note Added: 0057834 | |
| 2013-04-14 15:17 | shankarb | Note Added: 0057875 | |
| 2013-04-14 15:17 | shankarb | Status | resolved => closed |
| 2013-04-14 15:17 | shankarb | Fixed in Version | => 3.0MP23 |
| 2013-04-16 19:18 | hudsonbot | Checkin | |
| 2013-04-16 19:18 | hudsonbot | Note Added: 0057944 | |
| 2013-04-16 19:18 | hudsonbot | Checkin | |
| 2013-04-16 19:18 | hudsonbot | Note Added: 0057960 | |
|
Notes |
|
|
(0057809)
|
|
hgbot
|
|
2013-04-09 16:01
|
|
Repository: erp/devel/pi
Changeset: 1644bef3264bdd41ff351a8a1ad1ecf7e0510c23
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Apr 04 13:51:18 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1644bef3264bdd41ff351a8a1ad1ecf7e0510c23 [^]
Fixes issue 23294: Parameter windows show messages with title and text
The function handleResponse was not showing the messages properly. At that point, the severity and the message text are available, and the message was being displayed like this:
messageBar.setMessage(message.severity, message.text). The first argument of the function is the severity, the second the message title and the third one (not used here), the message text. The way it was being called, the message text was shown in the message bar title.
To fix this problem, the function is now used like this:
messageBar.setMessage(message.severity, null, message.text); This way, the message title is retrieved using the severity, and the message text is shown in its place.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
---
|
|
|
|
(0057834)
|
|
hgbot
|
|
2013-04-10 17:23
|
|
Repository: erp/devel/pi
Changeset: e20a1ba38e324f7f1ccf07f45c7253346c089699
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Apr 10 17:22:29 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e20a1ba38e324f7f1ccf07f45c7253346c089699 [^]
Related to issue 23294: Enables specifying both text and title for messages
The fix has been changed, so instead of using always a default title, it will only do it when no title is provided. Otherwise, it will use the provided title.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
---
|
|
|
|
(0057875)
|
|
shankarb
|
|
2013-04-14 15:17
|
|
|
Code reviewed and tested in pi changeset af8bd60362ce |
|
|
|
|
|
|
|
|
|