Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023267Openbravo ERPA. Platformpublic2013-03-08 12:202013-04-16 19:18
Reporteregoitz 
Assigned Toshankarb 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP20 
Target Version3.0MP22Fixed in Version3.0MP22 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0023267: Error with ComboTableData when refering to columns defined as new selector for table containing also identifiers as new selector
DescriptionError with ComboTableData when refering to columns defined as new selector for table containing also identifiers as new selector
Steps To Reproduce-Show the window Outgoing Shipment.
-Create a new table pr_series having the mandatory columnas and a name.
-Add on the m_product table a new column em_pr_series1
-Create a new selector for the pr_series showing the name of the table.
-Define the column em_pr_series1 to use the previous selector
-Check the name on pr_series table as identifier
-Check the em_pr_series1 column on the m_product table as identifier
-Check the m_product_id colmn on m_inoutline table as identifier
-Compile the application and restart tomcat
-Access to the Outgoing Shipment window.
-Add a header
-Add a line
*When addding a line an error is shown on the openbravo.log


 ERROR org.openbravo.erpCommon.utility.ComboTableData - Error of SQL in query: SELECT td0.M_InOutLine_ID AS ID, (COALESCE(TO_CHAR((CASE WHEN td_trl2.Name IS NULL THEN COALESCE(TO_CHAR(td1.Name),'') ELSE COALESCE(TO_CHAR(td_trl2.Name),'') END)),'') || ' - ' || COALESCE(TO_CHAR(COALESCE(TO_CHAR(td3.Serienueva),'')),'') || ' - ' || COALESCE(TO_CHAR(COALESCE(TO_CHAR(td4.Serienueva),'')),'') || ' - ' || COALESCE(TO_CHAR(COALESCE(TO_CHAR(td5.Serienueva),'')),'') || ' - ' || COALESCE(TO_CHAR(COALESCE(TO_CHAR(td6.Serienueva),'')),'') || ' - ' || COALESCE(TO_CHAR(COALESCE(TO_CHAR(td1.Description),'')),'')) AS NAME, '' AS DESCRIPTION
FROM M_InOutLine td0
left join M_Product td1 on td0.M_Product_ID = td1.M_Product_ID
AND td1.AD_Client_ID IN ('0','FF808181332173EE0133217A75ED0001')
AND td1.AD_Org_ID IN ('FF808181332173EE013321817E1E278A','0')
left join M_Product_Trl td_trl2 on td1.M_Product_ID = td_trl2.M_Product_ID AND td_trl2.AD_Language = ?
left join pr_series td3 on td1.EM_Pr_Serie1 = td3.EM_Pr_Serie1
AND td3.AD_Client_ID IN ('0','FF808181332173EE0133217A75ED0001')
AND td3.AD_Org_ID IN ('FF808181332173EE013321817E1E278A','0')
WHERE td0.AD_Client_ID IN ('0','FF808181332173EE0133217A75ED0001')
AND td0.AD_Org_ID IN ('FF808181332173EE013321817E1E278A','0')
AND (td0.isActive = 'Y' OR td0.M_InOutLine_ID = (?) )
ORDER BY 2, 2, 2, 2, 2, 2Exception:org.postgresql.util.PSQLException: ERROR: column td3.em_pr_serie1 does not exist
...
...
ERROR org.openbravo.base.exception.OBException - Error while computing combo data
java.lang.Exception: @CODE=0@ERROR: column td3.em_pr_serie1 does not exist
  Position: 920
        at org.openbravo.erpCommon.utility.ComboTableData.select(ComboTableData.java:1102)
        at org.openbravo.client.kernel.reference.UIDefinition.getValueInComboReference(UIDefinition.java:469)
        ...
        ...
        ...
        at java.lang.Thread.run(Thread.java:679)
 ERROR org.openbravo.client.application.window.FormInitializationComponent - Couldn't get data for column Canceled_Inoutline_ID
org.openbravo.base.exception.OBException: Error while computing combo data
        at org.openbravo.client.kernel.reference.UIDefinition.getValueInComboReference(UIDefinition.java:519)
        at org.openbravo.client.kernel.reference.FKComboUIDefinition.getFieldProperties(FKComboUIDefinition.java:100)
        ...
        ...
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00232683.0MP22 closed shankarb The ad_column_identifier does not work for a table wich identifiers are new selectors 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-03-08 12:20egoitzNew Issue
2013-03-08 12:20egoitzAssigned To => AugustoMauch
2013-03-08 12:20egoitzModules => Core
2013-03-08 12:20egoitzOBNetwork customer => Yes
2013-03-08 12:20egoitzTriggers an Emergency Pack => No
2013-03-08 12:33egoitzRelationship addedrelated to 0023268
2013-03-08 12:33egoitzIssue Monitored: networkb
2013-03-14 07:00shankarbStatusnew => scheduled
2013-03-14 07:00shankarbfix_in_branch => pi
2013-03-14 07:01shankarbAssigned ToAugustoMauch => shankarb
2013-03-14 07:08shankarbReview Assigned To => AugustoMauch
2013-03-14 07:08shankarbfix_in_branchpi =>
2013-03-14 07:08shankarbIssue Monitored: AugustoMauch
2013-03-14 07:10hgbotCheckin
2013-03-14 07:10hgbotNote Added: 0057238
2013-03-14 07:10hgbotStatusscheduled => resolved
2013-03-14 07:10hgbotResolutionopen => fixed
2013-03-14 07:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/17257f9051b3b426aff87dae8b59f1db0d1ce254 [^]
2013-03-14 09:36shankarbNote Added: 0057241
2013-03-14 19:01AugustoMauchNote Added: 0057266
2013-03-14 19:01AugustoMauchStatusresolved => new
2013-03-14 19:01AugustoMauchResolutionfixed => open
2013-03-17 06:56hgbotCheckin
2013-03-17 06:56hgbotNote Added: 0057276
2013-03-17 06:56hgbotStatusnew => resolved
2013-03-17 06:56hgbotResolutionopen => fixed
2013-03-17 06:56hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/17257f9051b3b426aff87dae8b59f1db0d1ce254 [^] => http://code.openbravo.com/erp/devel/pi/rev/9df38a6a44d05d70b347868e328cbf5a45596a19 [^]
2013-03-18 10:55AugustoMauchNote Added: 0057293
2013-03-18 10:55AugustoMauchStatusresolved => closed
2013-03-18 10:55AugustoMauchFixed in Version => 3.0MP22
2013-03-25 13:12hudsonbotCheckin
2013-03-25 13:12hudsonbotNote Added: 0057416
2013-04-10 04:06hgbotCheckin
2013-04-10 04:06hgbotNote Added: 0057814
2013-04-16 19:18hudsonbotCheckin
2013-04-16 19:18hudsonbotNote Added: 0057949

Notes
(0057238)
hgbot   
2013-03-14 07:10   
Repository: erp/devel/pi
Changeset: 17257f9051b3b426aff87dae8b59f1db0d1ce254
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Mar 14 11:37:35 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/17257f9051b3b426aff87dae8b59f1db0d1ce254 [^]

Fixes Issue 0023267: Error using fields with selectors as identifier

When an external module field that uses a selector is set as identifier, ComboTableData errors out.
The comparison was done with the external module field 'EM_DBPREFIX_FIELDNAME' in the base table where the field name was FIELDNAME.
Modified code to fetch the column name from Selector definition in case of an external module field.

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/reference/SelectorUIReference.java
---
(0057241)
shankarb   
2013-03-14 09:36   
Can use the module attached in issue https://issues.openbravo.com/view.php?id=23268 [^] for testing.
(0057266)
AugustoMauch   
2013-03-14 19:01   
All external module identifier column names start with "EM_". The new change applies to all columns that CONTAINS "EM_", so it could be applied to columns that do not belong to external modules. Replaces name.contains with name.startsWith.
(0057276)
hgbot   
2013-03-17 06:56   
Repository: erp/devel/pi
Changeset: 9df38a6a44d05d70b347868e328cbf5a45596a19
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Sun Mar 17 11:25:44 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/9df38a6a44d05d70b347868e328cbf5a45596a19 [^]

Fixes Issue 0023267 : Apply code review changes

Modified contains method to startswith to aviod issues with all columns containing EM_.

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/reference/SelectorUIReference.java
---
(0057293)
AugustoMauch   
2013-03-18 10:55   
Code reviewed and verified in pi@73b8312f9699
(0057416)
hudsonbot   
2013-03-25 13:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/88ae0db922b5 [^]

Maturity status: Test
(0057814)
hgbot   
2013-04-10 04:06   
Repository: erp/devel/pi
Changeset: 84a2a4d680e136f831073ff42e8f9848cb0394c3
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Apr 10 07:32:00 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/84a2a4d680e136f831073ff42e8f9848cb0394c3 [^]

Fixes Issue 23124, Related to Issue 23267 : Selectors as Identifiers

When comparing selector columns in ComboData the column name in the table was used to compare with the selector table. This results in exception when the column names are different.
In case the selector has the column field, that column is used for comparison avoiding this error.

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/reference/SelectorUIReference.java
---
(0057949)
hudsonbot   
2013-04-16 19:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8df08bea850d [^]

Maturity status: Test