Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023220Openbravo ERPA. Platformpublic2013-03-04 18:112013-03-06 19:42
Reporterngarcia 
Assigned ToAugustoMauch 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP21Fixed in Version3.0MP21 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelCoding ( Testing )
Regression date2013-02-15
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/57378b7ff2bd78d52d69b051cd7683e540e47f87 [^]
Triggers an Emergency PackNo
Summary0023220: When calculating the display logic null values are not converted to ''
DescriptionWhen calculating the display logic null values are not converted to ''
Steps To ReproduceAs group admin role:
   Go to financial account and change the Type from Bank to Cash
   Check that the Import Statement and Match Statement buttons are replaced with the Reconcile button
   Now change the type to Bank again and delete the Matching Algorithm field value
   The buttons are not replaced this time
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00230683.0MP21 closed AugustoMauch Sorting by computed column is lost after saving a record with errors 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-03-04 18:11ngarciaNew Issue
2013-03-04 18:11ngarciaAssigned To => AugustoMauch
2013-03-04 18:11ngarciaModules => Core
2013-03-04 18:11ngarciaTriggers an Emergency Pack => No
2013-03-04 18:11ngarciaIssue Monitored: networkb
2013-03-04 18:12ngarciaRegression level => Pre packaging ( pi )
2013-03-05 10:18AugustoMauchRegression levelPre packaging ( pi ) => Coding ( Testing )
2013-03-05 10:18AugustoMauchRegression date => 2013-02-15
2013-03-05 10:18AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/57378b7ff2bd78d52d69b051cd7683e540e47f87 [^]
2013-03-05 10:18AugustoMauchIssue Monitored: shankarb
2013-03-05 10:21AugustoMauchReview Assigned To => shankarb
2013-03-05 10:22AugustoMauchRelationship addedrelated to 0023068
2013-03-05 10:25hgbotCheckin
2013-03-05 10:25hgbotNote Added: 0057034
2013-03-05 10:25hgbotStatusnew => resolved
2013-03-05 10:25hgbotResolutionopen => fixed
2013-03-05 10:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9fa4494e366cb04c8fcee0c6e31ba2186cd0bb6c [^]
2013-03-05 13:11shankarbNote Added: 0057046
2013-03-05 13:11shankarbStatusresolved => closed
2013-03-05 13:11shankarbFixed in Version => 3.0MP21
2013-03-06 19:42hudsonbotCheckin
2013-03-06 19:42hudsonbotNote Added: 0057109

Notes
(0057034)
hgbot   
2013-03-05 10:25   
Repository: erp/devel/pi
Changeset: 9fa4494e366cb04c8fcee0c6e31ba2186cd0bb6c
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 05 10:24:55 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9fa4494e366cb04c8fcee0c6e31ba2186cd0bb6c [^]

Fixes issue 23220: Display logic works as expected

In the fix of issue 23068 a change was done to prevent all properties of the form being changed from null to ''. This change had to be done on a clone of the record, not on the record itself.

The problem is that at one point the record itself was being used, being taken for granted that its null values would be replaced with an empty string. This has been fixed by replacing the record by the clone that already has had its null values replaced by ''.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js
---
(0057046)
shankarb   
2013-03-05 13:11   
Code reviewed and verified in pi changeset a60624fb0f40
(0057109)
hudsonbot   
2013-03-06 19:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/95e36a1b246f [^]

Maturity status: Test