0023112: Trial Balance shows different Final Balance depending the check 'Opening Entry Amount to Initial Balance'

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0023112

Openbravo ERP

09. Financial management

public

2013-02-19 10:28

2013-04-04 13:16

Reporter

xabiermerino

Assigned To

jonalegriaesarte

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

no change required

Platform

OS Version

Product Version

3.0MP19.3

Target Version

3.0MP23

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0023112: Trial Balance shows different Final Balance depending the check 'Opening Entry Amount to Initial Balance'

Description

Trial Balance shows different Final Balance depending the check 'Opening Entry Amount to Initial Balance'.

Steps To Reproduce

In the database execute this query:
update fact_acct set factaccttype = 'N' where acctvalue like '%57200%' and factaccttype = 'O'

As admin execute the report with the field checked, the result is correct.
Execute the report with the field unchecked, the result is wrong

Proposed Solution

ReportTrialBalance.java

Method calculateTree:

Change:

        // Set calculated Initial Balances
        for (int k = 0; k < dataIB.length; k++) {
          if (dataIB[k].accountId.equals(data[i].id)) {
            if (strNotInitialBalance.equals("Y")) {
              data[i].saldoInicial = (new BigDecimal(dataIB[k].saldoInicial).add(parcialInicial))
                  .toPlainString();
            } else {
              data[i].amtacctdr = (new BigDecimal(dataIB[k].amtacctdr).add(parcialDR))
                  .toPlainString();
              data[i].amtacctcr = (new BigDecimal(dataIB[k].amtacctcr).add(parcialCR))
                  .toPlainString();
            }
            data[i].saldoFinal = (new BigDecimal(dataIB[k].saldoInicial).add(parcialDR)
                .subtract(parcialCR)).toPlainString();
          }
        }

for:

        // Set calculated Initial Balances
        for (int k = 0; k < dataIB.length; k++) {
          if (dataIB[k].accountId.equals(data[i].id)) {
            if (strNotInitialBalance.equals("Y")) {
              data[i].saldoInicial = (new BigDecimal(dataIB[k].saldoInicial).add(parcialInicial))
                  .toPlainString();
            } else {
              data[i].amtacctdr = (new BigDecimal(dataIB[k].amtacctdr).add(parcialDR).add(new BigDecimal(data[i].amtacctdr)))
                  .toPlainString();
              data[i].amtacctcr = (new BigDecimal(dataIB[k].amtacctcr).add(parcialCR).add(new BigDecimal(data[i].amtacctcr)))
                  .toPlainString();
            }
            data[i].saldoFinal = (new BigDecimal(dataIB[k].saldoInicial).add(parcialDR)
                .subtract(parcialCR)).toPlainString();
          }
        }

Additional Information