Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023087Openbravo ERP09. Financial managementpublic2013-02-15 13:372013-03-02 05:48
Reportermirurita 
Assigned Topramakrishnan 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0023087: Doubtful Debt Run pick and edit not working properly with comma configured as decimal separator
DescriptionDoubtful Debt Run pick and edit not working properly with comma configured as decimal separator
Steps To Reproduce1) Go to Doubtful Debt Run window
2) Create a new record (leave fields with default value)
3) Click on "Select Doubtful Debt" button
4) Select any row with decimals in Outstanding Amount
5) Realize that proposed amount is wrong.
6) See attached screenshot
Proposed Solutionsee attached patch.

Considerations:
1) The resulting number must be cast to Number. done in the patch.
2) The division must be rounded (done in the patch)
3) The division must be rounded to the standard precision of the currency of the selected invoice. pending to be done.

In the attached patch it is using an static precision (2).
If you do not round the amount stored in database will contain a lot of decimals although you only see 2 in the grid (this is because the format defined in Format.xml is being applied).
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screenshot from 2013-02-15 13:36:48.png (51,590) 2013-02-15 13:37
https://issues.openbravo.com/file_download.php?file_id=5987&type=bug
png

diff partial_proposed_solution.diff (1,128) 2013-02-18 11:29
https://issues.openbravo.com/file_download.php?file_id=5991&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-02-15 13:37miruritaNew Issue
2013-02-15 13:37miruritaAssigned To => mirurita
2013-02-15 13:37miruritaFile Added: Screenshot from 2013-02-15 13:36:48.png
2013-02-15 13:37miruritaModules => Core
2013-02-15 13:37miruritaTriggers an Emergency Pack => No
2013-02-15 13:55miruritaAssigned Tomirurita => dmiguelez
2013-02-15 13:56miruritaFile Added: partial_proposed_solution.patch
2013-02-15 14:00miruritaProposed Solution updated
2013-02-18 11:28miruritaFile Deleted: partial_proposed_solution.patch
2013-02-18 11:29miruritaFile Added: partial_proposed_solution.diff
2013-02-20 13:05pramakrishnanAssigned Todmiguelez => pramakrishnan
2013-02-20 13:05pramakrishnanStatusnew => scheduled
2013-02-20 13:05pramakrishnanfix_in_branch => pi
2013-02-21 14:44pramakrishnanNote Added: 0056683
2013-02-26 16:34hgbotCheckin
2013-02-26 16:34hgbotNote Added: 0056780
2013-02-26 16:34hgbotStatusscheduled => resolved
2013-02-26 16:34hgbotResolutionopen => fixed
2013-02-26 16:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a4b042d99920a73f540477b470b652fbb42a1794 [^]
2013-02-26 16:34hgbotCheckin
2013-02-26 16:34hgbotNote Added: 0056781
2013-02-26 16:37SandrahuguetReview Assigned To => Sandrahuguet
2013-02-26 16:37SandrahuguetNote Added: 0056782
2013-02-26 16:37SandrahuguetStatusresolved => closed
2013-03-02 05:48hudsonbotCheckin
2013-03-02 05:48hudsonbotNote Added: 0056916
2013-03-02 05:48hudsonbotCheckin
2013-03-02 05:48hudsonbotNote Added: 0056917

Notes
(0056683)
pramakrishnan   
2013-02-21 14:44   
Test Plan:
1) Configure the decimal separator as comma in Format.xml
2) Go to Doubtful Debt Run window
3) Create a new record (leave fields with default value)
4) Click on "Select Doubtful Debt" button
5) Select any row with decimals in Outstanding Amount
6) Realize that the doubtful debt amount is proposed correctly
(0056780)
hgbot   
2013-02-26 16:34   
Repository: erp/devel/pi
Changeset: a4b042d99920a73f540477b470b652fbb42a1794
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Thu Feb 21 19:08:52 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/a4b042d99920a73f540477b470b652fbb42a1794 [^]

Fixes Issue 23087: Doubtful Debt Run pick and edit not working properly

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/DoubtFulDebtPickEditLines.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-utilities.js
---
(0056781)
hgbot   
2013-02-26 16:34   
Repository: erp/devel/pi
Changeset: 7f5b39dd5784feb76908b242e756869be332fdec
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Feb 26 16:32:45 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7f5b39dd5784feb76908b242e756869be332fdec [^]

Related to issue 23087

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
---
(0056782)
Sandrahuguet   
2013-02-26 16:37   
Code review + testing OK
(0056916)
hudsonbot   
2013-03-02 05:48   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f5db629e7058 [^]

Maturity status: Test
(0056917)
hudsonbot   
2013-03-02 05:48   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f5db629e7058 [^]

Maturity status: Test