Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023082Openbravo ERPA. Platformpublic2013-02-14 18:272013-03-21 23:36
Reportervmromanos 
Assigned ToAugustoMauch 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionDebian 5.0
Product Versionpi 
Target Version3.0MP22Fixed in Version3.0MP22 
Merge Request Status
Review Assigned Todbaz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0023082: ANT compiling and module's libraries
DescriptionMy module uses some classes provided by an external library. This library is included into the Weld module (installed within the Openbravo 3 distribution).
The library is inside:
./modules/org.openbravo.base.weld/lib/runtime/google-collect-1.0.jar

When compiling my module using Eclipse, it's working fine. However, if I try to compile it using ant into a fresh environment (no compiled before using Eclipse), I get a compilation error.

As a workaround, I have copied the google-collect-1.0.jar to the core's lib/build folder. This is the only way I have managed to compile it using ant.

It looks like a problem getting the Classpath from ant.
Steps To ReproduceYou can try to reproduce it following the steps in the description, or directly installing the org.openbravo.authorize.net module (available at pmods)
Proposed Solution
Additional Information
TagsCoworking
Relationships
related to defect 0023344 closed AugustoMauch API Change - Remove Smart Sprites functionality 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-02-14 18:27vmromanosNew Issue
2013-02-14 18:27vmromanosAssigned To => AugustoMauch
2013-02-14 18:27vmromanosModules => Core
2013-02-14 18:27vmromanosTriggers an Emergency Pack => No
2013-02-14 18:27vmromanosTag Attached: Coworking
2013-02-21 00:30shuehnerNote Added: 0056656
2013-02-21 00:30shuehnerIssue Monitored: shuehner
2013-02-28 16:31AugustoMauchTarget Version3.0MP21 => 3.0MP22
2013-03-19 17:46AugustoMauchRelationship addedrelated to 0023344
2013-03-21 16:30AugustoMauchIssue Monitored: shankarb
2013-03-21 16:30AugustoMauchIssue End Monitor: shankarb
2013-03-21 16:30AugustoMauchIssue Monitored: dbaz
2013-03-21 16:30AugustoMauchReview Assigned To => dbaz
2013-03-21 16:31hgbotCheckin
2013-03-21 16:31hgbotNote Added: 0057368
2013-03-21 16:31hgbotStatusnew => resolved
2013-03-21 16:31hgbotResolutionopen => fixed
2013-03-21 16:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0c44af13571d32b065633a34848733387c9619e5 [^]
2013-03-21 16:32AugustoMauchNote Added: 0057369
2013-03-21 16:32AugustoMauchStatusresolved => new
2013-03-21 16:32AugustoMauchResolutionfixed => open
2013-03-21 17:18hgbotCheckin
2013-03-21 17:18hgbotNote Added: 0057373
2013-03-21 17:46hgbotCheckin
2013-03-21 17:46hgbotNote Added: 0057374
2013-03-21 17:46hgbotStatusnew => resolved
2013-03-21 17:46hgbotResolutionopen => fixed
2013-03-21 17:46hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/0c44af13571d32b065633a34848733387c9619e5 [^] => http://code.openbravo.com/erp/devel/pi/rev/11600ac7d1e4bac8d7963b2830b32ad12d05975a [^]
2013-03-21 17:55AugustoMauchNote Added: 0057376
2013-03-21 23:36dbazNote Added: 0057378
2013-03-21 23:36dbazStatusresolved => closed
2013-03-21 23:36dbazFixed in Version => 3.0MP22

Notes
(0056656)
shuehner   
2013-02-21 00:30   
Hi Victor,
the problem runs a bit deeper than it looks:

lib/build/google-collections.jar exists also together with the lib/runtime copy in org.openbravo.base.weld.

At compile time both are included and the system uses the first one found when it searches for a specific class file.

It looks to me that the lib/build copy is a bit older, so that it does contain the HashMultiMap.class file but in a version which does not have the create() method you are calling, so compilation fails.

As a workaround it is sufficient to do an rm lib/build/google-collections.jar without moving the other jar file and it will compile just fine.

Note: problem only exists at compile-time as the lib/build copy is not copied over to tomcat so at runtime no version conflict exists.

Several ways of fixing this:
a.) just remove lib/build/google-collections.jar + also move the base.weld/lib/runtime/jar over to lib/runtime of core
b.) think of removing the ond lib/build user (is think the css sprites code) alltogether as its useabilty/effectiveness is questionable. + then do a.) also.

Note: if we want to do a.) we need to check if the build-time user will work fine with the new google-collections library version.
(0057368)
hgbot   
2013-03-21 16:31   
Repository: erp/devel/pi
Changeset: 0c44af13571d32b065633a34848733387c9619e5
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Mar 21 16:30:17 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0c44af13571d32b065633a34848733387c9619e5 [^]

Fixes issue 23082: Removes smart sprites functionality

The root cause of the fix is that there two versions of the google collections library. The old one, located in lib/build/google-collections.jar was only used for the smart sprites functionality, that only applies to 2.50 windows and to the login window. This functionality does not work with the neweste version of the google collections library (modules/org.openbravo.base.weld/lib/runtime/google-collect-1.0.jar).

It has been decided that this feature is going to be removed. It has almost no significance in Openbravo 3.0, in fact it is disabled by default. Changes done:
- Removed now unused libraries:
   * lib/build/commons-math-1.2.jar
   * lib/build/google-collections.jar
   * lib/build/smartsprites-0.2.1-alpha.jar

- Removed functionality from src/build.xml

- Removed configuration option from Openbravo.properties.template

- Updated legal folder

---
M config/Openbravo.properties.template
M legal/Licensing.txt
M src/build.xml
---
(0057369)
AugustoMauch   
2013-03-21 16:32   
Reopened because part of the fix is missing. A clean up of the CSS must be done to get rid of the parts related to the sprites
(0057373)
hgbot   
2013-03-21 17:18   
Repository: erp/devel/pi
Changeset: 47d740ad4b2c3d628f71608b61abb3277a5db740
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Mar 21 17:17:27 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/47d740ad4b2c3d628f71608b61abb3277a5db740 [^]

Related to issue 23082: Removes references to sprites from RTLSkin

---
M src-trl/src/org/openbravo/translate/RTLSkin.java
---
(0057374)
hgbot   
2013-03-21 17:46   
Repository: erp/devel/pi
Changeset: 11600ac7d1e4bac8d7963b2830b32ad12d05975a
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Mar 21 17:45:39 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/11600ac7d1e4bac8d7963b2830b32ad12d05975a [^]

Fixes issue 23082: Removes SmartSprites comments from 2.50 CSS

---
M modules/org.openbravo.userinterface.skin.250to300Comp/web/org.openbravo.userinterface.skin.250to300Comp/skins/250to300Comp/Openbravo_ERP_250.css
M web/skins/Default/Openbravo_ERP_250.css
---
(0057376)
AugustoMauch   
2013-03-21 17:55   
Test plan:
- Test that the original issue is no longer reproducible
- Test that the layout of Openbravo RTL has not been modified.
(0057378)
dbaz   
2013-03-21 23:36   
Reviewed @ changeset: 19954 - 11600ac7d1e4