Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023045Openbravo ERPA. Platformpublic2013-02-12 10:362013-03-04 10:51
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP21Fixed in Version3.0MP21 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0023045: In parameter windows, date parameters generate parsing error in the tomcat log
DescriptionWhen a parameter window containing a date parameter is parsed, the tomcat log show the following error:

1472846 [http-8080-2] ERROR org.openbravo.client.kernel.ComponentGenerator - Error parsing component View
>>>>>>> Issues found in javascript <<<<<<<<<
Core.View:40:1: Duplicate 'width'. >> offending code: }
>>>>>>> Issues (219ms) <<<<<<<<<
Steps To Reproduce- Create a parameter window (http://wiki.openbravo.com/wiki/How_to_create_a_Standard_Process_Definition [^]) and add a date parameter.
- Open the parameter window, and check that there is an error in the tomcat log.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-02-12 10:36AugustoMauchNew Issue
2013-02-12 10:36AugustoMauchAssigned To => AugustoMauch
2013-02-12 10:36AugustoMauchModules => Core
2013-02-12 10:36AugustoMauchTriggers an Emergency Pack => No
2013-02-28 18:26AugustoMauchIssue Monitored: alostale
2013-02-28 18:26AugustoMauchReview Assigned To => alostale
2013-02-28 18:30hgbotCheckin
2013-02-28 18:30hgbotNote Added: 0056859
2013-02-28 18:30hgbotStatusnew => resolved
2013-02-28 18:30hgbotResolutionopen => fixed
2013-02-28 18:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b6d27173f383d80d507fc8ff64010c73a273b9cc [^]
2013-03-02 05:48hudsonbotCheckin
2013-03-02 05:48hudsonbotNote Added: 0056934
2013-03-04 10:51alostaleNote Added: 0056969
2013-03-04 10:51alostaleStatusresolved => closed
2013-03-04 10:51alostaleFixed in Version => 3.0MP21

Notes
(0056859)
hgbot   
2013-02-28 18:30   
Repository: erp/devel/pi
Changeset: b6d27173f383d80d507fc8ff64010c73a273b9cc
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Feb 28 18:29:30 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b6d27173f383d80d507fc8ff64010c73a273b9cc [^]

Fixes issue 23045: Date parameters do not generate tomcat error in PW windows

The way the width of the parameters is fetched has been refactored. Now it depends on the UIDefinition of the parameter. The default width is '*', and if a subclass of UIDefinition needs to return a different width, it must overwrite the new public String getParameterWidth(Parameter parameter) method. I.e., DateUIDefinition overwrites it like this:

  @Override
  public String getParameterWidth(Parameter parameter) {
    return "50%";
  }

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-param-window-parameter.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewParameterHandler.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/DateUIDefinition.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinition.java
---
(0056934)
hudsonbot   
2013-03-02 05:48   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f5db629e7058 [^]

Maturity status: Test
(0056969)
alostale   
2013-03-04 10:51   
Code reviewed and verified on pi@60243532caef