Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022960Openbravo ERP09. Financial managementpublic2013-02-03 19:152013-02-06 08:24
Reportermirurita 
Assigned Tomirurita 
PriorityhighSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Topramakrishnan
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022960: Ability to define amortization parameters in asset group and inherit them when creating an asset
DescriptionIt should be possible to define the following amortization parameters in asset group window.

All of them should be only visible if Depreciate flag is selected.

- Depreciation Type
  * Linear
- Calculate Type
  * Time
  * Percentage
- Annual Depreciation % (only visible if Percentage calculate type is selected)
- Amortize (only visible if Time calculate type is selected)
  * Monthly
  * Yearly
- Usable Life - Years (only visible if Yearly is selected)
- Usable Life - Months (only visible if Monthly is selected)

Those fields are only displayed in form view.

In Assets window when selecting the asset group the amortization configuration should be inherited from the group.
Steps To ReproduceTest Plan I
Do not apply this patch
1) Go to Asset Group window and create two asset groups
 - Name: Group1
 - Depreciate: No

 - Name: Group2
 - Depreciate: Yes
2) Apply the patch and compile
3) Go to Asset Group window
 - Name: Group1
 - Depreciate: No
The following fields are not visible but if the flag Depreciated is selected they should containg the following default values.
 - Depreciation Type: Linear
 - Calculate Type: Percentage
 - Annual Depreciation %
 - Amortize: Monthly
 - Usable Life - Months


 - Name: Group2
 - Depreciate: Yes
 - Depreciation Type: Linear
 - Calculate Type: Percentage
 - Annual Depreciation %
 - Amortize (not visible)
 - Usable Life - Years (not visible)
 - Usable Life - Months (not visible)

Test Plan II
1) Go to Asset Group window
2) Create a new Asset Group
3) Select Depreciate flag and new fields will appear:
 - Depreciation Type: Linear
 - Calculate Type: Percentage
 - Annual Depreciation %
4) Select Time calculate type
 - Depreciation Type: Linear
 - Calculate Type: Time
 - Amortize: Monthly
 - Usable Life - Months
5) Select Yearly amortization
 - Depreciation Type: Linear
 - Calculate Type: Time
 - Amortize: Yearly
 - Usable Life - Years
6) Unselect Depreceiate flag and previous fields will be hidden.

Test Plan III
1) Go to Asset Group window
2) Create 3 new Asset Groups
 - Name: My New Group1
 - Depreciate: Yes
 - Depreciation Type: Linear
 - Calculate Type: Percentage
 - Annual Depreciation %: 10

 - Name: My New Group2
 - Depreciate: Yes
 - Calculate Type: Time
 - Amortize: Monthly
 - Usable Life - Months: 12

 - Name: My New Group3
 - Depreciate: No

4) Go to Assets window
5) Create a new asset and select "My New Group1". Realize that the asset group configuration is inherited.
6) Create a new asset and select "My New Group2". Realize that the asset group configuration is inherited.
7) Create a new asset and select "My New Group3". Realize that the asset group configuration is inherited.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0022989 closed AugustoMauch Display Logic does not work properly always. 
Attached Filespng AssetGroup.png (28,823) 2013-02-03 19:21
https://issues.openbravo.com/file_download.php?file_id=5920&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2013-02-03 19:15miruritaNew Issue
2013-02-03 19:15miruritaAssigned To => dmiguelez
2013-02-03 19:15miruritaModules => Core
2013-02-03 19:15miruritaOBNetwork customer => No
2013-02-03 19:15miruritaTriggers an Emergency Pack => No
2013-02-03 19:16miruritaDescription Updatedbug_revision_view_page.php?rev_id=4346#r4346
2013-02-03 19:16miruritaAssigned Todmiguelez => mirurita
2013-02-03 19:21miruritaFile Added: AssetGroup.png
2013-02-03 19:24hgbotCheckin
2013-02-03 19:24hgbotNote Added: 0056112
2013-02-03 19:24hgbotStatusnew => resolved
2013-02-03 19:24hgbotResolutionopen => fixed
2013-02-03 19:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4fe8031ec24043fab134732eb9df8e20757680cb [^]
2013-02-03 20:43hgbotCheckin
2013-02-03 20:43hgbotNote Added: 0056113
2013-02-05 11:19miruritaNote Added: 0056150
2013-02-05 22:44hudsonbotCheckin
2013-02-05 22:44hudsonbotNote Added: 0056185
2013-02-05 22:44hudsonbotCheckin
2013-02-05 22:44hudsonbotNote Added: 0056186
2013-02-06 08:24pramakrishnanReview Assigned To => pramakrishnan
2013-02-06 08:24pramakrishnanNote Added: 0056197
2013-02-06 08:24pramakrishnanStatusresolved => closed
2013-02-06 12:21dmiguelezRelationship addedrelated to 0022989

Notes
(0056112)
hgbot   
2013-02-03 19:24   
Repository: erp/devel/pi
Changeset: 4fe8031ec24043fab134732eb9df8e20757680cb
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Sun Feb 03 19:24:14 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4fe8031ec24043fab134732eb9df8e20757680cb [^]

Fixes issue 22960: Ability to define amortization parameters in asset group

---
M src-db/database/model/tables/A_ASSET_GROUP.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/erpCommon/ad_callouts/SL_Depreciate.java
---
(0056113)
hgbot   
2013-02-03 20:43   
Repository: erp/devel/pi
Changeset: 1f5944baa2eed1fdd7bba5047f3fd86509e9c9cd
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Sun Feb 03 20:41:23 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1f5944baa2eed1fdd7bba5047f3fd86509e9c9cd [^]

Related to issue 22960: prevent API change, restore getDepreciatedFlag method

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Depreciate.java
---
(0056150)
mirurita   
2013-02-05 11:19   
Documentation updated
http://wiki.openbravo.com/wiki/Asset_Group [^]
(0056185)
hudsonbot   
2013-02-05 22:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/86db3ad54671 [^]

Maturity status: Test
(0056186)
hudsonbot   
2013-02-05 22:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/86db3ad54671 [^]

Maturity status: Test
(0056197)
pramakrishnan   
2013-02-06 08:24   
Code Review + Testing - OK