Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022926Openbravo ERPY. DBSourceManagerpublic2013-01-29 17:102013-02-05 22:44
Reporterneil_smith 
Assigned ToSandrahuguet 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP17.2 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toeduardo_Argal
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022926: Smartbuild hangs on database insert (InitializeAcctDimensionsInClient)
DescriptionOn my new installation, when I run an 'ant smartbuild -Dlocal=no' after a module installation, I get an error in org.openbravo.modulescript.InitializeAcctDimensionsInClient (moduleScript).
It is trying to insert all the document types in the database again and violates unique key constraint ad_client_acctdimension.ad_client_unique.

Now I can't build my app, totally stuck...

Thanks for your time


Here is the whole exception:

     [java] 114770 INFO - Executing moduleScript: org.openbravo.modulescript.InitializeAcctDimensionsInClient
     [java] 114784 ERROR - SQL error in query: INSERT INTO ad_client_acctdimension(ad_client_acctdimension_id, ad_client_id, ad_org_id, isactive, created, createdby, updated, updatedby, dimension, docbasetype, show_in_header, show_in_lines, show_in_breakdown)values (get_uuid(), ? , '0', 'Y', now(), '0', now(), '0', 'BP', 'ARI', 'Y', 'N', 'N')Exception:org.postgresql.util.PSQLException: ERROR: duplicate key value violates unique constraint "ad_client_unique"
     [java] Détail : Key (ad_client_id, dimension, docbasetype)=(398C673494BD4E5DB4B227C4FCA52580, BP, ARI) already exists.
     [java] 114907 ERROR - Error executing moduleScript org.openbravo.modulescript.InitializeAcctDimensionsInClient: @CODE=0@ERROR: duplicate key value violates unique constraint "ad_client_unique"
     [java] Détail : Key (ad_client_id, dimension, docbasetype)=(398C673494BD4E5DB4B227C4FCA52580, BP, ARI) already exists.
     [java] 114937 ERROR - Error executing moduleScript: org.openbravo.modulescript.InitializeAcctDimensionsInClient
     [java] Execution of moduleScript org.openbravo.modulescript.InitializeAcctDimensionsInClientfailed.
     [java] at org.openbravo.modulescript.ModuleScriptHandler.execute(ModuleScriptHandler.java:68)
     [java] at org.openbravo.ddlutils.task.AlterDatabaseDataAll.doExecute(AlterDatabaseDataAll.java:173)
     [java] at org.openbravo.ddlutils.task.BaseDatabaseTask.execute(BaseDatabaseTask.java:86)
     [java] at org.openbravo.ddlutils.task.AlterDatabaseJava.main(AlterDatabaseJava.java:38)
     [java] Exception in thread "main" Execution of moduleScript org.openbravo.modulescript.InitializeAcctDimensionsInClientfailed.
     [java] at org.openbravo.ddlutils.task.AlterDatabaseDataAll.doExecute(AlterDatabaseDataAll.java:248)
     [java] at org.openbravo.ddlutils.task.BaseDatabaseTask.execute(BaseDatabaseTask.java:86)
     [java] at org.openbravo.ddlutils.task.AlterDatabaseJava.main(AlterDatabaseJava.java:38)
     [java] Caused by: Execution of moduleScript org.openbravo.modulescript.InitializeAcctDimensionsInClientfailed.
     [java] at org.openbravo.modulescript.ModuleScriptHandler.execute(ModuleScriptHandler.java:68)
     [java] at org.openbravo.ddlutils.task.AlterDatabaseDataAll.doExecute(AlterDatabaseDataAll.java:173)
     [java] ... 2 more
     [java] --- Nested Exception ---
     [java] Execution of moduleScript org.openbravo.modulescript.InitializeAcctDimensionsInClientfailed.
     [java] at org.openbravo.modulescript.ModuleScriptHandler.execute(ModuleScriptHandler.java:68)
     [java] at org.openbravo.ddlutils.task.AlterDatabaseDataAll.doExecute(AlterDatabaseDataAll.java:173)
     [java] at org.openbravo.ddlutils.task.BaseDatabaseTask.execute(BaseDatabaseTask.java:86)
     [java] at org.openbravo.ddlutils.task.AlterDatabaseJava.main(AlterDatabaseJava.java:38)
Steps To ReproduceOn a new installation (I have 3.0MP17.2, but I think it would reproduce with the last release...)
Install an upgrade of a module or a new module
run ant smartbuild -Dlocal=no
Proposed SolutionIn previous versions, the InitializeAcctDimensionsInClient class was not in the src-util/moduleScript/src/org/openbravo/modulescript folder, so it wasn't executed when smartbuild.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-01-29 17:10neil_smithNew Issue
2013-01-29 17:10neil_smithAssigned To => marvintm
2013-01-29 17:10neil_smithModules => Core
2013-01-29 17:10neil_smithTriggers an Emergency Pack => No
2013-01-29 17:11neil_smithIssue Monitored: neil_smith
2013-02-04 18:15marvintmAssigned Tomarvintm => Sandrahuguet
2013-02-04 18:15marvintmPriorityimmediate => high
2013-02-04 18:15marvintmSeveritycritical => major
2013-02-04 18:18SandrahuguetNote Added: 0056138
2013-02-04 18:18SandrahuguetStatusnew => feedback
2013-02-05 07:27neil_smithNote Added: 0056142
2013-02-05 09:34SandrahuguetNote Added: 0056143
2013-02-05 09:51neil_smithNote Added: 0056145
2013-02-05 09:52neil_smithNote Added: 0056146
2013-02-05 10:10SandrahuguetNote Added: 0056147
2013-02-05 12:37hgbotCheckin
2013-02-05 12:37hgbotNote Added: 0056159
2013-02-05 12:37hgbotStatusfeedback => resolved
2013-02-05 12:37hgbotResolutionopen => fixed
2013-02-05 12:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0c05ff4e91d303288a9ef360922d9a3c502280f9 [^]
2013-02-05 12:46eduardo_ArgalReview Assigned To => eduardo_Argal
2013-02-05 12:46eduardo_ArgalNote Added: 0056161
2013-02-05 12:46eduardo_ArgalStatusresolved => closed
2013-02-05 22:44hudsonbotCheckin
2013-02-05 22:44hudsonbotNote Added: 0056196

Notes
(0056138)
Sandrahuguet   
2013-02-04 18:18   
Hi, I need some details.

Could tell from that MP has been updated to MP17.2 and what modules have you installed?

Can you tell me if you have the preference DimensionDisplayConfigured?

Thanks in advance.
(0056142)
neil_smith   
2013-02-05 07:27   
I have a clean installation (MP17.2) and I try to install a module (one that I developped).

I don't have a property named DimensionDisplayConfigured.

Thanks for your time

Best regards
Neil.
(0056143)
Sandrahuguet   
2013-02-05 09:34   
You should insert a preference with value attribute=DimensionDisplayConfigured
or execute this sql:
INSERT INTO ad_preference (ad_preference_id, ad_client_id, ad_org_id, isactive,
createdby, created, updatedby, updated,attribute ) VALUES (get_uuid(), ?, '0', 'Y','0', NOW(), '0', NOW(), 'DimensionDisplayConfigured')
(0056145)
neil_smith   
2013-02-05 09:51   
Sorry, but what will this change? Why isn't the property automatically inserted if it is necessary?

Thanks for your time

Best regards
Beuk,
(0056146)
neil_smith   
2013-02-05 09:52   
sorry, that was Neil, not Beuk... ha ha ha
(0056147)
Sandrahuguet   
2013-02-05 10:10   
The preference is automatically inserted but it seems that something went wrong. We are working on improving this modulescript. But to fix your environment you need to insert this preference.
(0056159)
hgbot   
2013-02-05 12:37   
Repository: erp/devel/pi
Changeset: 0c05ff4e91d303288a9ef360922d9a3c502280f9
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Feb 05 11:47:03 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0c05ff4e91d303288a9ef360922d9a3c502280f9 [^]

Fixed bug 22926 Modify modulescript to do in one transaction all inserts

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeAcctDimensionsInClient.class
M src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeAcctDimensionsInClientData.class
M src-util/modulescript/build/javasqlc/src/org/openbravo/modulescript/InitializeAcctDimensionsInClientData.java
M src-util/modulescript/src/org/openbravo/modulescript/InitializeAcctDimensionsInClient.java
M src-util/modulescript/src/org/openbravo/modulescript/InitializeAcctDimensionsInClient_data.xsql
---
(0056161)
eduardo_Argal   
2013-02-05 12:46   
Code Reviewed and tested
(0056196)
hudsonbot   
2013-02-05 22:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/86db3ad54671 [^]

Maturity status: Test