Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022923Openbravo ERPA. Platformpublic2013-01-29 15:552013-02-18 10:00
Reporteregoitz 
Assigned Tomtaal 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP19.2 
Target Version3.0MP20Fixed in Version3.0MP20 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browserApple Safari
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022923: Cursors not closed
DescriptionThere are some files executing prepared statments and then these statments are not closed.

org.openbravo.base.OBSchedulerInitializerListener -> method contextInitialized

org.openbravo.service.system.SystemService -> methods deleteClient,resetSafeMode,killConnectionsAndSafeMode

org.openbravo.erpCommon.ad_process.ApplyModulesCallServlet -> method getError

org.openbravo.service.db.CallStoredProcedure -> method call (in this case it is closed but not on the finally block so if the procedure fails the statment is not closed)

org.openbravo.base.model.ModelProvider -> method initializeReferenceClasses

org.openbravo.utils.OBRebuildAppender -> method append
Steps To Reproduce check the code
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 00227373.0MP20 closed mtaal Close preparedstatement in DalSessionFactory 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-01-29 15:55egoitzNew Issue
2013-01-29 15:55egoitzAssigned To => mtaal
2013-01-29 15:55egoitzWeb browser => Apple Safari
2013-01-29 15:55egoitzModules => Core
2013-01-29 15:55egoitzOBNetwork customer => Yes
2013-01-29 15:55egoitzTriggers an Emergency Pack => No
2013-01-29 15:55egoitzTag Attached: Performance
2013-01-29 15:55egoitzRelationship addedrelated to 0022737
2013-01-30 09:51shuehnerIssue Monitored: shuehner
2013-01-30 12:36hgbotCheckin
2013-01-30 12:36hgbotNote Added: 0055971
2013-01-30 12:36hgbotStatusnew => resolved
2013-01-30 12:36hgbotResolutionopen => fixed
2013-01-30 12:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d0dbfd0f4d02d5ce2f4810595128c35f307077dc [^]
2013-01-30 12:37mtaalNote Added: 0055972
2013-01-30 14:28hgbotCheckin
2013-01-30 14:28hgbotNote Added: 0055974
2013-02-01 22:28hudsonbotCheckin
2013-02-01 22:28hudsonbotNote Added: 0056089
2013-02-01 22:28hudsonbotCheckin
2013-02-01 22:28hudsonbotNote Added: 0056090
2013-02-18 10:00AugustoMauchReview Assigned To => AugustoMauch
2013-02-18 10:00AugustoMauchNote Added: 0056509
2013-02-18 10:00AugustoMauchStatusresolved => closed
2013-02-18 10:00AugustoMauchFixed in Version => 3.0MP20

Notes
(0055971)
hgbot   
2013-01-30 12:36   
Repository: erp/devel/pi
Changeset: d0dbfd0f4d02d5ce2f4810595128c35f307077dc
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jan 30 12:36:06 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d0dbfd0f4d02d5ce2f4810595128c35f307077dc [^]

Fixes issue 22923: Cursors not closed
Add explicit statement close

---
M src-core/src/org/openbravo/utils/OBRebuildAppender.java
M src/org/openbravo/base/OBSchedulerInitializerListener.java
M src/org/openbravo/base/model/ModelProvider.java
M src/org/openbravo/erpCommon/ad_process/ApplyModulesCallServlet.java
M src/org/openbravo/service/db/CallStoredProcedure.java
M src/org/openbravo/service/system/SystemService.java
---
(0055972)
mtaal   
2013-01-30 12:37   
As a test I added breakpoints in all the change locations and executed different parts of the system:
- start the application
- install a module
- delete a client
- executed the DalStoredProcedureTest test

All passed correctly
(0055974)
hgbot   
2013-01-30 14:28   
Repository: erp/devel/pi
Changeset: b34d87f25d55f5fbd17730c47910e5bca5cf29e1
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jan 30 14:27:43 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b34d87f25d55f5fbd17730c47910e5bca5cf29e1 [^]

Related to issue 22923: Cursors not closed
Solve api issue

---
M src/org/openbravo/erpCommon/ad_process/ApplyModulesCallServlet.java
---
(0056089)
hudsonbot   
2013-02-01 22:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b070aa80fc76 [^]

Maturity status: Test
(0056090)
hudsonbot   
2013-02-01 22:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b070aa80fc76 [^]

Maturity status: Test
(0056509)
AugustoMauch   
2013-02-18 10:00   
Code reviewed and verified in pi@77ec6bfa0b6f