Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022856Openbravo ERPA. Platformpublic2013-01-22 09:402013-01-24 06:42
Reporterngarcia 
Assigned ToAugustoMauch 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP20Fixed in Version3.0MP20 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket18748
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022856: Views saved at org level cannot be edited nor deleted
DescriptionViews saved at org level cannot be edited nor deleted
Steps To ReproduceAs group admin role:
   Go to Purchase Order window and click on the Save view toolbar button
   Save a view:
      Level: Organization
   Save another view:
      Level: User
   Close the window and open it again
   Select the Delete view option and check that the first view does not appear in the combo
      
   
Proposed SolutionIn PersonalizationHandler.canEdit function substitute the following line

if (DalUtil.getId(roleOrg).equals(orgId)) {

for

if (DalUtil.getId(roleOrg.getOrganization()).equals(orgId)) {

Note: the roleOrg variable stores the identifier from the ad_role_orgaccess table, while we need the ad_org_id field
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-01-22 09:40ngarciaNew Issue
2013-01-22 09:40ngarciaAssigned To => dmiguelez
2013-01-22 09:40ngarciaModules => Core
2013-01-22 09:40ngarciaOBNetwork customer => Yes
2013-01-22 09:40ngarciaSupport ticket => 18748
2013-01-22 09:40ngarciaTriggers an Emergency Pack => No
2013-01-22 09:44ngarciaIssue Monitored: networkb
2013-01-22 09:45ngarciaAssigned Todmiguelez => ngarcia
2013-01-22 09:45ngarciaDescription Updatedbug_revision_view_page.php?rev_id=4286#r4286
2013-01-22 10:05ngarciaAssigned Tongarcia => AugustoMauch
2013-01-22 10:05ngarciaCategory01. General setup => A. Platform
2013-01-22 12:32AugustoMauchTarget Version => 3.0MP20
2013-01-23 17:56AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=4290#r4290
2013-01-23 17:56AugustoMauchIssue Monitored: shankarb
2013-01-23 17:56AugustoMauchReview Assigned To => shankarb
2013-01-23 17:59hgbotCheckin
2013-01-23 17:59hgbotNote Added: 0055775
2013-01-23 17:59hgbotStatusnew => resolved
2013-01-23 17:59hgbotResolutionopen => fixed
2013-01-23 17:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1cd5ddac39771ca641283cb9ba53d683c40be231 [^]
2013-01-24 04:59hudsonbotCheckin
2013-01-24 04:59hudsonbotNote Added: 0055791
2013-01-24 06:42shankarbNote Added: 0055793
2013-01-24 06:42shankarbStatusresolved => closed
2013-01-24 06:42shankarbFixed in Version => 3.0MP20

Notes
(0055775)
hgbot   
2013-01-23 17:59   
Repository: erp/devel/pi
Changeset: 1cd5ddac39771ca641283cb9ba53d683c40be231
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Jan 23 17:58:40 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1cd5ddac39771ca641283cb9ba53d683c40be231 [^]

Fixes issue 22856: Views defined at organization level can be deleted

On the PersonalizationHandler.canEdit method, in order to check if a saved view could be edited the organization of the user was being compared with the RoleOrganization entity of the view, instead of the organization of the RoleOrganization entity.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationHandler.java
---
(0055791)
hudsonbot   
2013-01-24 04:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c7e708c0b53e [^]

Maturity status: Test
(0055793)
shankarb   
2013-01-24 06:42   
tested and verified in pi changeset 15b14b0cb32f