Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022797Openbravo ERPZ. Otherspublic2013-01-14 18:522014-03-15 03:04
Reportermaite 
Assigned Toshankarb 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP21Fixed in Version3.0MP21 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket18982
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022797: Pick and Execute in Payment Proposal window is not working properly
DescriptionPick and Execute in Payment Proposal window is not working properly
Steps To Reproduce1. Create Payment proposal header for España organization. No set any business partner
2. Run Select Expected Payments button, clean default filters and select any record. Now, before submit changes, filter by any available business partner and select its line. Submit changes and realize that no lines are added.

Problem seems to be when using any filtering criteria in pick and edit window, because if you add one or more lines, submit them, press Select Expected Payments button again and select any other line (no using filtering criteria) all lines are properly added.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00236193.0MP23 closed AugustoMauch Pick and execute grid does not remember selection when it is sorted 
related to defect 00254753.0PR14Q2 closed shankarb Pick and Execute in Payment Proposal window is not filtering properly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-01-14 18:52maiteNew Issue
2013-01-14 18:52maiteAssigned To => dmiguelez
2013-01-14 18:52maiteModules => Advanced Payables and Receivables Mngmt
2013-01-14 18:52maiteOBNetwork customer => Yes
2013-01-14 18:52maiteSupport ticket => 18982
2013-01-14 18:52maiteTriggers an Emergency Pack => No
2013-01-14 18:53maiteIssue Monitored: networkb
2013-01-14 18:53maitePrioritynormal => immediate
2013-01-15 10:06dmiguelezAssigned Todmiguelez => jonalegriaesarte
2013-02-11 16:53jonalegriaesarteAssigned Tojonalegriaesarte => jecharri
2013-02-11 16:54jonalegriaesartePriorityimmediate => urgent
2013-02-11 16:54jonalegriaesarteTarget Version => 3.0MP21
2013-02-13 15:54jecharriAssigned Tojecharri => AugustoMauch
2013-02-14 12:33AugustoMauchAssigned ToAugustoMauch => shankarb
2013-02-19 13:19shankarbStatusnew => scheduled
2013-02-19 13:19shankarbfix_in_branch => pi
2013-02-19 13:45shankarbReview Assigned To => AugustoMauch
2013-02-19 13:45shankarbfix_in_branchpi =>
2013-02-19 13:45shankarbIssue Monitored: AugustoMauch
2013-02-19 13:46hgbotCheckin
2013-02-19 13:46hgbotNote Added: 0056547
2013-02-19 13:46hgbotStatusscheduled => resolved
2013-02-19 13:46hgbotResolutionopen => fixed
2013-02-19 13:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b55c25ebb28b170915385a37ad4d578d37c10802 [^]
2013-02-20 04:51hudsonbotCheckin
2013-02-20 04:51hudsonbotNote Added: 0056626
2013-02-28 15:07hgbotCheckin
2013-02-28 15:07hgbotNote Added: 0056840
2013-03-01 11:36hgbotCheckin
2013-03-01 11:36hgbotNote Added: 0056885
2013-03-01 11:36hgbotCheckin
2013-03-01 11:36hgbotNote Added: 0056886
2013-03-02 05:48hudsonbotCheckin
2013-03-02 05:48hudsonbotNote Added: 0056931
2013-03-02 05:48hudsonbotCheckin
2013-03-02 05:48hudsonbotNote Added: 0056942
2013-03-02 05:48hudsonbotCheckin
2013-03-02 05:48hudsonbotNote Added: 0056943
2013-03-04 10:32AugustoMauchNote Added: 0056958
2013-03-04 10:32AugustoMauchStatusresolved => closed
2013-03-04 10:32AugustoMauchFixed in Version => 3.0MP21
2013-04-23 16:01AugustoMauchRelationship addedrelated to 0023619
2014-01-15 17:01ioritzCiaRelationship addedrelated to 0025475
2014-03-13 07:18hgbotCheckin
2014-03-13 07:18hgbotNote Added: 0065106
2014-03-13 07:18hgbotStatusclosed => resolved
2014-03-13 07:18hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/b55c25ebb28b170915385a37ad4d578d37c10802 [^] => http://code.openbravo.com/erp/devel/pi/rev/a9321acaca4e1064af29cf62914d3e6e00d9a1cb [^]
2014-03-13 07:21shankarbNote Added: 0065108
2014-03-13 07:21shankarbStatusresolved => closed
2014-03-13 07:35hgbotCheckin
2014-03-13 07:35hgbotNote Added: 0065110
2014-03-15 03:04hudsonbotCheckin
2014-03-15 03:04hudsonbotNote Added: 0065172
2014-03-15 03:04hudsonbotCheckin
2014-03-15 03:04hudsonbotNote Added: 0065174
2014-03-15 03:04hudsonbotCheckin
2014-03-15 03:04hudsonbotNote Added: 0065175

Notes
(0056547)
hgbot   
2013-02-19 13:46   
Repository: erp/devel/pi
Changeset: b55c25ebb28b170915385a37ad4d578d37c10802
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Feb 19 18:05:22 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/b55c25ebb28b170915385a37ad4d578d37c10802 [^]

Fixes Issue 0022797: Pick and Execute in Payment Proposal window is not working properly

When filtering records after selection, only the selected id's were retained.
Modified code to retain the whole object when the data is fetched.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0056626)
hudsonbot   
2013-02-20 04:51   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d828167a9e83 [^]

Maturity status: Test
(0056840)
hgbot   
2013-02-28 15:07   
Repository: erp/devel/pi
Changeset: 29d08718823e0b641aa68e6b0f6f73a167432277
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Feb 28 19:33:34 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/29d08718823e0b641aa68e6b0f6f73a167432277 [^]

Related to Issue 0022797 : Code Refactoring

Modified logic to retain the editable fields alone instead of retaining the whole record while filtering.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0056885)
hgbot   
2013-03-01 11:36   
Repository: erp/devel/pi
Changeset: 13f53a5dcd907e003d483f7604141f140eb3fc18
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Fri Mar 01 16:04:07 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/13f53a5dcd907e003d483f7604141f140eb3fc18 [^]

Related to Issue 22707 : Backed out changeset

Backout changeset as it is the commit of issue 22797.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0056886)
hgbot   
2013-03-01 11:36   
Repository: erp/devel/pi
Changeset: 92a48bbd8673c7c4e0e3e471b90aa8a787b0b039
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Fri Mar 01 16:05:00 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/92a48bbd8673c7c4e0e3e471b90aa8a787b0b039 [^]

Related to Issue 22797 : Code Refactoring

Modified code to retrieve getFields() before the loop.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0056931)
hudsonbot   
2013-03-02 05:48   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f5db629e7058 [^]

Maturity status: Test
(0056942)
hudsonbot   
2013-03-02 05:48   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f5db629e7058 [^]

Maturity status: Test
(0056943)
hudsonbot   
2013-03-02 05:48   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f5db629e7058 [^]

Maturity status: Test
(0056958)
AugustoMauch   
2013-03-04 10:32   
Code reviewed and verified in pi@b89b81a6f0f9
(0065106)
hgbot   
2014-03-13 07:18   
Repository: erp/devel/pi
Changeset: a9321acaca4e1064af29cf62914d3e6e00d9a1cb
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Mar 13 11:43:10 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/a9321acaca4e1064af29cf62914d3e6e00d9a1cb [^]

Fixes Issue 22797: Pick and Execute in Payment Proposal window is not working properly

In case of large data, if data is not available in allRows, it is checked if localData contains data.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0065108)
shankarb   
2014-03-13 07:21   
Issue already fixed. The commit[1] is incorrectly committed to this issue. It is the commit of the issue[2]

[1] https://code.openbravo.com/erp/devel/pi/rev/a9321acaca4e [^]
[2] https://issues.openbravo.com/view.php?id=25475 [^]
(0065110)
hgbot   
2014-03-13 07:35   
Repository: erp/devel/pi
Changeset: 6e9494ef95ff365059fc85aa0a515fbea7fedb44
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Mar 13 11:57:47 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/6e9494ef95ff365059fc85aa0a515fbea7fedb44 [^]

Related to issue 25475, issue 22797: Backed out changeset a9321acaca4e

Backing out the changeset as the commit has been incorrectly commited to issue 22797 instead of 25475.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0065172)
hudsonbot   
2014-03-15 03:04   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8396ec753aec [^]
Maturity status: Test
(0065174)
hudsonbot   
2014-03-15 03:04   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8396ec753aec [^]
Maturity status: Test
(0065175)
hudsonbot   
2014-03-15 03:04   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8396ec753aec [^]
Maturity status: Test