Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0022753 | Openbravo ERP | A. Platform | public | 2013-01-09 16:33 | 2013-01-10 20:31 |
|
| Reporter | AugustoMauch | |
| Assigned To | AugustoMauch | |
| Priority | immediate | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | pi | |
| Merge Request Status | |
| Review Assigned To | shankarb |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0022753: Display logic for tabs work with session attributes, but not with preferences |
| Description | Three types of variables can be used in a tab display logic:
1- Values of a ancestor tab field
2- Session attribute
3- Preference
Currently 1) and 2) works, but not 3. |
| Steps To Reproduce | - Use this display logic in the Lines tab of the Sales Order window: @StockReservations@!''
- As F&B admin, make sure that there is no value defined for the Enable Stock Reservations property.
- Open Sales Order. The Lines tab should not be shown, but right now it is shown. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2013-01-09 16:33 | AugustoMauch | New Issue | |
| 2013-01-09 16:33 | AugustoMauch | Assigned To | => AugustoMauch |
| 2013-01-09 16:33 | AugustoMauch | Modules | => Core |
| 2013-01-09 16:33 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2013-01-09 16:34 | AugustoMauch | Note Added: 0055425 | |
| 2013-01-09 16:34 | AugustoMauch | Issue Monitored: dbaz | |
| 2013-01-09 16:34 | AugustoMauch | Issue End Monitor: dbaz | |
| 2013-01-09 16:34 | AugustoMauch | Issue Monitored: shankarb | |
| 2013-01-09 16:35 | AugustoMauch | Review Assigned To | => shankarb |
| 2013-01-09 16:44 | hgbot | Checkin | |
| 2013-01-09 16:44 | hgbot | Note Added: 0055426 | |
| 2013-01-09 16:44 | hgbot | Status | new => resolved |
| 2013-01-09 16:44 | hgbot | Resolution | open => fixed |
| 2013-01-09 16:44 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/a7600139e3c89e5dee52d8517a9d39552343cfe2 [^] |
| 2013-01-10 06:51 | shankarb | Note Added: 0055441 | |
| 2013-01-10 06:51 | shankarb | Status | resolved => closed |
| 2013-01-10 06:51 | shankarb | Fixed in Version | => pi |
| 2013-01-10 20:31 | hudsonbot | Checkin | |
| 2013-01-10 20:31 | hudsonbot | Note Added: 0055469 | |
|
Notes |
|
|
|
Test Plan:
- Use this display logic in the Lines tab of the Sales Order window: @StockReservations@!''
- As F&B admin, make sure that there is no value defined for the Enable Stock Reservations property.
- Open Sales Order. The Lines tab should not be shown
- Add a preference for the property Enable Stock Reservations with value set to Y.
- Log out and log in again to reload the preferences.
- Open Sales Order again. The Lines tab should be shown.
- Test that it is still possible to use session preferences (i.e. @ShowAcct@!'') and the values of fields of the ancestor tabs (i.e. @DocumentNo@!''). |
|
|
|
(0055426)
|
|
hgbot
|
|
2013-01-09 16:44
|
|
Repository: erp/devel/pi
Changeset: a7600139e3c89e5dee52d8517a9d39552343cfe2
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Jan 09 16:44:12 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a7600139e3c89e5dee52d8517a9d39552343cfe2 [^]
Fixes issue 22753: Tab display logic works with preferences
Preferences were being treated as fields, so its name was wrongly being converted to its inp form. Of the three types of variables that can be used in the display logic of a tab (session attributes, preferences and fields of the tab ancestors) only the fields have to be converted to its inp format. Both session attibutes and preference values can be included in the tab definition, because they are independent of the selected row.
---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewTab.java
---
|
|
|
|
(0055441)
|
|
shankarb
|
|
2013-01-10 06:51
|
|
|
Code Reviewed and tested in pi changeset 5205119c890b |
|
|
|
|
|