Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022702Openbravo ERPZ. Otherspublic2012-12-28 14:242013-04-08 18:56
Reportermaite 
Assigned Todmiguelez 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP22Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022702: Error when trying to Modify transaction
DescriptionNull Pointer Exception error is obtained when trying to Modify an unposted gl item transaction
Steps To Reproduce1. Go to any Financial Account and press "Add Transaction" button. Select any GL Item and amount and press OK.
2. Select added Transaction and press "Modify" button. Try to define any Business Partner as accounting dimension. Error will be raised

Error register in log is:
java.lang.NullPointerException at org.openbravo.advpaymentmngt.process.FIN_TransactionModify.execute(FIN_TransactionModify.java:139). Problem is that variable "newGLItem" is null
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0023102 closed AugustoMauch Modify Transacction 
blocks defect 0022550 closed pramakrishnan Cannot modify product on g/l item transaction in financial account 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-12-28 14:24maiteNew Issue
2012-12-28 14:24maiteAssigned To => dmiguelez
2012-12-28 14:24maiteModules => Advanced Payables and Receivables Mngmt
2012-12-28 14:24maiteTriggers an Emergency Pack => No
2012-12-28 14:24maiteAssigned Todmiguelez => jonalegriaesarte
2012-12-28 14:24maiteIssue Monitored: networkb
2013-01-09 11:26jonalegriaesarteTarget Version3.0MP19 => 3.0MP20
2013-01-24 11:19jonalegriaesarteTarget Version3.0MP20 => 3.0MP21
2013-02-11 13:38ioritzCiaAssigned Tojonalegriaesarte => ioritzCia
2013-02-12 09:31ioritzCiaAssigned ToioritzCia => AugustoMauch
2013-02-12 09:37ioritzCiaNote Added: 0056364
2013-02-12 12:17AugustoMauchAssigned ToAugustoMauch => shankarb
2013-02-18 15:22AugustoMauchRelationship addedhas duplicate 0023102
2013-02-21 13:44AugustoMauchAssigned Toshankarb => AugustoMauch
2013-02-26 11:27eduardo_ArgalRelationship addedblocks 0022550
2013-02-26 19:23AugustoMauchAssigned ToAugustoMauch => dmiguelez
2013-02-26 19:30AugustoMauchNote Added: 0056790
2013-02-27 13:18dmiguelezTarget Version3.0MP21 => 3.0MP22
2013-03-12 18:35ioritzCiaNote Added: 0057212
2013-03-12 18:35ioritzCiaSeveritymajor => minor
2013-04-02 19:53hgbotCheckin
2013-04-02 19:53hgbotNote Added: 0057573
2013-04-02 19:53hgbotStatusnew => resolved
2013-04-02 19:53hgbotResolutionopen => fixed
2013-04-02 19:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4f86e70e540655cff47e629bf86592c599e10611 [^]
2013-04-03 10:06hgbotCheckin
2013-04-03 10:06hgbotNote Added: 0057702
2013-04-07 01:03hudsonbotCheckin
2013-04-07 01:03hudsonbotNote Added: 0057758
2013-04-07 01:03hudsonbotCheckin
2013-04-07 01:03hudsonbotNote Added: 0057759
2013-04-08 18:56dmiguelezNote Added: 0057791
2013-04-08 18:56dmiguelezStatusresolved => closed

Notes
(0056364)
ioritzCia   
2013-02-12 09:37   
The issue is that the new selectors (in this case not the newests) do not work fine in 2.50. If you follow the steps to reproduce but in addition you click to make the dropdown appear the issue will not happen. This is because when loading the process window, it only loads the record ids, but when making the dropdown appear it loads the identifiers too.

In this particular case, the default value of the parameter is wrong because it forces the name of the entity to be saved. But this causes a NullPointerException in the line told above, as it tries to rescue the entity through DAL giving the name as an id returning null. And later tries to access an attribute of that null entity.
(0056790)
AugustoMauch   
2013-02-26 19:30   
This problem happens because that selector does not have its valuemap populated until a call is done to the datasource (i.e. when the dropdown is opened).

It is not worth it to try to fix this deprecated technology, the best option would be to implement this pop up using the new parameter windows.
(0057212)
ioritzCia   
2013-03-12 18:35   
Changed to minor waiting to solve some problems with parameter windows project.
(0057573)
hgbot   
2013-04-02 19:53   
Repository: erp/devel/pi
Changeset: 4f86e70e540655cff47e629bf86592c599e10611
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Apr 02 19:53:15 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4f86e70e540655cff47e629bf86592c599e10611 [^]

Fixes Issue 22702. In Financial Account, Transaction Tab is no
longer retrieving data from a view.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/triggers/APRM_FIN_FINACC_TRAN_CHECK_TRG.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REFERENCE.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REF_TABLE.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TAB.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/Reconciliation.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java
M src-db/database/model/tables/C_CONVERSION_RATE_DOCUMENT.xml
M src-db/database/model/triggers/C_CONVERSION_RATE_DOCUMENT_TRG.xml
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_VAL_RULE.xml
M src/org/openbravo/erpCommon/ad_callouts/SE_CalculateExchangeRate.java
A modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/UpdateTransactionBPExchangeRate.class
A modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/UpdateTransactionBPExchangeRateData.class
A modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/UpdateTransactionBPExchangeRate.java
A modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/UpdateTransactionBPExchangeRate_data.xsql
A modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/UpdateTransactionBPExchangeRateData.java
A src/org/openbravo/erpCommon/ad_callouts/SE_GLItem_Transaction.java
---
(0057702)
hgbot   
2013-04-03 10:06   
Repository: erp/devel/pi
Changeset: 3e0c1c71113fc6c168ae166658145d632e80a1ab
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Apr 03 10:05:43 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3e0c1c71113fc6c168ae166658145d632e80a1ab [^]

Related to Issue 22702. Fixes DBConsistency.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0057758)
hudsonbot   
2013-04-07 01:03   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b03a336bd23b [^]

Maturity status: Test
(0057759)
hudsonbot   
2013-04-07 01:03   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b03a336bd23b [^]

Maturity status: Test
(0057791)
dmiguelez   
2013-04-08 18:56   
Code Review + Testing OK