Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022690Openbravo ERPA. Platformpublic2012-12-27 17:572013-01-03 13:12
Reportersureshbabu 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Versionpi 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customerNo
Web browserGoogle Chrome
ModulesOpenbravo 3.0
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2011-10-26
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/f9b05776d657 [^]
Triggers an Emergency PackNo
Summary0022690: [Reg] In Return to Vendor window, Save icon in tool bar is disabled in grid view
Description[Reg] In Return to Vendor window, at grid view, when an new record is inserted, Save icon in tool bar is disabled also when i click Ctrl + S to save the record there is no response.

Note: Above icon is enabled in Mp18
Steps To ReproduceLogin as Openbravo/openbravo
Change the role as QA Testing Admin
Navigate to Return to vendor window
Click Ctrl + I to insert new row in grid view
Then select BP: Vendor A

Defect: Click Ctrl + S to save the record, there is no response. Also the Save icon in Tool bar is disabled.(Above functionality is working fine in form view. )


Note: Also the above functionality is working fine in Mp18 release.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Save icon not getting enabled in tool bar at Return to vendor window.png (182,503) 2012-12-27 17:57
https://issues.openbravo.com/file_download.php?file_id=5866&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-12-27 17:57sureshbabuNew Issue
2012-12-27 17:57sureshbabuAssigned To => dmiguelez
2012-12-27 17:57sureshbabuFile Added: Save icon not getting enabled in tool bar at Return to vendor window.png
2012-12-27 17:57sureshbabuWeb browser => Google Chrome
2012-12-27 17:57sureshbabuModules => Openbravo 3.0
2012-12-27 17:57sureshbabuOBNetwork customer => No
2012-12-27 17:57sureshbabuTriggers an Emergency Pack => No
2012-12-27 18:00sureshbabuWeb browserGoogle Chrome => Google Chrome
2012-12-27 18:00sureshbabuRegression level => QA functional test
2012-12-28 09:18SandrahuguetWeb browserGoogle Chrome => Google Chrome
2012-12-28 09:18SandrahuguetAssigned Todmiguelez => AugustoMauch
2012-12-28 09:18SandrahuguetCategory03. Procurement management => A. Platform
2012-12-28 19:14dmitry_mezentsevNote Added: 0055283
2012-12-29 17:49sureshbabuWeb browserGoogle Chrome => Google Chrome
2012-12-29 17:49sureshbabuRegression levelQA functional test =>
2012-12-31 11:05AugustoMauchIssue Monitored: shankarb
2012-12-31 11:07AugustoMauchReview Assigned To => shankarb
2012-12-31 11:07AugustoMauchWeb browserGoogle Chrome => Google Chrome
2012-12-31 11:07AugustoMauchRegression level => Production - Confirmed Stable
2012-12-31 11:07AugustoMauchRegression date => 2011-10-26
2012-12-31 11:07AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/f9b05776d657 [^]
2012-12-31 11:41hgbotCheckin
2012-12-31 11:41hgbotNote Added: 0055286
2012-12-31 11:41hgbotStatusnew => resolved
2012-12-31 11:41hgbotResolutionopen => fixed
2012-12-31 11:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/cb19f41d5523ab127140d43d53c6f6e1baf02b3f [^]
2012-12-31 12:03shankarbNote Added: 0055287
2012-12-31 12:03shankarbStatusresolved => closed
2012-12-31 12:03shankarbFixed in Version => pi
2013-01-03 13:12hudsonbotCheckin
2013-01-03 13:12hudsonbotNote Added: 0055342

Notes
(0055283)
dmitry_mezentsev   
2012-12-28 19:14   
For me it happens the same in the Return to Customer but I can also reproduce it in MP15.

So I am not sure that it is a regression or if it is - it might be very old one.

Also Save button is not always absent. For example, after I finally save a record (that does not have Save button) in a grid (for example by clicking on one of the existing records in grid) then the next record I create has the Save button.
(0055286)
hgbot   
2012-12-31 11:41   
Repository: erp/devel/pi
Changeset: cb19f41d5523ab127140d43d53c6f6e1baf02b3f
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Dec 31 11:05:17 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cb19f41d5523ab127140d43d53c6f6e1baf02b3f [^]

Fixes issue 22690: Save button is enabled in Return to Vendor window

The save button was not being enabled because there was one mandatory field (grandTotalAmount) that was empty. The thing is that this field belongs to the status bar, so it is read only, and should not be taken into account when cheking if all the mandatory fields have been set.

The allRequiredFieldsSet function has been modified so that it doesn't take into account the fields that are not displayed in the form (i.e. the status bar fields)

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0055287)
shankarb   
2012-12-31 12:03   
Code Review done and Verified in pi @ changeset cb19f41d5523
(0055342)
hudsonbot   
2013-01-03 13:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/792728467ed0 [^]

Maturity status: Test