Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022684Openbravo ERPA. Platformpublic2012-12-27 12:482013-01-28 17:53
ReporterVictorVillar 
Assigned Toshankarb 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0MP20 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket18662
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022684: expanding the registers of the Business Partner selector, only shows 76
Descriptionexpanding the registers of the Business Partner selector, only shows 76
Steps To ReproduceIn order to have more than 76 registers of Business Partner, import in the application (initial data load module) a .csv file with more than 76 registers
As group admin role,
Go to Sales order window
expand the options of the selector (dropdown menu) and it always shows 76 registers.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff FixIssue22684.diff (2,354) 2013-01-15 06:58
https://issues.openbravo.com/file_download.php?file_id=5891&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-12-27 12:48VictorVillarNew Issue
2012-12-27 12:48VictorVillarAssigned To => AugustoMauch
2012-12-27 12:48VictorVillarModules => Core
2012-12-27 12:48VictorVillarOBNetwork customer => Yes
2012-12-27 12:48VictorVillarSupport ticket => 18662
2012-12-27 12:48VictorVillarTriggers an Emergency Pack => No
2012-12-27 12:49VictorVillarIssue Monitored: networkb
2012-12-27 12:49VictorVillarRegression level => Production - Confirmed Stable
2012-12-28 13:51shankarbAssigned ToAugustoMauch => shankarb
2012-12-28 13:52shankarbStatusnew => scheduled
2012-12-28 13:52shankarbfix_in_branch => pi
2012-12-28 13:58hgbotCheckin
2012-12-28 13:58hgbotNote Added: 0055273
2013-01-03 13:12hudsonbotCheckin
2013-01-03 13:12hudsonbotNote Added: 0055338
2013-01-08 13:29shankarbIssue Monitored: mtaal
2013-01-08 13:29shankarbReview Assigned To => mtaal
2013-01-08 13:29shankarbfix_in_branchpi =>
2013-01-08 13:42hgbotCheckin
2013-01-08 13:42hgbotNote Added: 0055377
2013-01-08 13:42hgbotStatusscheduled => resolved
2013-01-08 13:42hgbotResolutionopen => fixed
2013-01-08 13:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a6b006e76cb2901e593570592a2a2d78953bbbf8 [^]
2013-01-09 05:41hudsonbotCheckin
2013-01-09 05:41hudsonbotNote Added: 0055396
2013-01-09 10:13AugustoMauchNote Added: 0055405
2013-01-09 10:13AugustoMauchStatusresolved => new
2013-01-09 10:13AugustoMauchResolutionfixed => open
2013-01-09 10:27hgbotCheckin
2013-01-09 10:27hgbotNote Added: 0055410
2013-01-09 10:27hgbotCheckin
2013-01-09 10:27hgbotNote Added: 0055411
2013-01-09 18:04hudsonbotCheckin
2013-01-09 18:04hudsonbotNote Added: 0055434
2013-01-09 18:04hudsonbotCheckin
2013-01-09 18:04hudsonbotNote Added: 0055435
2013-01-10 07:15shankarbFile Added: FixIssue22684.diff
2013-01-15 06:58shankarbFile Deleted: FixIssue22684.diff
2013-01-15 06:58shankarbFile Added: FixIssue22684.diff
2013-01-17 09:18shankarbIssue End Monitor: mtaal
2013-01-17 09:18shankarbIssue Monitored: AugustoMauch
2013-01-17 09:19shankarbReview Assigned Tomtaal => AugustoMauch
2013-01-17 12:28hgbotCheckin
2013-01-17 12:28hgbotNote Added: 0055561
2013-01-17 12:28hgbotStatusnew => resolved
2013-01-17 12:28hgbotResolutionopen => fixed
2013-01-17 12:28hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/a6b006e76cb2901e593570592a2a2d78953bbbf8 [^] => http://code.openbravo.com/erp/devel/pi/rev/0dd042f13165fc7b6fcf1c96653e70141c83602e [^]
2013-01-18 20:26hudsonbotCheckin
2013-01-18 20:26hudsonbotNote Added: 0055638
2013-01-21 09:10hgbotCheckin
2013-01-21 09:10hgbotNote Added: 0055645
2013-01-21 09:24hgbotCheckin
2013-01-21 09:24hgbotNote Added: 0055648
2013-01-22 15:33hudsonbotCheckin
2013-01-22 15:33hudsonbotNote Added: 0055728
2013-01-22 15:33hudsonbotCheckin
2013-01-22 15:33hudsonbotNote Added: 0055730
2013-01-28 17:53AugustoMauchNote Added: 0055922
2013-01-28 17:53AugustoMauchStatusresolved => closed
2013-01-28 17:53AugustoMauchFixed in Version => 3.0MP20

Notes
(0055273)
hgbot   
2012-12-28 13:58   
Repository: erp/devel/pi
Changeset: 96927b00ddcca0c9e0e2f34e62ed4de23e06e46c
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Fri Dec 28 18:26:32 2012 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/96927b00ddcca0c9e0e2f34e62ed4de23e06e46c [^]

Related to Issue 0022684: All the records are not loaded in selectors

In the dropdown menu of selector, the NO_COUNT parameter was set true. Thus only 75 records are loaded. This was done to fix the issue https://issues.openbravo.com/view.php?id=16621, [^] but without the paramter all the rows are not fetched.

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0055338)
hudsonbot   
2013-01-03 13:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/792728467ed0 [^]

Maturity status: Test
(0055377)
hgbot   
2013-01-08 13:42   
Repository: erp/devel/pi
Changeset: a6b006e76cb2901e593570592a2a2d78953bbbf8
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Jan 08 18:09:57 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/a6b006e76cb2901e593570592a2a2d78953bbbf8 [^]

Fixes Issue 22684 : Only 76 values shown in Custom Query Selector picklist

Modified Custom Query Selector to count the total number of rows.
This is not needed in normal selectors because total rows is calculated irrespective of start row and end row.
Also restored the changeset of issue 16621.

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0055396)
hudsonbot   
2013-01-09 05:41   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/195064f93651 [^]

Maturity status: Test
(0055405)
AugustoMauch   
2013-01-09 10:13   
This fix is not proper, because all the records are fetched when the selector drop down is opened. It should only fetch the first 76, and then after some scrolling the next 76, etc.
(0055410)
hgbot   
2013-01-09 10:27   
Repository: erp/devel/pi
Changeset: 23ef6bb2546474658c5e8892087c3645b6673a68
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Jan 09 14:55:32 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/23ef6bb2546474658c5e8892087c3645b6673a68 [^]

Related to issue 0022684: Backout changeset a6b006e76cb2

Backout changeset because it fetches records with paging.

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0055411)
hgbot   
2013-01-09 10:27   
Repository: erp/devel/pi
Changeset: bedb82b9459e1fd7bd1a96303bffc9958752c06b
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Jan 09 14:56:52 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/bedb82b9459e1fd7bd1a96303bffc9958752c06b [^]

Related to issue 22684 : Backout changeset 96927b00ddcc

Backout changeset because it breaks another issue 16621.

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0055434)
hudsonbot   
2013-01-09 18:04   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/314b62ac40f7 [^]

Maturity status: Test
(0055435)
hudsonbot   
2013-01-09 18:04   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/314b62ac40f7 [^]

Maturity status: Test
(0055561)
hgbot   
2013-01-17 12:28   
Repository: erp/devel/pi
Changeset: 0dd042f13165fc7b6fcf1c96653e70141c83602e
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Jan 17 16:57:03 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/0dd042f13165fc7b6fcf1c96653e70141c83602e [^]

Fixes Issue 0022684 : Only 76 records loaded in custom query selector picklist

Added logic to compute the total number of rows, without having to perform Count operation.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ReadOnlyDataSourceService.java
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java
---
(0055638)
hudsonbot   
2013-01-18 20:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4cd4a6cc38e0 [^]

Maturity status: Test
(0055645)
hgbot   
2013-01-21 09:10   
Repository: erp/devel/pi
Changeset: bc196be64b0340c83a3ad718f17ed5407d1c8051
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Jan 21 13:38:59 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/bc196be64b0340c83a3ad718f17ed5407d1c8051 [^]

Related to Issue 22306 : Backed out changeset 4db996f55ee3

Backed out changset as that is related to issue 22684.

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java
---
(0055648)
hgbot   
2013-01-21 09:24   
Repository: erp/devel/pi
Changeset: d64833c3f0c1e44ad1b055af00e6217101d56ff8
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Jan 21 13:53:11 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/d64833c3f0c1e44ad1b055af00e6217101d56ff8 [^]

Related to issue 22684 : Java Code Refactoring

Added comments to variable initialization.
Modified query.list() to scroll() for performance enhancement.

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java
---
(0055728)
hudsonbot   
2013-01-22 15:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/449aae8be624 [^]

Maturity status: Test
(0055730)
hudsonbot   
2013-01-22 15:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/449aae8be624 [^]

Maturity status: Test
(0055922)
AugustoMauch   
2013-01-28 17:53   
Code reviewed and verified in pi@e035b2855377