Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022590Openbravo ERP09. Financial managementpublic2012-12-17 05:182013-01-03 13:12
Reporterpjuvara 
Assigned ToSandrahuguet 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP17.1 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022590: Data corruption when creating a financial account transaction in a closed period
DescriptionWhen you create a financial account transaction in a closed period, an unmanaged exception is raised (org.openbravo.base.exception.OBException - see attachment1.png).

After the exception, the transaction is committed but the integrity of the transaction is broken and the financial account balance is not updated.

Compare attachment1.png (when the exception takes place) and attachment2.png (after the exception). You can see that the current balance for Bank Account 2 has not changed but in attachment2.png there is a new transaction, so the current balance in that picture should be 149,990.00.
Steps To ReproduceIn the demo environment:
1) Login with role F&B US Inc. Admin
2) Navigate to Open/Close Period and close all periods in 2011 for F&B US
3) Navigate to Financial Account and press Add Transactions
4) Create a G/L Item transaction during 2011. Press OK. The exception is raised.
5) Acknowledge the exception and refresh the Transaction tab; the transaction is retrieved but the account balance has not been updated.
Proposed SolutionYou should not be able to save a transaction in a closed period.
Rather than a technical exception, a user friendly error should be displayed.

The Add Transaction window should not close and the user should stay there.
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng attachment1.png (141,126) 2012-12-17 05:18
https://issues.openbravo.com/file_download.php?file_id=5842&type=bug
png

png attachment2.png (145,100) 2012-12-17 05:18
https://issues.openbravo.com/file_download.php?file_id=5843&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-12-17 05:18pjuvaraNew Issue
2012-12-17 05:18pjuvaraAssigned To => dmiguelez
2012-12-17 05:18pjuvaraFile Added: attachment1.png
2012-12-17 05:18pjuvaraModules => Core
2012-12-17 05:18pjuvaraTriggers an Emergency Pack => No
2012-12-17 05:18pjuvaraFile Added: attachment2.png
2012-12-17 05:20pjuvaraNote Added: 0054953
2012-12-19 17:40SandrahuguetAssigned Todmiguelez => Sandrahuguet
2012-12-19 17:41SandrahuguetStatusnew => scheduled
2012-12-19 17:41Sandrahuguetfix_in_branch => pi
2012-12-20 10:52SandrahuguetNote Added: 0055104
2012-12-27 10:15hgbotCheckin
2012-12-27 10:15hgbotNote Added: 0055235
2012-12-27 10:15hgbotStatusscheduled => resolved
2012-12-27 10:15hgbotResolutionopen => fixed
2012-12-27 10:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/34510269985f2c3407b04a7886f22a770077a360 [^]
2012-12-27 11:34dmiguelezReview Assigned To => dmiguelez
2012-12-27 11:34dmiguelezNote Added: 0055236
2012-12-27 11:34dmiguelezStatusresolved => closed
2013-01-03 13:12hudsonbotCheckin
2013-01-03 13:12hudsonbotNote Added: 0055327

Notes
(0054953)
pjuvara   
2012-12-17 05:20   
Note: this is a very serious issue as an innocent end user mistake (mistype the year on a date field) can result in data corruption where the financial account balance does not match the transactions and the value in the balance sheet.
(0055104)
Sandrahuguet   
2012-12-20 10:52   
Test Plan:

1) Login with role F&B US Inc. Admin
2) Navigate to Open/Close Period and close all periods in 2011 for F&B US
3) Navigate to Financial Account and press Add Transactions
4) Create a G/L Item transaction during 2011. Press OK
5) Notice that you get an error message and the transacction is not added
(0055235)
hgbot   
2012-12-27 10:15   
Repository: erp/devel/pi
Changeset: 34510269985f2c3407b04a7886f22a770077a360
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Dec 27 10:06:22 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/34510269985f2c3407b04a7886f22a770077a360 [^]

Fixed bug 22590 Display the error message properly

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddTransaction.html
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddTransaction.java
---
(0055236)
dmiguelez   
2012-12-27 11:34   
Code review + testing ok
(0055327)
hudsonbot   
2013-01-03 13:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/792728467ed0 [^]

Maturity status: Test