Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022582Openbravo ERPA. Platformpublic2012-12-14 12:422013-01-28 17:19
Reporterngarcia 
Assigned Toshankarb 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP20Fixed in Version3.0MP20 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket18423
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022582: In P&E windows the allRows property does not return anything if the grid is filtered
DescriptionIn Pick and Execute windows the allRows property does not return anything if the grid is filtered
Steps To ReproduceAs group admin role:

Go to Payment Proposal window and create a new record
Click on the Select Expected Payments button
Clear the filter and Submit
Notice that the allRows property includes allRows
Repeat the process by adding a filter
Notice that now the allRows property does not have any value
Proposed SolutionIn the doProcess function of the ob-pick-and-execute-view.js file, replace the following line

allRows = grid.data.allRows || grid.data;

with the following one

allRows = grid.data.allRows || grid.data.localData || grid.data;
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-12-14 12:42ngarciaNew Issue
2012-12-14 12:42ngarciaAssigned To => AugustoMauch
2012-12-14 12:42ngarciaModules => Core
2012-12-14 12:42ngarciaOBNetwork customer => Yes
2012-12-14 12:42ngarciaSupport ticket => 18423
2012-12-14 12:42ngarciaResolution time => 1361746800
2012-12-14 12:42ngarciaTriggers an Emergency Pack => No
2012-12-14 12:42ngarciaIssue Monitored: networkb
2013-01-18 11:37shankarbAssigned ToAugustoMauch => shankarb
2013-01-22 08:00shankarbStatusnew => scheduled
2013-01-22 08:00shankarbNote Added: 0055697
2013-01-22 08:00shankarbfix_in_branch => pi
2013-01-22 08:01shankarbReview Assigned To => AugustoMauch
2013-01-22 08:01shankarbfix_in_branchpi =>
2013-01-22 08:01shankarbIssue Monitored: AugustoMauch
2013-01-22 08:04hgbotCheckin
2013-01-22 08:04hgbotNote Added: 0055698
2013-01-22 08:04hgbotStatusscheduled => resolved
2013-01-22 08:04hgbotResolutionopen => fixed
2013-01-22 08:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a6e2bad672e71b91303e2873fb64d44a1b917b8b [^]
2013-01-22 15:33hudsonbotCheckin
2013-01-22 15:33hudsonbotNote Added: 0055739
2013-01-28 17:19AugustoMauchNote Added: 0055921
2013-01-28 17:19AugustoMauchStatusresolved => closed
2013-01-28 17:19AugustoMauchFixed in Version => 3.0MP20

Notes
(0055697)
shankarb   
2013-01-22 08:00   
Issue ready to be scheduled
(0055698)
hgbot   
2013-01-22 08:04   
Repository: erp/devel/pi
Changeset: a6e2bad672e71b91303e2873fb64d44a1b917b8b
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Jan 22 12:33:19 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/a6e2bad672e71b91303e2873fb64d44a1b917b8b [^]

Fixes Issue 0022582: Issue in handling submit with filtered records

In Pick and Execute windows the allRows property does not return anything if the grid is filtered.
Modified ob-parameter-window-view.js to also take into account localData in case the grid data is not available (as suggested in the issue).

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
---
(0055739)
hudsonbot   
2013-01-22 15:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/449aae8be624 [^]

Maturity status: Test
(0055921)
AugustoMauch   
2013-01-28 17:19   
Code reviewed and verified in pi@e035b2855377