Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022576Openbravo ERPZ. Otherspublic2012-12-14 09:112015-04-07 08:37
ReporterioritzCia 
Assigned Toiciordia 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionout of date 
PlatformOS20OS VersionUbuntu 10.04
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022576: Issue 21938: try-api fails.
DescriptionDue to this issue:

- https://issues.openbravo.com/view.php?id=21938 [^]

I have to make an api change. This is the api change:

- https://code.openbravo.com/erp/devel/try/diff/e70e0e5e76a2/src-db/database/sourcedata/AD_COLUMN.xml [^]

I have pushed the change to try, this is the failure:

- http://builds.openbravo.com/view/try/job/try-api/1212/console [^]


- The change is the following:
The column FIN_Payment.paymentDate changes from nullable to mandatory.

- The change is needed due to the following reason:
The system only allows you to insert a payment without payment date if the user deletes the date. It should not leave you do it. A payment without payment date cannnot be posted.

- The risk of the api change is very low to the following reason:
There is no logical business logic where a payment should not have a payment date. Someone could have developed by error a module where a payment can be null but the module most surely will work if it is not null. A buildvalidation has been developed in order to avoid people with payments with null payment date to update to the instance prior to having solved the problem.
Steps To Reproducenone.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0021938 new ioritzCia Payment date should be mandatory 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-12-14 09:11ioritzCiaNew Issue
2012-12-14 09:11ioritzCiaAssigned To => dmiguelez
2012-12-14 09:11ioritzCiaModules => Core
2012-12-14 09:11ioritzCiaTriggers an Emergency Pack => No
2012-12-14 09:12ioritzCiaAssigned Todmiguelez => iciordia
2012-12-14 09:12ioritzCiaStatusnew => feedback
2012-12-14 19:51iciordiaNote Added: 0054952
2013-01-09 10:11ioritzCiaPriorityimmediate => urgent
2013-01-09 10:11ioritzCiaSeveritycritical => major
2013-01-16 11:16ioritzCiaRelationship addedrelated to 0021938
2015-04-07 08:37alostaleStatusfeedback => closed
2015-04-07 08:37alostaleResolutionopen => out of date

Notes
(0054952)
iciordia   
2012-12-14 19:51   
Ioritz, as agreed, please research on our customer base to validate that the risk is low (although it makes no sense to have payments without payment_date, we need to confirm that there are no cases in which custom modules generate payments without payment_date) -> if that's the case then we should deploy this change very carefully.

Thanks,

Ismael