|
Notes |
|
|
|
On the dataArrived method of the ob-pick-and-execute-grid.js file, when the data is received from the datasource all those lines that come with the selectionProperty property set to true are selected.
The problem is that if one of those lines is unchecked and the grid is filtered, that line will be checked again.
To fix this, a list of the unchecked lines could be created, so if a line is unchecked it won't be re-checked when the grid is filtered |
|
|
|
(0055905)
|
|
hgbot
|
|
2013-01-28 12:24
|
|
Repository: erp/devel/pi
Changeset: cc72a8879a127b42419337b01731fafeb564eabf
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Jan 28 12:20:13 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cc72a8879a127b42419337b01731fafeb564eabf [^]
Fixes issue 22522: In P&E unselected records remain unselected after sorting
Before this fix, if a record was originally selected when a P&E window was opened, if it was deselected and a column sorted, the record was marked as selected again. This has been achieved by keeping a list that contains all the deselected records. When the data is reloaded, it a record is present in this list, it will not be marked as selected.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
|
|
|
|
|
Visually it is working correctly but the actual selection is not correct.
-Go to Return to Customer
-Create new record
-In P&E select one line
-Open P&E again and reorder, selection is still kept -> OK
-Click submit button: no selection is sent to backend so line is deleted from document -> ERROR |
|
|
|
(0055943)
|
|
hgbot
|
|
2013-01-29 12:41
|
|
Repository: erp/devel/pi
Changeset: 4c1fdc3c495d1e8342b7ba9a87ed82b1469599bb
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Jan 29 12:40:45 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4c1fdc3c495d1e8342b7ba9a87ed82b1469599bb [^]
Fixes issue 22522: In P&E windows, lines are not removed after sorting the grid
The correct way to retrieve the edited record corresponding with the record selection[i] is by using grid.getRecordIndex(selection[i]), and not grid.getEdited
Record(i). The previous way did not work if the grid was sorted after selecting the lines.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
---
|
|
|
|
|
|
code reviewed + verified in pi@bcabcc4c3b37 |
|
|
|
|
|
|
|
|
|