Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0022492Openbravo ERP09. Financial managementpublic2012-12-10 09:292012-12-11 17:54
mirurita 
mirurita 
normalmajoralways
closedfixed 
20Community Appliance
pi 
3.0MP18 
Core
Pre packaging ( pi )
2012-11-23
https://code.openbravo.com/erp/devel/pi/rev/e383ce9084f1 [^]
No
0022492: User1 dimension client configuration not working: always applying header logic
User1 dimension client configuration not working: always applying header logic.

User1 session variables are populated using always the "show in header" flag configuration.

1) Go to Client window and select ""F&B International Group"
2) Flag the following check-boxes:
  - 1st Dimension
  - Show in Lines
3) Log out and log in again
4) Go to sales invoice window
5) Create a new header and realize the "1st dimension" is not enabled. [OK]
6) Create a new line and realize the "1st dimension" is not enabled. This is wrong.
diff --git a/src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java b/src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java
--- a/src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java
+++ b/src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java
@@ -331,9 +331,9 @@
                   if (DIM_Header.equals(levelValue)) {
                     isDisplayed = client.isUser1AcctdimHeader() ? "Y" : "N";
                   } else if (DIM_Lines.equals(levelValue)) {
- isDisplayed = client.isUser1AcctdimHeader() ? "Y" : "N";
+ isDisplayed = client.isUser1AcctdimLines() ? "Y" : "N";
                   } else if (DIM_BreakDown.equals(levelValue)) {
- isDisplayed = client.isUser1AcctdimHeader() ? "Y" : "N";
+ isDisplayed = client.isUser1AcctdimBreakdown() ? "Y" : "N";
                   }
                 }
               } else {
No tags attached.
Issue History
2012-12-10 09:29miruritaNew Issue
2012-12-10 09:29miruritaAssigned To => mirurita
2012-12-10 09:29miruritaModules => Core
2012-12-10 09:29miruritaTriggers an Emergency Pack => No
2012-12-10 09:34miruritaRegression level => Pre packaging ( pi )
2012-12-10 09:34miruritaRegression date => 2012-11-23
2012-12-10 09:34miruritaRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/e383ce9084f1 [^]
2012-12-10 09:34miruritaTarget Version => 3.0MP18
2012-12-10 09:36hgbotCheckin
2012-12-10 09:36hgbotNote Added: 0054786
2012-12-10 09:36hgbotStatusnew => resolved
2012-12-10 09:36hgbotResolutionopen => fixed
2012-12-10 09:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3bc9eeaef28e25f7655e6901ad3916347040a5fa [^]
2012-12-10 09:39miruritaNote Added: 0054787
2012-12-10 13:13SandrahuguetNote Added: 0054802
2012-12-10 13:13SandrahuguetStatusresolved => closed
2012-12-11 17:54hudsonbotCheckin
2012-12-11 17:54hudsonbotNote Added: 0054860

Notes
(0054786)
hgbot   
2012-12-10 09:36   
Repository: erp/devel/pi
Changeset: 3bc9eeaef28e25f7655e6901ad3916347040a5fa
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Mon Dec 10 09:36:10 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3bc9eeaef28e25f7655e6901ad3916347040a5fa [^]

Fixes issue 22492: User1 dimension config always applies header logic

---
M src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java
---
(0054787)
mirurita   
2012-12-10 09:39   
Testing Plan
1) Go to Client window and select ""F&B International Group"
2) Flag the following check-boxes:
  - 1st Dimension
  - Show in Lines
3) Log out and log in again
4) Go to sales invoice window
5) Create a new header and realize the "1st dimension" is not enabled. [OK]
6) Create a new line and realize the "1st dimension" is not enabled. This is wrong. The "1st dimension" field should be displayed inside "Dimensions" section.
7) Go to Goods Receipt, Goods Shipment, Sales Order, Purchase Order lines tab and check whether "1st dimension" field is displayed.
(0054802)
Sandrahuguet   
2012-12-10 13:13   
Code review + testing OK
(0054860)
hudsonbot   
2012-12-11 17:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3b1b5e2f6c63 [^]

Maturity status: Test