Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022472Openbravo ERP04. Warehouse managementpublic2012-12-06 12:272013-01-31 16:39
ReporterVictorVillar 
Assigned Tojonalegriaesarte 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP20Fixed in Version 
Merge Request Status
Review Assigned ToVictorVillar
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket18139
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022472: NPE error launching the valued stock report
DescriptionNPE error launching the valued stock report, if you have the warehouse selected in the filters, defined as * organization level.
Steps To ReproduceAs group admin role,
Go to Warehouse and Storage bin window.
 Create a new one for * Org. level

Go to Valued stock report and launch the report for the warehouse created before.

Null Pointer Exception error
Proposed SolutionRemove from ReportValuationStock.java:

String strBaseCurrencyId = (String)DalUtil.getId(FinancialUtils.getLegalEntityCurrency(wh
.getOrganization()));

Because this variable is not used in the java and is looking for the currency of the organization assigned to the warehouse selected
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-12-06 12:27VictorVillarNew Issue
2012-12-06 12:27VictorVillarAssigned To => dmiguelez
2012-12-06 12:27VictorVillarModules => Core
2012-12-06 12:27VictorVillarOBNetwork customer => Yes
2012-12-06 12:27VictorVillarSupport ticket => 18139
2012-12-06 12:27VictorVillarResolution time => 1357167600
2012-12-06 12:27VictorVillarTriggers an Emergency Pack => No
2012-12-06 12:27VictorVillarIssue Monitored: networkb
2012-12-10 09:37dmiguelezAssigned Todmiguelez => jonalegriaesarte
2012-12-12 14:13hgbotCheckin
2012-12-12 14:13hgbotNote Added: 0054891
2012-12-12 14:13hgbotStatusnew => resolved
2012-12-12 14:13hgbotResolutionopen => fixed
2012-12-12 14:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c3ef43ecb754cb141bb84538c1b0aba0297f5f48 [^]
2012-12-17 13:34hudsonbotCheckin
2012-12-17 13:34hudsonbotNote Added: 0054994
2012-12-24 16:33VictorVillarNote Added: 0055181
2012-12-24 16:33VictorVillarStatusresolved => new
2012-12-24 16:33VictorVillarResolutionfixed => open
2013-01-09 11:26jonalegriaesarteTarget Version3.0MP19 => 3.0MP20
2013-01-10 10:25VictorVillarNote Edited: 0055181bug_revision_view_page.php?bugnote_id=0055181#r4254
2013-01-21 16:49jonalegriaesarteSeveritymajor => minor
2013-01-22 16:59hgbotCheckin
2013-01-22 16:59hgbotNote Added: 0055741
2013-01-22 16:59hgbotStatusnew => resolved
2013-01-22 16:59hgbotResolutionopen => fixed
2013-01-22 16:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/c3ef43ecb754cb141bb84538c1b0aba0297f5f48 [^] => http://code.openbravo.com/erp/devel/pi/rev/5c5c67b62ba45a46e43a2c609c2e7d7a755b567d [^]
2013-01-23 01:15hudsonbotCheckin
2013-01-23 01:15hudsonbotNote Added: 0055747
2013-01-31 16:39VictorVillarReview Assigned To => VictorVillar
2013-01-31 16:39VictorVillarNote Added: 0056020
2013-01-31 16:39VictorVillarStatusresolved => closed

Notes
(0054891)
hgbot   
2012-12-12 14:13   
Repository: erp/devel/pi
Changeset: c3ef43ecb754cb141bb84538c1b0aba0297f5f48
Author: Jon Alegría <jon.alegria <at> openbravo.com>
Date: Wed Dec 12 14:13:24 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c3ef43ecb754cb141bb84538c1b0aba0297f5f48 [^]

Fixes issue 0022472: NPE error launching the valued stock report

---
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
---
(0054994)
hudsonbot   
2012-12-17 13:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c79ef1b1f830 [^]

Maturity status: Test
(0055181)
VictorVillar   
2012-12-24 16:33   
(edited on: 2013-01-10 10:25)
is not completly solved because legalEntity is null due to * organization is not legal entity, check the following code. The fix purposed previously is not complete.

 Organization legalEntity = OBContext.getOBContext()
            .getOrganizationStructureProvider(wh.getClient().getId())
            .getLegalEntity(wh.getOrganization());
        data = ReportValuationStockData.select(this, vars.getLanguage(), strCurrencyId,
            legalEntity.getId(), DateTimeData.nDaysAfter(this, strDate, "1"), strWarehouse,
            strCategoryProduct);
(0055741)
hgbot   
2013-01-22 16:59   
Repository: erp/devel/pi
Changeset: 5c5c67b62ba45a46e43a2c609c2e7d7a755b567d
Author: Ioritz Cia <ioritz.cia <at> openbravo.com>
Date: Mon Jan 21 12:51:08 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5c5c67b62ba45a46e43a2c609c2e7d7a755b567d [^]

Fixes issue 22472: NPE error launching the valued stock report.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
---
(0055747)
hudsonbot   
2013-01-23 01:15   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8d2ab0cc2b3d [^]

Maturity status: Test
(0056020)
VictorVillar   
2013-01-31 16:39   
Verified