Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0022434 | Retail Modules | Web POS | public | 2012-11-30 09:44 | 2012-12-26 12:24 |
|
| Reporter | guilleaer | |
| Assigned To | guilleaer | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | RMP18 | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0022434: Arbitrary discounts needs two permissions to work |
| Description | If user wants to use arbitrary discounts, two preferences must be set to 'Y'
1.1 Web POS action Advanced Discounts
1.2 Web POS action Apply discount
This is wrong because both are different utitlities and shouldn't depend from each other. |
| Steps To Reproduce | 1. Login into ERP as system administrator
2. Check the value of preferences
1.1 Web POS action Advanced Discounts -> Y
1.2 Web POS action Apply discount -> N
3. Login in Web POS with a user without administrator privileges
(to make vallblanca user as not administrator, ERP -> user -> vallbalnca user -> check "manual")
4. The menu entry for ticket discounts is disabled -> correct not lines in the ticket
5. Add a product to the ticket
6. The menu entry for ticket discounts is disabled -> wrong
7. Change the value for the preference
7.1 Web POS action Apply discount -> Y
Repeat steps (from 2 -6). The menu entry should be enabled |
| Proposed Solution | Arbitrary discounts should work only with one permission. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  diff22434_arbitrarypermissions.diff (6,616) 2012-12-06 10:45
https://issues.openbravo.com/file_download.php?file_id=5792&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-11-30 09:44 | guilleaer | New Issue | |
| 2012-11-30 09:44 | guilleaer | Assigned To | => guilleaer |
| 2012-11-30 09:45 | guilleaer | Summary | Arbitrary discounts need two permissions to work fine => Arbitrary discounts needs two permissions to work |
| 2012-12-06 10:45 | guilleaer | File Added: diff22434_arbitrarypermissions.diff | |
| 2012-12-06 10:46 | guilleaer | Status | new => scheduled |
| 2012-12-06 10:46 | guilleaer | fix_in_branch | => pi |
| 2012-12-06 10:46 | guilleaer | Note Added: 0054743 | |
| 2012-12-06 10:47 | guilleaer | Target Version | => RMP18 |
| 2012-12-06 10:47 | guilleaer | fix_in_branch | pi => |
| 2012-12-17 12:27 | hgbot | Checkin | |
| 2012-12-17 12:27 | hgbot | Note Added: 0054975 | |
| 2012-12-17 12:27 | hgbot | Status | scheduled => resolved |
| 2012-12-17 12:27 | hgbot | Resolution | open => fixed |
| 2012-12-17 12:27 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/55605d17a250e9bb17cd5a0ddcb2fb8526a0d553 [^] |
| 2012-12-18 09:18 | hgbot | Checkin | |
| 2012-12-18 09:18 | hgbot | Note Added: 0055033 | |
| 2012-12-26 11:41 | migueldejuana | Note Added: 0055193 | |
| 2012-12-26 11:41 | migueldejuana | Status | resolved => closed |
| 2012-12-26 12:24 | hgbot | Checkin | |
| 2012-12-26 12:24 | hgbot | Note Added: 0055197 | |
|
Notes |
|
|
|
|
a fix has been attached to be included in RMP18 |
|
|
|
(0054975)
|
|
hgbot
|
|
2012-12-17 12:27
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 55605d17a250e9bb17cd5a0ddcb2fb8526a0d553
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Dec 17 12:24:05 2012 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/55605d17a250e9bb17cd5a0ddcb2fb8526a0d553 [^]
fixed issue 22434 -> arbitrary discounts doesn't need two differentes permission to work
---
M web/org.openbravo.retail.posterminal/js/components/keyboard.js
M web/org.openbravo.retail.posterminal/js/components/menu.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
|
|
|
|
(0055033)
|
|
hgbot
|
|
2012-12-18 09:18
|
|
|
|
|
|
|
Tested and reviewed in @4d2a5076522a |
|
|
|
(0055197)
|
|
hgbot
|
|
2012-12-26 12:24
|
|
|