Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022412Retail ModulesWeb POSpublic2012-11-28 09:542012-11-28 10:19
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRMP17Fixed in VersionRMP17 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022412: Fixed Percentage Discount is applied to just one unit in each line.
DescriptionFixed Percentage Discount is applied to just one product in each line.

If there are more than one product in that line, discount is applied just to the first one and not to the rest.

This is a regression introduced when implementing Discretionary Discounts
Steps To Reproduce-Create a Fixed Percentage Discount (10%) for product A (10€)
-Log in POS
-Add one product A -> 1€ is discounted -> OK
-Add 9 products A up to 10 -> 1€ is discounted -> FAIL, it should discount 10€
Proposed Solution
Additional Information
TagsRegression QA
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-11-28 09:54alostaleNew Issue
2012-11-28 09:54alostaleAssigned To => alostale
2012-11-28 09:56alostaleTag Attached: Regression QA
2012-11-28 10:00alostaleNote Added: 0054618
2012-11-28 10:02alostaleSummaryFixed Percentage Discount is applied to just one 1 in each line. => Fixed Percentage Discount is applied to just one unit in each line.
2012-11-28 10:02alostaleDescription Updatedbug_revision_view_page.php?rev_id=4101#r4101
2012-11-28 10:03hgbotCheckin
2012-11-28 10:03hgbotNote Added: 0054619
2012-11-28 10:03hgbotStatusnew => resolved
2012-11-28 10:03hgbotResolutionopen => fixed
2012-11-28 10:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/989788964fd80aaffc6640c19684c779f6a0df49 [^]
2012-11-28 10:19guilleaerNote Added: 0054622
2012-11-28 10:19guilleaerStatusresolved => closed
2012-11-28 10:19guilleaerFixed in Version => RMP17

Notes
(0054618)
alostale   
2012-11-28 10:00   
As this was introduced by Discretionary discounts, as additional test plan:

*Together with the discount defined in steps to reproduce, create a User Defined Amount
*Having 11 A products, apply a discount of 10€ not overwritting -> Expected result is:
  - 11 x A -> 110€
  - manual discount -10€
  - fixed % -10 €
  - Total 90€
(0054619)
hgbot   
2012-11-28 10:03   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 989788964fd80aaffc6640c19684c779f6a0df49
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Nov 28 10:02:19 2012 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/989788964fd80aaffc6640c19684c779f6a0df49 [^]

fixed bug 22412: Fixed Percentage Disc is applied to just 1 prod in each line

---
M web/org.openbravo.retail.discounts/js/promotion-discount.js
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---
(0054622)
guilleaer   
2012-11-28 10:19   
reviewed and tested