Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022403Openbravo ERP01. General setuppublic2012-11-27 16:502012-12-10 12:02
Reportervmromanos 
Assigned Tovmromanos 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS20OS VersionDebian 5.0
Product Version 
Target Version3.0MP18Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022403: Add support for Resource Category tree
DescriptionImportant note: This tree is related to coworking project, and it will work only with the modules inside this project. Right now it's impossible to insert new trees from external modules, that's why we must enter the tree in core although it's not going to be used by any core's component

Tree type = OBRE_RC
Steps To Reproduce@QA: Please contact me directly when closing the issue
Proposed SolutionCreate treeype OBRE_RC
Modify Initial Client Setup to support it
Create module script to add the tree to already created clients
Modify Tree related servlets
Additional Information
TagsCoworking
Relationships
related to defect 00224633.0MP18 closed eduardo_Argal Incremental build fails if client's name is longer than 50 chars 
related to defect 0027148 closed alostale Module org.openbravo.module.resources cannot be uninstalled 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-11-27 16:50vmromanosNew Issue
2012-11-27 16:50vmromanosAssigned To => vmromanos
2012-11-27 16:50vmromanosModules => Core
2012-11-27 16:51vmromanosStatusnew => scheduled
2012-11-27 16:51vmromanosfix_in_branch => pi
2012-11-28 10:14vmromanosNote Added: 0054621
2012-11-28 10:23hgbotCheckin
2012-11-28 10:23hgbotNote Added: 0054623
2012-11-28 11:24hgbotCheckin
2012-11-28 11:24hgbotNote Added: 0054626
2012-11-28 11:24hgbotStatusscheduled => resolved
2012-11-28 11:24hgbotResolutionopen => fixed
2012-11-28 11:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f3d9c1124d658adfadcb56d483da88771951807c [^]
2012-11-28 11:28vmromanosTag Attached: Coworking
2012-11-28 13:37hgbotCheckin
2012-11-28 13:37hgbotNote Added: 0054629
2012-11-28 13:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/f3d9c1124d658adfadcb56d483da88771951807c [^] => http://code.openbravo.com/erp/devel/pi/rev/0631f41f077e65071d9e3e1dd09c8795d65e6a01 [^]
2012-11-30 11:26hgbotCheckin
2012-11-30 11:26hgbotNote Added: 0054667
2012-11-30 11:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/0631f41f077e65071d9e3e1dd09c8795d65e6a01 [^] => http://code.openbravo.com/erp/devel/pi/rev/6cdbd62d56598383e5dcc07bdfc76ac34e9a4566 [^]
2012-12-01 01:03hudsonbotCheckin
2012-12-01 01:03hudsonbotNote Added: 0054681
2012-12-01 01:03hudsonbotCheckin
2012-12-01 01:03hudsonbotNote Added: 0054682
2012-12-01 01:03hudsonbotCheckin
2012-12-01 01:03hudsonbotNote Added: 0054689
2012-12-05 11:00hgbotCheckin
2012-12-05 11:00hgbotNote Added: 0054723
2012-12-05 11:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/6cdbd62d56598383e5dcc07bdfc76ac34e9a4566 [^] => http://code.openbravo.com/erp/devel/pi/rev/8c06c502c2b6568162dad1fa9e16fd2f65304669 [^]
2012-12-05 13:29plujanRelationship addedrelated to 0022463
2012-12-06 15:12hudsonbotCheckin
2012-12-06 15:12hudsonbotNote Added: 0054754
2012-12-10 12:02SandrahuguetNote Added: 0054793
2012-12-10 12:02SandrahuguetStatusresolved => closed
2014-07-22 11:34shuehnerRelationship addedrelated to 0027148

Notes
(0054621)
vmromanos   
2012-11-28 10:14   
There is no functionality to review, only to ensure the change doesn't break anything in core

Test plan (core related):
1. Update from MP17 (or older) to PI (including this change)
2. Ensure no warnings/errors during the update process
3. Run: select AD_TREE_OBRE_RESOURCE_CATEGORY from ad_clientinfo where ad_client_id<>'0'
4. Ensure the column contains data
5. As system admin, run an Initial Client Setup
6. Run: select AD_TREE_OBRE_RESOURCE_CATEGORY from ad_clientinfo where ad_client_id<>'0'
7. Ensure the column contains data
8. Run ant smartbuild -Dlocal=no
9. Ensure no warning/errors during the process
10. Run: select AD_TREE_OBRE_RESOURCE_CATEGORY from ad_clientinfo where ad_client_id<>'0'
11. Ensure the column contains data
(0054623)
hgbot   
2012-11-28 10:23   
Repository: erp/pmods/org.openbravo.module.resources
Changeset: 19e347ee445ce433042e14fcd7aefb3727d8ade5
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Nov 28 10:22:46 2012 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/19e347ee445ce433042e14fcd7aefb3727d8ade5 [^]

Issue 22403: Add support for Resource Category tree
Module stuff
Added FK in AD_ClientInfo table
Added trigger to control the tree when inserting/deleting resource categories
Defined the tab as has tree

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TABLE.xml
A src-db/database/model/modifiedTables/AD_CLIENTINFO.xml
A src-db/database/model/triggers/OBRE_RESOURCE_CATEGORY_TRG.xml
---
(0054626)
hgbot   
2012-11-28 11:24   
Repository: erp/devel/pi
Changeset: f3d9c1124d658adfadcb56d483da88771951807c
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Nov 28 10:19:02 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f3d9c1124d658adfadcb56d483da88771951807c [^]

Fixed bug 22403: Add support for Resource Category tree
Changes related to core:
Added column to AD_ClientInfo
Modified UpdateADClientInfo module script to create the resource category tree for already created clients
Modified Tree related servlets to support the new tree
Included new definition for OBRE_RC tree

---
M src-db/database/model/tables/AD_CLIENTINFO.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateADClientInfo.class
M src-util/modulescript/src/org/openbravo/modulescript/UpdateADClientInfo.java
M src/org/openbravo/erpCommon/businessUtility/InitialClientSetup.java
M src/org/openbravo/erpCommon/utility/WindowTreeChecks.java
M src/org/openbravo/erpCommon/utility/WindowTreeUtility.java
M src/org/openbravo/erpCommon/utility/WindowTree_data.xsql
---
(0054629)
hgbot   
2012-11-28 13:37   
Repository: erp/devel/pi
Changeset: 0631f41f077e65071d9e3e1dd09c8795d65e6a01
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Nov 28 13:36:54 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0631f41f077e65071d9e3e1dd09c8795d65e6a01 [^]

Fixed bug 22403: added substr to safely insert the new record

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateADClientInfoData.class
M src-util/modulescript/src/org/openbravo/modulescript/UpdateADClientInfo_data.xsql
---
(0054667)
hgbot   
2012-11-30 11:26   
Repository: erp/devel/pi
Changeset: 6cdbd62d56598383e5dcc07bdfc76ac34e9a4566
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Nov 30 11:25:24 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6cdbd62d56598383e5dcc07bdfc76ac34e9a4566 [^]

Fixed bug 22403: added missed FK in AD_ClientInfo

---
M src-db/database/model/tables/AD_CLIENTINFO.xml
---
(0054681)
hudsonbot   
2012-12-01 01:03   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4cc8305859aa [^]

Maturity status: Test
(0054682)
hudsonbot   
2012-12-01 01:03   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4cc8305859aa [^]

Maturity status: Test
(0054689)
hudsonbot   
2012-12-01 01:03   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4cc8305859aa [^]

Maturity status: Test
(0054723)
hgbot   
2012-12-05 11:00   
Repository: erp/devel/pi
Changeset: 8c06c502c2b6568162dad1fa9e16fd2f65304669
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Dec 05 10:54:26 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8c06c502c2b6568162dad1fa9e16fd2f65304669 [^]

Fixed bug 22403: Tree not properly updated

---
M src/org/openbravo/erpCommon/utility/WindowTreeUtility.java
M src/org/openbravo/erpCommon/utility/WindowTree_data.xsql
---
(0054754)
hudsonbot   
2012-12-06 15:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d438f7014f16 [^]

Maturity status: Test
(0054793)
Sandrahuguet   
2012-12-10 12:02   
Code review + testing OK