Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0022389Openbravo ERP07. Sales managementpublic2012-11-23 14:232012-11-26 17:28
jvazquez 
naiaramartinez 
urgentmajoralways
closedfixed 
5
 
 
psarobe
Core
No
0022389: Incorrect address for tax calculation converting quotation into order
Same address is given twice for tax calculation while converting quotation into order. Wrong code is found in line 124:

String strCTaxID = Tax.get(new DalConnectionProvider(false), ordLine.getProduct().getId(),
dateFormat.format(new Date()),
ordLine.getOrganization().getId(),
ordLine.getWarehouse().getId(), ordLine.getSalesOrder().getInvoiceAddress().getId(),
ordLine.getSalesOrder().getInvoiceAddress().getId(),
strProjectID,
true);
N/A
Use delivery location and invoice address from the order.
No tags attached.
Issue History
2012-11-23 14:23jvazquezNew Issue
2012-11-23 14:23jvazquezAssigned To => dmiguelez
2012-11-23 14:23jvazquezModules => Core
2012-11-23 14:28psarobeSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=4091#r4091
2012-11-26 09:20psarobeAssigned Todmiguelez => naiaramartinez
2012-11-26 09:20psarobeStatusnew => scheduled
2012-11-26 10:07hgbotCheckin
2012-11-26 10:07hgbotNote Added: 0054492
2012-11-26 10:07hgbotStatusscheduled => resolved
2012-11-26 10:07hgbotResolutionopen => fixed
2012-11-26 10:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1e53338fbfe72e8632f5b650b57efa4998ebe86c [^]
2012-11-26 10:24psarobeReview Assigned To => psarobe
2012-11-26 10:24psarobeNote Added: 0054494
2012-11-26 10:24psarobeStatusresolved => closed
2012-11-26 17:28hudsonbotCheckin
2012-11-26 17:28hudsonbotNote Added: 0054500

Notes
(0054492)
hgbot   
2012-11-26 10:07   
Repository: erp/devel/pi
Changeset: 1e53338fbfe72e8632f5b650b57efa4998ebe86c
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Mon Nov 26 10:05:37 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1e53338fbfe72e8632f5b650b57efa4998ebe86c [^]

fixed bug 22389: Incorrect address for tax calculation converting quotation into order

---
M src/org/openbravo/erpCommon/ad_process/ConvertQuotationIntoOrder.java
---
(0054494)
psarobe   
2012-11-26 10:24   
Closed doing code review
(0054500)
hudsonbot   
2012-11-26 17:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2fe023f3ce44 [^]

Maturity status: Test