Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022339Openbravo ERPZ. Otherspublic2012-11-19 09:572013-01-18 09:34
ReporterioritzCia 
Assigned ToioritzCia 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 10.04
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022339: Fix to issue 21886 causes an api change.
DescriptionDue to this issue:

https://issues.openbravo.com/view.php?id=21886 [^]

I have to make an api-change. This is the change:

http://pastebin.com/CpshXksC [^]

Due to this issue https://issues.openbravo.com/view.php?id=22176 [^] api change does not detect the change, so I cannot paste the failure.

- The change is the following:
M_PRODUCT_PO.VENDORPRODUCTNO column goes from not nullable to nullable.

- The change is required due to the following reason:
This column is in a unique constraint that needs to be removed due to 21886 issue. The unique constraint is that each product needs to have one unique vendorproductno for each business partner and this is not right, because two partners may have the same vendortproductno for the same product.

- The risk is low:
Someone may have made a development assuming this field would never be null. If that development did not have the null check and now that column is allowed to be null, it would cause an exception. Anyway these should not be very likely.
Steps To ReproduceNone.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 00218863.0MP18 closed jecharri Restrictions in M_PRODUCT_PO can not be enforced 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-11-19 09:57ioritzCiaNew Issue
2012-11-19 09:57ioritzCiaAssigned To => dmiguelez
2012-11-19 09:57ioritzCiaWeb browser => Google Chrome
2012-11-19 09:57ioritzCiaModules => Core
2012-11-19 09:57ioritzCiaWeb browserGoogle Chrome => Google Chrome
2012-11-19 09:57ioritzCiaAssigned Todmiguelez => iciordia
2012-11-19 09:57ioritzCiaStatusnew => feedback
2012-11-19 11:32iciordiaNote Added: 0054302
2012-11-19 11:32iciordiaAssigned Toiciordia => ioritzCia
2012-11-19 11:32iciordiaStatusfeedback => scheduled
2012-11-19 11:32iciordiafix_in_branch => pi
2012-11-19 13:23ioritzCiaRelationship addeddepends on 0021886
2012-11-19 13:36ioritzCiaNote Added: 0054313
2012-11-19 13:36ioritzCiaStatusscheduled => resolved
2012-11-19 13:36ioritzCiaFixed in SCM revision => 751258826d60
2012-11-19 13:36ioritzCiaResolutionopen => fixed
2013-01-18 09:34ioritzCiaStatusresolved => closed

Notes
(0054302)
iciordia   
2012-11-19 11:31   
Approved.

Ismael
(0054313)
ioritzCia   
2012-11-19 13:36   
No change fixes this API-Change. As said in the description, due to issue 21176 this will not fail in the tests. The SCM revision was set to the original issue's fix as the field is mandatory.