0022286: Remove view user_objects (again) as it is unused and is causing trouble when upgrading from pgsql8.4 to >= pgsql9

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0022286

Openbravo ERP

A. Platform

public

2012-11-13 14:53

2012-11-21 06:06

Reporter

shuehner

Assigned To

AugustoMauch

Priority

urgent

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.0MP17

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0022286: Remove view user_objects (again) as it is unused and is causing trouble when upgrading from pgsql8.4 to >= pgsql9

Description

The view user_objects exists as a system view on oracle and is created in the prescript on postgresql.

That view is no longer used since some time by any code in pi. The last user was the old implementation of delete-client which was removed from pi on 2011-09-27.

In issue 14642 that view was made compatible with PostgreSQL >= 9.0 which was needed as some internal postgres detail needed by that view changed between 8.4 and 9.1

That made the ERP already install fine on postgresql >9.0

However when doing a pg_dump of the database on pgsql8.4 and trying to import that dump on pgsql >= 9.0 an error is still raised as that view with the 8.4 definition cannot be imported into a 9.1 server.

As the view is no longer needed it should just be removed to allow easier upgrade to pgsql9.1 without showing any harmless but ugly error messages which will confuse users.

Note the same (deleting the view) was already tried in issue 14642 first, but back then needed to be backed out as the old delete client code still used that view, however that is no longer the case for over a year now, so that blocker does not apply.

Steps To Reproduce

run install.source on top of pgsql8.4
run a pg_dump -Fc of that database
run pg_restore of that dump against a pgsql9.1 server
Notice that the user_objects view fails to be created and an error message about this is shown.

Proposed Solution

Delete the user_object view completely.

Additional Information