0022235: OBMessageUtils asumes incorrectly that RequestContext is set

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0022235

Openbravo ERP

A. Platform

public

2012-11-08 11:19

2013-01-03 13:12

Reporter

caristu

Assigned To

mtaal

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

3.0MP19

Fixed in Version

3.0MP19

Merge Request Status

Review Assigned To

AugustoMauch

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0022235: OBMessageUtils asumes incorrectly that RequestContext is set

Description

If you extend a class from DalProcess and you call call RequestContext.get().getVariablesSecureApp(); it returns null.

So for example, if you use any of the public methods of OBMessageUtils() that uses the previous statement, the process crashes because we are obtaining a null reference. For example, the translateError() method is using this practise:

public static OBError translateError(String message) {
VariablesSecureApp vars = RequestContext.get().getVariablesSecureApp();
final String strLanguage = OBContext.getOBContext().getLanguage().getLanguage();
return translateError(new DalConnectionProvider(false), vars, strLanguage, message);
}

So, we can't use this approach, instead we must use the ProcessBudle class to obtain the vars variable: bundle.getContext().toVars();

Steps To Reproduce

- Create a new process extending DalBaseProcess class
- Try to use any of the methods of OBMessageUtils() that uses RequestContext(), for example the translateError() method

Proposed Solution

The current implementation of OBMessageUtils incorrectly uses the RequestContext, assuming that it is always set. Proposed Solutions:

- deprecate this OBMessageUtils method or remove it (api change)
- add an abstraction for RequestContext that only provides the things common to process threads and http request threads (like VariablesSecureApp) and then use this ThreadContext object in all the places in core where RequestContext is being used.

Additional Information