Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022183Retail ModulesWeb POSpublic2012-10-31 11:542018-07-24 12:00
Reporterjmon 
Assigned Torqueralta 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022183: Cash Up process and report are not ordering the payment methods correctly
DescriptionThe different payment methods when being shown in steps 2 and 4 of the cash up process and in the printed report do not fulfill the Line No order used when setting up the payment types in the POS terminal window.
This should also be checked in the Cash Management Report.
Steps To ReproduceAssign several payment types to a POS terminal using field Order No field.
Go to WebPOS and log orders and payments using different payment methods
Run the Cash up process
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0023461 closed mario_castello When i reopen the receipt, at payment breakdown details shows in reverse order 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-10-31 11:54jmonNew Issue
2012-10-31 11:54jmonAssigned To => adrianromero
2012-10-31 12:35adrianromeroOBNetwork customer => No
2012-10-31 12:35adrianromeroNote Added: 0053914
2012-10-31 12:35adrianromeroPriorityimmediate => normal
2012-10-31 12:35adrianromeroSeveritycritical => minor
2012-11-09 12:46alostaleStatusnew => scheduled
2012-11-09 12:46alostaleAssigned Toadrianromero => migueldejuana
2012-11-09 12:46alostalefix_in_branch => pi
2014-03-25 16:45malsasuaRelationship addedrelated to 0023461
2017-01-24 15:35rqueraltaAssigned Tomigueldejuana => rqueralta
2017-02-13 20:02hgbotCheckin
2017-02-13 20:02hgbotNote Added: 0094287
2017-02-13 20:02hgbotStatusscheduled => resolved
2017-02-13 20:02hgbotResolutionopen => fixed
2017-02-13 20:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7b87938ff435449e0dd7049e621cd4ec801d4573 [^]
2017-02-13 20:14rqueraltaNote Added: 0094289
2017-03-14 09:29marvintmNote Added: 0094994
2017-03-14 09:29marvintmStatusresolved => new
2017-03-14 09:29marvintmResolutionfixed => open
2017-04-10 16:31hgbotCheckin
2017-04-10 16:31hgbotNote Added: 0095948
2018-07-24 11:59guilleaerStatusnew => scheduled
2018-07-24 12:00guilleaerStatusscheduled => resolved
2018-07-24 12:00guilleaerFixed in Version => RR17Q3
2018-07-24 12:00guilleaerResolutionopen => fixed
2018-07-24 12:00guilleaerReview Assigned To => guilleaer
2018-07-24 12:00guilleaerStatusresolved => closed

Notes
(0053914)
adrianromero   
2012-10-31 12:35   
Adjusting the severity according bug reporting guidelines: http://wiki.openbravo.com/wiki/Bug_Reporting_Guidelines#How_to_Choose_the_Right_Severity [^]
(0094287)
hgbot   
2017-02-13 20:02   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7b87938ff435449e0dd7049e621cd4ec801d4573
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Wed Jan 18 18:31:19 2017 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7b87938ff435449e0dd7049e621cd4ec801d4573 [^]

Fixed issue 22183: Cash Up process and report are not ordering the P. Methods

Order clause into PaymentMethodCashUp model was removed to retrieved Payments
Methods using Line No. field

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
---
(0094289)
rqueralta   
2017-02-13 20:14   
Test plan:

As The White Valley Group Admin - The White Valley Group

  - Go to POS Terminal window
    Select terminal "VBS-1"
  - Go to Payment Type tba
    Assing to the all payments type an unordered Line No. value
  - Go to WebPOS and log orders and payments using different payment methods
  - Run the Cash up processnal
  - Check that the different payment methods are sorted according to the assigned line number, when being shown in steps 2 and 4
(0094994)
marvintm   
2017-03-14 09:29   
Removing the explicit order by statement is fine if you want to rely on the automatic ordering by _idx column. However, in this case, the paymentmethodcashup records do not have value in the idx property.

You should either ensure that when they are created they receive a proper value for the _idx column, or you should order by some other column explicitly to guarantee that the order will be consistent and correct in all cases.
(0095948)
hgbot   
2017-04-10 16:31   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 741c14452bce22b9e069e9a702707c793e6c8c8c
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Wed Apr 05 10:56:53 2017 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/741c14452bce22b9e069e9a702707c793e6c8c8c [^]

Related to issue 22183: Cash Up process and report are not ordering the P. Methods

Order clause into PaymentMethodCashUp model was changed to retrieved Payments
Methods using Line No. field

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
M web/org.openbravo.retail.posterminal/js/model/paymentmethodcashup.js
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---