Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022176Openbravo ERPA. Platformpublic2012-10-31 09:192013-08-20 11:50
Reporterjecharri 
Assigned ToAugustoMauch 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP27 
Merge Request Status
Review Assigned Todbaz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022176: API test does not detect one API change
DescriptionAPI test does not detect one API change
Steps To Reproduce-Go to the database and erase not null restriction from column in the database.
-You will see that the api tes does not detect the API change.

The problem is that, this column previously had always a value, so it could be that somebody has created a development thinking that this column always is going to have a value
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff issue22176.diff (822) 2013-07-31 13:02
https://issues.openbravo.com/file_download.php?file_id=6304&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-10-31 09:19jecharriNew Issue
2012-10-31 09:19jecharriAssigned To => AugustoMauch
2012-10-31 09:19jecharriModules => Core
2012-10-31 09:20jecharriSummaryAPI tes does not detect one API change => API test does not detect one API change
2012-10-31 09:20jecharriDescription Updatedbug_revision_view_page.php?rev_id=4030#r4030
2013-06-03 13:39shuehnerIssue Monitored: shuehner
2013-07-31 13:02AugustoMauchFile Added: issue22176.diff
2013-07-31 13:03AugustoMauchNote Added: 0060408
2013-07-31 13:03AugustoMauchStatusnew => scheduled
2013-07-31 13:03AugustoMauchfix_in_branch => pi
2013-08-16 13:10hgbotCheckin
2013-08-16 13:10hgbotNote Added: 0060604
2013-08-16 13:21hgbotCheckin
2013-08-16 13:21hgbotNote Added: 0060606
2013-08-16 13:21hgbotStatusscheduled => resolved
2013-08-16 13:21hgbotResolutionopen => fixed
2013-08-16 13:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c76f162b7ab00fa04fafe7d1fa5051133a019a4e [^]
2013-08-16 14:26AugustoMauchReview Assigned To => dbaz
2013-08-20 01:26hudsonbotCheckin
2013-08-20 01:26hudsonbotNote Added: 0060663
2013-08-20 11:50dbazStatusresolved => closed
2013-08-20 11:50dbazFixed in Version => 3.0MP27

Notes
(0060408)
AugustoMauch   
2013-07-31 13:03   
A patch has been attached. It will be pushed to pi once it is unfrozen for MP27 issues.
(0060604)
hgbot   
2013-08-16 13:10   
Repository: erp/devel/dbsm-main
Changeset: 44108fed25e02321fb8feff9da10364bd7284de4
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Aug 16 13:10:14 2013 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/44108fed25e02321fb8feff9da10364bd7284de4 [^]

Related to issue 22176: Detect removal of not null restrictions

The API check should detect the removal of a column not null restriction. If a column was not null someone could have taken for granted that that column was always going to have a not null value. After removing the not null restriction that column can now store null values, that could break the code that assumed that the column was going to store not null values.

---
M src/org/openbravo/ddlutils/util/ValidateAPIModel.java
---
(0060606)
hgbot   
2013-08-16 13:21   
Repository: erp/devel/pi
Changeset: c76f162b7ab00fa04fafe7d1fa5051133a019a4e
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Aug 16 13:21:17 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c76f162b7ab00fa04fafe7d1fa5051133a019a4e [^]

Fixed 22176. Fixed 22669. Improve api-check
- Ignore ad_process_para insertions for new added processes as those
  are false positives.
- Report dropping of a not null constraint as api-check as existing
  code may rely on the column having a value.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0060663)
hudsonbot   
2013-08-20 01:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/28c60a43e596 [^]

Maturity status: Test