Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022141Openbravo ERPA. Platformpublic2012-10-29 16:492012-11-01 23:08
Reporterplujan 
Assigned Tomtaal 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0MP17 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browserGoogle Chrome, Mozilla Firefox
ModulesCore
Support ticket
Regression levelAutomated tests
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022141: When creating a Payment Proposal I see no Payments
DescriptionIf I create a new Payment Proposal I cannot select Payments since the pop up shows no records. However, if I close and reopen the window, the Payments are displayed as expected.
Steps To Reproduce1. Create a Purchase Invoice (optional step, required to ensure there is a record to be displayed in the Payments):

Login with QAAdmin
Go to Purchase invoice
Click new in form and fill:
"Transaction Document": AP Invoice
"Business partner": Vendor A
Move to lines tab and click new
Enter the details for the product typing RMA and change the Invoice quantity to 11.2
Click the complete button and click OK.

2. Create the Payment Proposal (required step)
Go to Payment proposal window
Click New in Form and select the following values:
"Payment method": 1 (Spain)
"Paying From": EUR - Spain Cashbook
"Due Date": Current system date + 90 days
Click "Select Expected Payments" button.
The invoice created in previous step should be displayed. However, no data is shown. See attach.

3. Verify behaviour (optional step)
Close the Select Payment popup
Close the Form for created Payment Proposal
In grid view, open again in form the recently closed Payment Proposal
Click "Select Expected Payments" button.
The invoice now is displayed as expected.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng paymentsShouldBeGeneratedFromPaymentProposal.png (64,620) 2012-10-29 16:49
https://issues.openbravo.com/file_download.php?file_id=5691&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-10-29 16:49plujanNew Issue
2012-10-29 16:49plujanAssigned To => dmiguelez
2012-10-29 16:49plujanFile Added: paymentsShouldBeGeneratedFromPaymentProposal.png
2012-10-29 16:49plujanWeb browser => Google Chrome, Mozilla Firefox
2012-10-29 16:49plujanModules => Core
2012-10-29 16:50plujanWeb browserGoogle Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox
2012-10-29 16:50plujanRegression level => Automated tests
2012-10-29 17:24plujanWeb browserGoogle Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox
2012-10-29 17:24plujanAssigned Todmiguelez => mtaal
2012-10-29 17:24plujanCategory09. Financial management => A. Platform
2012-10-30 17:02mtaalReview Assigned To => AugustoMauch
2012-10-30 17:02mtaalWeb browserGoogle Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox
2012-10-30 17:02mtaalNote Added: 0053842
2012-10-30 17:03hgbotCheckin
2012-10-30 17:03hgbotNote Added: 0053843
2012-10-30 17:03hgbotStatusnew => resolved
2012-10-30 17:03hgbotResolutionopen => fixed
2012-10-30 17:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/45ed1bb445090af1f1f7c0fdcce1df2153210946 [^]
2012-10-31 13:31hudsonbotCheckin
2012-10-31 13:31hudsonbotNote Added: 0053942
2012-11-01 23:08AugustoMauchNote Added: 0053964
2012-11-01 23:08AugustoMauchStatusresolved => closed
2012-11-01 23:08AugustoMauchFixed in Version => 3.0MP17

Notes
(0053842)
mtaal   
2012-10-30 17:02   
The problem is that the business partner filter is send to the client as null, on the server then the query uses the "null" value to filter as a string. This is now prevented by capturing the case that the server receives a null value as a string.
(0053843)
hgbot   
2012-10-30 17:03   
Repository: erp/devel/pi
Changeset: 45ed1bb445090af1f1f7c0fdcce1df2153210946
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Oct 30 17:02:55 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/45ed1bb445090af1f1f7c0fdcce1df2153210946 [^]

Fixes issue 22141: When creating a Payment Proposal I see no Payments
Translate "null" to a real null

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
M src/org/openbravo/service/dataset/DataSetService.java
---
(0053942)
hudsonbot   
2012-10-31 13:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9e773cbcb723 [^]

Maturity status: Test
(0053964)
AugustoMauch   
2012-11-01 23:08   
Code reviewed and verified in pi@84881ccb60f5