Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0022131 | Openbravo ERP | 01. General setup | public | 2012-10-29 11:18 | 2012-11-20 20:53 |
|
| Reporter | caristu | |
| Assigned To | shankarb | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | 3.0MP18 | Fixed in Version | 3.0MP18 | |
| Merge Request Status | |
| Review Assigned To | dbaz |
| OBNetwork customer | OBPS |
| Web browser | |
| Modules | Core |
| Support ticket | 17688 |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0022131: AD_Tab_Access for inactive tabs is causing javascript errors |
| Description | If we mark as inactive a tab that is included in the tab_access for a particular role causes the following error when accessing to the window that includes the tab: "Cannot read property 'viewForm' of null"
In same cases this error prohibits the access to the window when accessing a second time. |
| Steps To Reproduce | - As group admin role, go to the [Role] window
- Create a record in [Window Access] tab for an specific role (i.e Sales Role) and for an specific window (i.e Business Partner).
- Add a record in [Tab Access] window for any tab in Business Partner Window (i.e Customer)
- Go as a System Administrator and set Active = 'N' for the tab Customer in Business Partner Window.
- Log in as Sales Role and navigate to the Business Partner Window. The following javascript error is thrown (use Google Chrome Developer Tools): "Uncaught TypeError: Cannot read property 'viewForm' of null " |
| Proposed Solution | This error is caused in the following line of the ob-standard-window.js file:
for (i = 0; i < view.viewForm.getFields().length; i++) {
view in null, because we are assigning its value with the following statement:
view = this.getView(tab.tabId);
we can't get the tab view because is set as inactive.
This problem is solved if we just add a condition to check if view is null before accesing to its fields:
if (view != null){
for (i = 0; i < view.viewForm.getFields().length; i++) {
....
} |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  FixIssue22131.diff (4,550) 2012-11-08 14:34
https://issues.openbravo.com/file_download.php?file_id=5716&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-10-29 11:18 | caristu | New Issue | |
| 2012-10-29 11:18 | caristu | Assigned To | => dmiguelez |
| 2012-10-29 11:18 | caristu | Modules | => Core |
| 2012-10-29 11:18 | caristu | OBNetwork customer | => Yes |
| 2012-10-29 11:18 | caristu | Support ticket | => 17688 |
| 2012-10-29 11:18 | caristu | Resolution time | => 1354230000 |
| 2012-10-29 11:18 | caristu | Issue Monitored: networkb | |
| 2012-10-29 11:23 | dmiguelez | Assigned To | dmiguelez => jonalegriaesarte |
| 2012-10-29 11:46 | jonalegriaesarte | Assigned To | jonalegriaesarte => AugustoMauch |
| 2012-11-08 11:15 | shankarb | Assigned To | AugustoMauch => shankarb |
| 2012-11-08 14:34 | shankarb | File Added: FixIssue22131.diff | |
| 2012-11-12 15:58 | shankarb | Review Assigned To | => dbaz |
| 2012-11-12 15:58 | shankarb | Issue Monitored: dbaz | |
| 2012-11-12 15:59 | shankarb | Status | new => scheduled |
| 2012-11-12 15:59 | shankarb | fix_in_branch | => pi |
| 2012-11-12 15:59 | shankarb | Status | scheduled => resolved |
| 2012-11-12 15:59 | shankarb | Fixed in Version | => pi |
| 2012-11-12 15:59 | shankarb | Fixed in SCM revision | => https://code.openbravo.com/erp/devel/pi/rev/13c3d71a21b2 [^] |
| 2012-11-12 15:59 | shankarb | Resolution | open => fixed |
| 2012-11-20 20:53 | dbaz | Note Added: 0054353 | |
| 2012-11-20 20:53 | dbaz | Status | resolved => closed |
| 2012-11-20 20:53 | dbaz | Fixed in Version | pi => 3.0MP18 |