Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022083Openbravo ERP00. Application dictionarypublic2012-10-24 10:182012-11-02 13:46
Reportermirurita 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Versionpi 
Target VersionFixed in Version3.0MP17 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022083: Computed columns should work also with non primitive references (table, tabledir, search, OBUISEL_Selector Reference...)
DescriptionComputed columns should work also with non primitive references (table, tabledir, search, OBUISEL_Selector Reference...)
Steps To Reproduce1) Create a new column on c_invoice table
 - Column name: TestComputedColumn
 - SQLLogic:
(select max(il.c_invoiceline_id) from c_invoiceline il where il.c_invoice_id = c_invoice_id)
 - Reference: Table
 - Reference Search Key: Project Selector

2) Create corresponding field for previous column on Sales Invoice >> Header tab.

3) Compile a go to this window.

You will get an error: Could not execute query
it is trying to select c_invoice.TestComputedColumn column in database when it does not exist.
Proposed SolutionIt is possible to use the formula property also for many-to-one references in the hibernate mapping file.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-10-24 10:18miruritaNew Issue
2012-10-24 10:18miruritaAssigned To => mtaal
2012-10-24 10:18miruritaModules => Core
2012-10-24 22:46mtaalReview Assigned To => AugustoMauch
2012-10-24 22:46mtaalProposed Solution updated
2012-10-24 22:54hgbotCheckin
2012-10-24 22:54hgbotNote Added: 0053667
2012-10-24 22:54hgbotStatusnew => resolved
2012-10-24 22:54hgbotResolutionopen => fixed
2012-10-24 22:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ca38f3f7ec3b9f485182fb5350bbf099b50757c5 [^]
2012-10-25 12:39hudsonbotCheckin
2012-10-25 12:39hudsonbotNote Added: 0053711
2012-10-30 14:33AugustoMauchNote Added: 0053826
2012-10-30 14:33AugustoMauchStatusresolved => new
2012-10-30 14:33AugustoMauchResolutionfixed => open
2012-10-30 17:29hgbotCheckin
2012-10-30 17:29hgbotNote Added: 0053844
2012-10-30 17:29hgbotStatusnew => resolved
2012-10-30 17:29hgbotResolutionopen => fixed
2012-10-30 17:29hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/ca38f3f7ec3b9f485182fb5350bbf099b50757c5 [^] => http://code.openbravo.com/erp/devel/pi/rev/b1a3f1b424e0a6cc755b358dddd0fd1278ce41ad [^]
2012-10-31 13:31hudsonbotCheckin
2012-10-31 13:31hudsonbotNote Added: 0053943
2012-11-02 13:46AugustoMauchNote Added: 0053983
2012-11-02 13:46AugustoMauchStatusresolved => closed
2012-11-02 13:46AugustoMauchFixed in Version => 3.0MP17

Notes
(0053667)
hgbot   
2012-10-24 22:54   
Repository: erp/devel/pi
Changeset: ca38f3f7ec3b9f485182fb5350bbf099b50757c5
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Oct 24 22:53:37 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ca38f3f7ec3b9f485182fb5350bbf099b50757c5 [^]

Fixes issue 22083: Computed columns should work also with non primitive references
Property formula is also supported for many-to-one

---
M src/org/openbravo/dal/core/DalMappingGenerator.java
---
(0053711)
hudsonbot   
2012-10-25 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4a27e27689bc [^]

Maturity status: Test
(0053826)
AugustoMauch   
2012-10-30 14:33   
The compilation fails after creating the column and the field the way it is described in the steps to reproduce.
(0053844)
hgbot   
2012-10-30 17:29   
Repository: erp/devel/pi
Changeset: b1a3f1b424e0a6cc755b358dddd0fd1278ce41ad
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Oct 30 17:28:35 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b1a3f1b424e0a6cc755b358dddd0fd1278ce41ad [^]

Fixes issue 22083: Computed columns should work also with non primitive references
Prevent a virtual/list property for properties which have sql logic

---
M src/org/openbravo/base/model/ModelProvider.java
---
(0053943)
hudsonbot   
2012-10-31 13:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9e773cbcb723 [^]

Maturity status: Test
(0053983)
AugustoMauch   
2012-11-02 13:46   
Code reviewed and verified in pi@37da9a5ba373