Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002205Openbravo ERPA. Platformpublic2007-10-30 22:322008-07-03 18:03
Reportervillind 
Assigned Torafaroda 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version2.40beta 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0002205: Versioned files are modified during the setup process
DescriptionFiles that are versioned in the SVN are modified during the setup process. There is risk that someone accidentally checks in these changes into the SVN. Many on the files (log, jar, class) should not be in the source control in the first place, and database/build.xml should just read configuration and not to be altered.

How to reproduce:

svn co <path>
ant -f build.xml.template setup
svn st -q


All files that are modified (M) should be fixed either by removing from source control and adding them to the ignore list or then the file should not be modified.

Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0003514 closed rafaroda Versioned files are modified during the setup 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-07-03 18:03plujanStatusresolved => closed
2008-07-03 18:03plujanFixed in Version2.40alpha-r2 => 2.40beta

Notes
(0005794)
user71   
2005-06-01 00:00   
(edited on: 2008-06-12 09:43)
This bug was originally reported in SourceForge bug tracker and then migrated to Mantis.

You can see the original bug report in:
https://sourceforge.net/support/tracker.php?aid=1823050 [^]
(0002551)
villind   
2007-11-19 12:45   
(edited on: 2008-06-12 09:22)
Logged In: YES
user_id=61737
Originator: YES


One more file which is versioned and modified during the build: database/lib/dbmanager.jar

This should be excluded or the dbmanager build should not be part of the openbravo build.
(0002552)
rafaroda   
2007-11-21 10:41   
(edited on: 2008-06-12 09:22)
Logged In: YES
user_id=1892190
Originator: NO

Hi Villind,

You are totally right. The rule must be:
* Files that are 'versioned' in SVN repository (i.e., files that can be both checked out and commited), should never be modified during installation and setup process.
Or, said in another way:
* Files created during installation and setup process, generated by compilation, should never be included in SVN repository.

We've identified the following files that have to be deleted from SVN repository and add to the ignore list:
setup/ant.install.log; setup/setup.jar; database/lib/dbmanager.jar

We would be very grateful if you could indicate us any other file in the same situation.

Concerning 'database/lib/dbmanager.jar' you're also right. By the moment, as 'dbmanager.jar' file isn't mature enough, it is built each time 'database.lib' is run. But this file will be excluded from the build process once it is stable.

Thank you very much for your feedback,

Rafa Roda Palacios
Openbravo engineering team
(0002553)
rafaroda   
2007-11-21 14:48   
(edited on: 2008-06-12 09:22)
Logged In: YES
user_id=1892190
Originator: NO

Deleted 'database/lib/dbmanager.jar' file from SVN repository and added it to SVN ignore list ('setup/ant.install.log' and 'setup/setup.jar' no longer exist).