Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022007Openbravo ERPA. Platformpublic2012-10-19 10:052012-11-27 11:42
Reporterjecharri 
Assigned Toshankarb 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP18Fixed in Version3.0MP18 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022007: Selectors are not working if you check one column as identifier and has not got value
DescriptionSelectors are not working if you check one column as identifier and has not got value.

The column must be a foreign key.
Steps To ReproduceAs "System" go to window "Tables and columns" and select table "m_product"
-got to tab "Columns"
-find the column "M_AttributeSetInstance_ID" an check as "Identifier"

After that as "Admin" go to window "Sales Order":
-Create a "header"
-Go to lines and insert a line in grid view
-Try to find a product that it must be in the list but it has the value in column "M_AttributeSetInstance_ID" as null.

You will see that you can not find the product
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff FixIssue22007_2.diff (4,010) 2012-10-28 19:01
https://issues.openbravo.com/file_download.php?file_id=5687&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-10-19 10:05jecharriNew Issue
2012-10-19 10:05jecharriAssigned To => AugustoMauch
2012-10-19 10:05jecharriWeb browser => Google Chrome
2012-10-19 10:05jecharriModules => Core
2012-10-19 10:05jecharriResolution time => 1353452400
2012-10-19 11:35AugustoMauchAssigned ToAugustoMauch => shankarb
2012-10-24 09:40jecharriWeb browserGoogle Chrome => Google Chrome
2012-10-24 09:40jecharriPriorityurgent => immediate
2012-10-26 14:28shankarbFile Added: FixIssue22007.diff
2012-10-26 14:28shankarbStatusnew => acknowledged
2012-10-28 19:01shankarbFile Added: FixIssue22007_2.diff
2012-10-30 10:13shankarbWeb browserGoogle Chrome => Google Chrome
2012-10-30 10:13shankarbNote Added: 0053791
2012-10-30 10:13shankarbPriorityimmediate => urgent
2012-10-30 10:13shankarbTarget Version3.0MP17 => 3.0MP18
2012-10-30 12:52shankarbFile Deleted: FixIssue22007.diff
2012-11-19 12:26hgbotCheckin
2012-11-19 12:26hgbotNote Added: 0054305
2012-11-19 12:26hgbotStatusacknowledged => resolved
2012-11-19 12:26hgbotResolutionopen => fixed
2012-11-19 12:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/506b45ab88e4fc5eaaed5a14ed1c0189f166ce36 [^]
2012-11-19 12:27shankarbNote Added: 0054306
2012-11-19 12:27shankarbStatusresolved => new
2012-11-19 12:27shankarbResolutionfixed => open
2012-11-19 12:27shankarbReview Assigned To => AugustoMauch
2012-11-19 12:27shankarbWeb browserGoogle Chrome => Google Chrome
2012-11-19 12:27shankarbIssue Monitored: AugustoMauch
2012-11-19 12:27shankarbStatusnew => scheduled
2012-11-19 12:27shankarbNote Added: 0054307
2012-11-19 12:27shankarbfix_in_branch => pi
2012-11-19 12:36shankarbNote Added: 0054309
2012-11-19 12:36shankarbStatusscheduled => resolved
2012-11-19 12:36shankarbResolutionopen => fixed
2012-11-21 06:07hudsonbotCheckin
2012-11-21 06:07hudsonbotNote Added: 0054396
2012-11-21 23:29hgbotCheckin
2012-11-21 23:29hgbotNote Added: 0054445
2012-11-21 23:29hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/506b45ab88e4fc5eaaed5a14ed1c0189f166ce36 [^] => http://code.openbravo.com/erp/devel/pi/rev/67f3916500d999b9abc9a7482123bbc68d42ebb9 [^]
2012-11-27 11:42AugustoMauchNote Added: 0054537
2012-11-27 11:42AugustoMauchStatusresolved => closed
2012-11-27 11:42AugustoMauchFixed in Version => 3.0MP18

Notes
(0053791)
shankarb   
2012-10-30 10:13   
The version has been changed because this is a risky fix that could affect the core of the DAL and the way Identifiers are formed across the System. So the solution will be tested as a patch and then pushed in the next MP version.
(0054305)
hgbot   
2012-11-19 12:26   
Repository: erp/devel/pi
Changeset: 506b45ab88e4fc5eaaed5a14ed1c0189f166ce36
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Sun Oct 28 18:50:13 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/506b45ab88e4fc5eaaed5a14ed1c0189f166ce36 [^]

Fixes Issue 0022007 : Handling null values in filter by identifiers.

Added a new method replaceValueWithJoins to handle cases where joins are formed but the property path is used to compare with values.
For eg., instead of join_4.description, e.product.attributeSetValue.description is used in the where clause which results in exception when nullobjects are sub referenced.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
---
(0054306)
shankarb   
2012-11-19 12:27   
Reopened to add Review Assigned to
(0054307)
shankarb   
2012-11-19 12:27   
Scheduled
(0054309)
shankarb   
2012-11-19 12:36   
Fixed
(0054396)
hudsonbot   
2012-11-21 06:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c3c5e61b0164 [^]

Maturity status: Test
(0054445)
hgbot   
2012-11-21 23:29   
Repository: erp/devel/pi
Changeset: 67f3916500d999b9abc9a7482123bbc68d42ebb9
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Nov 21 23:27:24 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/67f3916500d999b9abc9a7482123bbc68d42ebb9 [^]

Fixes Issue 0022007 : Handling null values in filter by identifiers.

Modifications in replaceValueWithJoins to handle multiple joins and computed orderByClause before computing whereClause to handle the joins properly.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
---
(0054537)
AugustoMauch   
2012-11-27 11:42   
Code reviewed and verified in pi@b43e48d603a9