Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0021967Openbravo ERPA. Platformpublic2012-10-17 11:552012-11-21 06:07
egoitz 
AugustoMauch 
urgentmajorhave not tried
closedfixed 
5
 
3.0MP18pi 
shankarb
Core
No
0021967: The value on time fields is changed when adding or deleting a row on a subtab of the tab where the fields are located
The value on time fields is changed when adding or deleting a row on a subtab of the tab where the fields are located.
-Activate the instance to show the production module
-Go to workeffort window
-Add a new row with a starting time and ending date. for example 08:00 and 09:00
-Save it
-Go to a subtab
-Enter a new row
-Go to the tab and change from form to grid and viceversa
*see that the starttime and endtime are change.

*When deleting the row on the subtab the same happens.
No tags attached.
diff FixIssue21967.diff (1,723) 2012-11-15 15:22
https://issues.openbravo.com/file_download.php?file_id=5735&type=bug
Issue History
2012-10-17 11:55egoitzNew Issue
2012-10-17 11:55egoitzAssigned To => AugustoMauch
2012-10-17 11:55egoitzModules => Core
2012-10-17 11:55egoitzResolution time => 1352934000
2012-10-17 11:57egoitzIssue Monitored: networkb
2012-11-06 15:15shankarbAssigned ToAugustoMauch => shankarb
2012-11-09 09:23shankarbFile Added: FixIssue21967.diff
2012-11-14 11:04mtaalNote Added: 0054218
2012-11-14 12:02mtaalNote Added: 0054220
2012-11-15 15:22shankarbFile Deleted: FixIssue21967.diff
2012-11-15 15:22shankarbFile Added: FixIssue21967.diff
2012-11-19 10:39shankarbAssigned Toshankarb => AugustoMauch
2012-11-19 10:39shankarbStatusnew => scheduled
2012-11-19 10:39shankarbfix_in_branch => pi
2012-11-19 16:51AugustoMauchIssue Monitored: shankarb
2012-11-19 16:52AugustoMauchReview Assigned To => shankarb
2012-11-19 16:52AugustoMauchfix_in_branchpi =>
2012-11-19 16:52hgbotCheckin
2012-11-19 16:52hgbotNote Added: 0054323
2012-11-19 16:52hgbotStatusscheduled => resolved
2012-11-19 16:52hgbotResolutionopen => fixed
2012-11-19 16:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e2a425c9139b123ced6d9826a7e57745616c2169 [^]
2012-11-19 17:08shankarbNote Added: 0054324
2012-11-19 17:08shankarbStatusresolved => closed
2012-11-19 17:08shankarbFixed in Version => pi
2012-11-21 06:07hudsonbotCheckin
2012-11-21 06:07hudsonbotNote Added: 0054401

Notes
(0054218)
mtaal   
2012-11-14 11:04   
Hmm, this issue seems to be somewhat complex. For example I have a record with start/end time of 8:00 and 9:00. When I refresh explicitly the server returns a record with 7:00 and 8:00 (GMT times) the grid shows this correctly as 8:00 and 9:00.

However when doing the refresh as part of the delete of a subtab row then the client seems to incorrectly do not do GMT correction. In this case the server correctly sends the 7:00 and 8:00, but the grid does not translate it correctly to 8:00 and 9:00.
(0054220)
mtaal   
2012-11-14 12:02   
To further debug this, you can check the isc.Time.toTime method or the OBTimeItem.setValue methods, see what value they get passed in when a subtab row is deleted.
(0054323)
hgbot   
2012-11-19 16:52   
Repository: erp/devel/pi
Changeset: e2a425c9139b123ced6d9826a7e57745616c2169
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Nov 19 16:47:32 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e2a425c9139b123ced6d9826a7e57745616c2169 [^]

Fixes bug 21967: Time fields value not changed when updated from the child view

The conversion from UTC to local time was not being done when a child view was updated and its parent view refreshed

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0054324)
shankarb   
2012-11-19 17:08   
Tested and verified in changeset e2a425c9139b in pi.
(0054401)
hudsonbot   
2012-11-21 06:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c3c5e61b0164 [^]

Maturity status: Test