Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0021934Openbravo ERP09. Financial managementpublic2012-10-15 11:262012-10-25 12:38
mtaal 
pramakrishnan 
normalmajorhave not tried
closedfixed 
5
 
3.0MP17 
dmiguelez
Core
No
0021934: Readonly logic in column definition has wrong format
See the payment in window.
When opening this window you see the following trace statement:

>>>>>>> Issues found in javascript <<<<<<<<<
Core.View:1035:162: The '&&' subexpression should be wrapped in parens. >> offending code: f.disableItem('financialTransactionConvertRate', context.NotAllowChangeExchange === 'Y' || OB.Utilities.getValue(currentValues,'processed') === true && OB.Utilities.getValue(currentValues,'status') !== 'RPAE');
>>>>>>> Issues (1881ms) <<<<<<<<<

The reason is that the column (see attached screenshot) has read only logic with an | operator and a && operator. This |/or part should be wrapped in a ( and ).
Goto payment in window and check the trace.
No tags attached.
png Selection_006.png (60,018) 2012-10-15 11:26
https://issues.openbravo.com/file_download.php?file_id=5653&type=bug
png
Issue History
2012-10-15 11:26mtaalNew Issue
2012-10-15 11:26mtaalAssigned To => eduardo_Argal
2012-10-15 11:26mtaalFile Added: Selection_006.png
2012-10-15 11:26mtaalModules => Core
2012-10-23 10:06pramakrishnanAssigned Toeduardo_Argal => pramakrishnan
2012-10-23 10:06pramakrishnanStatusnew => scheduled
2012-10-23 10:06pramakrishnanfix_in_branch => pi
2012-10-24 11:28hgbotCheckin
2012-10-24 11:28hgbotNote Added: 0053596
2012-10-24 11:28hgbotStatusscheduled => resolved
2012-10-24 11:28hgbotResolutionopen => fixed
2012-10-24 11:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0a2bdc2397de90a6fabccf609a7703d7b00c3461 [^]
2012-10-24 11:29dmiguelezReview Assigned To => dmiguelez
2012-10-24 11:29dmiguelezNote Added: 0053597
2012-10-24 11:29dmiguelezStatusresolved => closed
2012-10-25 12:38hudsonbotCheckin
2012-10-25 12:38hudsonbotNote Added: 0053705

Notes
(0053596)
hgbot   
2012-10-24 11:28   
Repository: erp/devel/pi
Changeset: 0a2bdc2397de90a6fabccf609a7703d7b00c3461
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Tue Oct 23 10:27:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0a2bdc2397de90a6fabccf609a7703d7b00c3461 [^]

Fixes Issue 21934: Readonly logic in column definition has wrong format

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0053597)
dmiguelez   
2012-10-24 11:29   
Code Review + Testing OK
(0053705)
hudsonbot   
2012-10-25 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4a27e27689bc [^]

Maturity status: Test