Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0021933Openbravo ERP03. Procurement managementpublic2012-10-15 11:232012-11-21 06:06
pramakrishnan 
pramakrishnan 
normalmajoralways
closedfixed 
30Professional Appliance
pi 
 
Core
No
0021933: API Change : Cascade on delete options for constraints in m_matchpo table
When records are deleted from Goods Receipt Lines and Goods Shipment Lines, they are not removed from M_Matchpo. So we are not able to delete lines that are created from Orders.
1. Use create from option to create lines in Goods Shipment from any Order.
2. Try to delete that line. It will show dependency error.
cascade on delete option is needed for the following fields in m_matchpo
1. m_inoutline_id
2. c_orderline_id

API change is needed.
No tags attached.
Issue History
2012-10-15 11:23pramakrishnanNew Issue
2012-10-15 11:23pramakrishnanAssigned To => dmiguelez
2012-10-15 11:23pramakrishnanModules => Core
2012-10-15 11:24pramakrishnanAssigned Todmiguelez => iciordia
2012-10-15 12:04iciordiaNote Added: 0053349
2012-10-15 14:44pramakrishnanNote Added: 0053352
2012-10-15 18:33iciordiaNote Added: 0053357
2012-10-15 18:33iciordiaAssigned Toiciordia => pramakrishnan
2012-10-16 13:06pramakrishnanStatusnew => scheduled
2012-10-16 13:06pramakrishnanfix_in_branch => pi
2012-11-14 13:36hgbotCheckin
2012-11-14 13:36hgbotNote Added: 0054225
2012-11-14 13:36hgbotStatusscheduled => resolved
2012-11-14 13:36hgbotResolutionopen => fixed
2012-11-14 13:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a7d41be10b1bb59d84f47a6667ffdbe483fdf776 [^]
2012-11-14 16:09SandrahuguetNote Added: 0054236
2012-11-14 16:09SandrahuguetStatusresolved => closed
2012-11-21 06:06hudsonbotCheckin
2012-11-21 06:06hudsonbotNote Added: 0054379

Notes
(0053349)
iciordia   
2012-10-15 12:04   
Pandee, I don't see an evaluation of the risk of this api change. Please add it to the issue and I will react (talk to Eduardo for guidance).

Ismael
(0053352)
pramakrishnan   
2012-10-15 14:44   
This API change does not have any risk because, before doing the fix for the issue https://issues.openbravo.com/view.php?id=19043, [^] no action will trigger this cascade delete constraint as the completed goods receipt can never be deleted. But now I have added rows in m_matchpo before completing an shipment which throws the dependency error in goods receipt lines. This occurs only when creating lines from order since the cascade delete constraint is already present in m_matchinv. After discussing with Pablo Sarobe, he told the cascade delete constraint is only needed for the column m_inoutline_id and not for c_orderline_id.
(0053357)
iciordia   
2012-10-15 18:33   
Approved.

Ismael
(0054225)
hgbot   
2012-11-14 13:36   
Repository: erp/devel/pi
Changeset: a7d41be10b1bb59d84f47a6667ffdbe483fdf776
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Tue Oct 16 13:13:02 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a7d41be10b1bb59d84f47a6667ffdbe483fdf776 [^]

Fixes Issue 21933 : Cascade on delete options for m_inoutline_id in m_matchpo

---
M src-db/database/model/tables/M_MATCHPO.xml
---
(0054236)
Sandrahuguet   
2012-11-14 16:09   
Code review + testing OK
(0054379)
hudsonbot   
2012-11-21 06:06   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c3c5e61b0164 [^]

Maturity status: Test